fix(04): revise plans based on checker feedback
All checks were successful
CI / build-test (push) Successful in 1m31s
All checks were successful
CI / build-test (push) Successful in 1m31s
This commit is contained in:
@@ -233,7 +233,7 @@ From frontend/src/index.css (CSS vars - note: no --destructive or --card defined
|
||||
Then in ServiceCard.tsx, remove the local `getRegistry` function and add `import { getRegistry } from '@/lib/utils'` (alongside the existing `cn` import: `import { cn, getRegistry } from '@/lib/utils'`).
|
||||
</action>
|
||||
<verify>
|
||||
<automated>cd /home/jean-luc-makiola/Development/projects/DiunDashboard/frontend && npx tsc --noEmit</automated>
|
||||
<automated>cd /home/jean-luc-makiola/Development/projects/DiunDashboard/frontend && bunx tsc --noEmit</automated>
|
||||
</verify>
|
||||
<acceptance_criteria>
|
||||
- main.tsx contains `localStorage.getItem('theme')` and `prefers-color-scheme`
|
||||
@@ -247,7 +247,7 @@ From frontend/src/index.css (CSS vars - note: no --destructive or --card defined
|
||||
- ServiceCard.tsx does NOT contain `opacity-0 group-hover:opacity-100` on the drag handle
|
||||
- lib/utils.ts contains `export function getRegistry`
|
||||
- ServiceCard.tsx contains `import` with `getRegistry` from `@/lib/utils`
|
||||
- `npx tsc --noEmit` exits 0
|
||||
- `bunx tsc --noEmit` exits 0
|
||||
</acceptance_criteria>
|
||||
<done>Theme toggle works (sun/moon icon in header, persists to localStorage, respects system preference on first visit); drag handle always visible at 40% opacity; getRegistry is a shared utility</done>
|
||||
</task>
|
||||
@@ -363,7 +363,7 @@ From frontend/src/index.css (CSS vars - note: no --destructive or --card defined
|
||||
Import `UpdateEntry` type if needed for the `as` cast.
|
||||
</action>
|
||||
<verify>
|
||||
<automated>cd /home/jean-luc-makiola/Development/projects/DiunDashboard/frontend && npx tsc --noEmit && bun run build</automated>
|
||||
<automated>cd /home/jean-luc-makiola/Development/projects/DiunDashboard/frontend && bunx tsc --noEmit && bun run build</automated>
|
||||
</verify>
|
||||
<acceptance_criteria>
|
||||
- FilterBar.tsx exists and exports `FilterBar` component
|
||||
@@ -388,7 +388,7 @@ From frontend/src/index.css (CSS vars - note: no --destructive or --card defined
|
||||
<verification>
|
||||
```bash
|
||||
cd /home/jean-luc-makiola/Development/projects/DiunDashboard/frontend
|
||||
npx tsc --noEmit
|
||||
bunx tsc --noEmit
|
||||
bun run build
|
||||
```
|
||||
</verification>
|
||||
|
||||
Reference in New Issue
Block a user