chore: archive v2.3 milestone files
Archive setup sharing, currency system, and i18n foundation milestone. Reorganize ROADMAP.md with v2.3 details block, update PROJECT.md, MILESTONES.md, STATE.md deferred items, and RETROSPECTIVE.md. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -1,5 +1,26 @@
|
||||
# Milestones
|
||||
|
||||
## v2.3 Global & Social Ready (Shipped: 2026-04-19)
|
||||
|
||||
**Phases completed:** 3 phases (32-34), 18 plans
|
||||
**Timeline:** 6 days (2026-04-13 → 2026-04-19)
|
||||
**Codebase:** 217 files changed (+24,291 / -991), 99 commits
|
||||
|
||||
**Key accomplishments:**
|
||||
|
||||
- Setup visibility system: isPublic replaced with private/link/public visibility column, shares table with 128-bit token entropy, visibility-transition side effects (deactivate/reactivate links)
|
||||
- ShareModal with Google Docs-style UX: visibility picker, share link creation with expiry, active links list with revoke, deactivation warning
|
||||
- Shared setup viewer: `/s/:token` short URL redirect, `/api/shared/:token` public endpoint, read-only mode with owner controls gated, inline "Shared setup" banner
|
||||
- Multi-currency foundation: market_prices + community_prices tables, ECB exchange rates via frankfurter.app with 24h cache, currency conversion service
|
||||
- Community price aggregation: ownership-validated submissions, PERCENTILE_CONT(0.5) median with 3-report minimum, market-aware MSRP on catalog detail pages
|
||||
- i18n framework: react-i18next + 6 namespaces (common/collection/threads/setups/onboarding/settings/catalog), English + German locales, language picker in settings, locale-aware formatting
|
||||
|
||||
**Known deferred items at close:** 6 (see STATE.md Deferred Items)
|
||||
|
||||
**Archive:** `.planning/milestones/v2.3-ROADMAP.md`, `.planning/milestones/v2.3-REQUIREMENTS.md`
|
||||
|
||||
---
|
||||
|
||||
## v2.2 User Experience Polish (Shipped: 2026-04-13)
|
||||
|
||||
**Phases completed:** 36 phases, 68 plans, 120 tasks
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
## What This Is
|
||||
|
||||
A gear management and discovery platform. Users catalog their gear collections (bikepacking, sim racing, or any hobby), track weight, price, and source details, research purchases through planning threads with side-by-side comparison, and compose named setups (loadouts) with weight classification and visualization. A global item database with crowd-verified specs and structured reviews helps users make informed purchase decisions. Multi-user with public setup sharing and gear discovery.
|
||||
A gear management and discovery platform. Users catalog their gear collections (bikepacking, sim racing, or any hobby), track weight, price, and source details, research purchases through planning threads with side-by-side comparison, and compose named setups (loadouts) with weight classification and visualization. A global item database with crowd-verified specs and market-aware pricing helps users make informed purchase decisions. Multi-user with granular setup sharing (private/link/public), multi-currency support, and a fully internationalized UI (English + German).
|
||||
|
||||
## Core Value
|
||||
|
||||
@@ -65,18 +65,18 @@ Help people make better gear decisions — discover what others use, compare rea
|
||||
- ✓ Catalog-driven onboarding flow with hobby picker, category-grouped item browser, and batch collection creation — v2.2
|
||||
- ✓ Mobile icon-based action buttons on detail pages — v2.2
|
||||
|
||||
- ✓ Setup visibility toggle (private/link/public) with shares table, 128-bit token entropy, deactivate/reactivate on transition — v2.3
|
||||
- ✓ ShareModal with Google Docs-style UX: visibility picker, link creation/expiry, revoke, deactivation warning — v2.3
|
||||
- ✓ Shared setup viewer: `/s/:token` short URL, read-only mode, inline "Shared setup" banner — v2.3
|
||||
- ✓ Multi-currency support: market_prices + community_prices tables, ECB exchange rates (24h cache), conversion service — v2.3
|
||||
- ✓ Community price aggregation: ownership-validated submissions, median with 3-report minimum, market-aware MSRP on catalog detail — v2.3
|
||||
- ✓ i18n foundation: react-i18next, 7 namespaces, English + German translations, language picker, locale-aware formatting — v2.3
|
||||
|
||||
### Active
|
||||
|
||||
- ✓ i18n foundation: react-i18next framework, English + German locales, locale-aware formatting, language picker — v2.3
|
||||
|
||||
## Current Milestone: v2.3 Global & Social Ready
|
||||
|
||||
**Goal:** Make GearBox work for a global audience with setup sharing, multi-currency support, and localization infrastructure.
|
||||
|
||||
**Target features:**
|
||||
- Setup sharing system with visibility toggle (private/link/public)
|
||||
- Multi-currency support (USD/EUR/GBP) with user preference
|
||||
- i18n foundation with translation framework and locale-aware formatting
|
||||
- [ ] Freeform reviews with moderation system
|
||||
- [ ] Comments on setups
|
||||
- [ ] Follow users / activity feeds
|
||||
|
||||
### Future
|
||||
|
||||
@@ -85,6 +85,7 @@ Help people make better gear decisions — discover what others use, compare rea
|
||||
- [ ] Follow users / activity feeds
|
||||
- [ ] OAuth / social login providers
|
||||
- [ ] User-to-user messaging
|
||||
- [ ] ComparisonTable currency normalization (hooks available, needs real multi-currency test data)
|
||||
|
||||
### Out of Scope
|
||||
|
||||
@@ -100,12 +101,12 @@ Help people make better gear decisions — discover what others use, compare rea
|
||||
|
||||
## Context
|
||||
|
||||
Shipped through v2.2 with 31 phases across 6 milestones. All milestones v1.0-v2.2 complete. Phase 34 (i18n Foundation) complete — v2.3 in progress.
|
||||
Tech stack: React 19, Hono, Drizzle ORM, PostgreSQL, TanStack Router/Query, Tailwind CSS v4, Lucide React, Recharts, framer-motion, all on Bun.
|
||||
Shipped through v2.3 with 34 phases across 7 milestones. All milestones v1.0-v2.3 complete.
|
||||
Tech stack: React 19, Hono, Drizzle ORM, PostgreSQL, TanStack Router/Query, Tailwind CSS v4, Lucide React, Recharts, framer-motion, react-i18next, all on Bun.
|
||||
Primary use case is bikepacking gear but data model is hobby-agnostic.
|
||||
Auth: External OIDC via Logto (browser sessions) + API keys (programmatic) + MCP OAuth (Claude).
|
||||
Infrastructure: PostgreSQL, MinIO (S3-compatible image storage), Docker Compose for dev/prod.
|
||||
Features: MCP server (21 tools), global item catalog with attribution and bulk import, user profiles with Logto account management, public setup sharing, catalog-driven onboarding, fit-within image framing with crop editor, item/candidate detail pages, candidate ranking/comparison/impact preview. Public discovery landing page with catalog search, popular setups feed, recent items, and trending categories. Top nav + mobile bottom tab bar.
|
||||
Features: MCP server (21 tools), global item catalog with attribution/bulk import/market prices, user profiles with Logto account management, granular setup sharing (private/link/public) with share tokens, multi-currency pricing (USD/EUR/GBP) with ECB rates and community aggregation, i18n (English + German, 7 namespaces), catalog-driven onboarding, fit-within image framing with crop editor, item/candidate detail pages, candidate ranking/comparison/impact preview. Public discovery landing page with catalog search, popular setups feed, recent items, and trending categories. Top nav + mobile bottom tab bar.
|
||||
20+ test files (service-level, route-level integration, MCP). E2E tests pending rewrite for OIDC auth (backlog 999.1).
|
||||
|
||||
## Constraints
|
||||
@@ -159,6 +160,15 @@ Features: MCP server (21 tools), global item catalog with attribution and bulk i
|
||||
| Click-to-cycle for ClassificationBadge | Only 3 values, simpler than popup | ✓ Good |
|
||||
| Classification-preserving sync via Map | Save metadata before delete, restore after re-insert | ✓ Good |
|
||||
| Recharts for charting | Mature React chart library, composable API | ✓ Good |
|
||||
| visibility text column (not boolean) | Future-proofs for additional sharing modes, readable in queries | ✓ Good |
|
||||
| shares table separate from setups | Enables future per-person shares, write permissions, and revocation | ✓ Good |
|
||||
| 128-bit base64url share tokens | URL-safe, sufficient entropy, no external dep | ✓ Good |
|
||||
| Deactivate/reactivate on visibility change | Share links survive visibility round-trips, not destroyed | ✓ Good |
|
||||
| EUR default price currency | Matches existing data assumption from early single-user era | ✓ Good |
|
||||
| Module-level ECB rate cache | Simple, single-process, avoids DB or Redis for rate storage | ✓ Good |
|
||||
| Community price median with 3-report floor | Prevents manipulation from single-user submissions | ✓ Good |
|
||||
| i18next namespace-per-feature | Matches TanStack Router file-based routing, lazy-loadable | ✓ Good |
|
||||
| localStorage language key (gearbox-language) | User preference wins over browser default in detection order | ✓ Good |
|
||||
|
||||
## Evolution
|
||||
|
||||
@@ -178,4 +188,4 @@ This document evolves at phase transitions and milestone boundaries.
|
||||
4. Update Context with current state
|
||||
|
||||
---
|
||||
*Last updated: 2026-04-10 after Phase 27 complete — top nav restructure & search bar rethink*
|
||||
*Last updated: 2026-04-19 after v2.3 milestone — Global & Social Ready*
|
||||
|
||||
@@ -2,6 +2,49 @@
|
||||
|
||||
*A living document updated after each milestone. Lessons feed forward into future planning.*
|
||||
|
||||
## Milestone: v2.3 — Global & Social Ready
|
||||
|
||||
**Shipped:** 2026-04-19
|
||||
**Phases:** 3 (32-34) | **Plans:** 18 | **Commits:** 99
|
||||
|
||||
### What Was Built
|
||||
- Setup visibility system replacing boolean isPublic with private/link/public, share tokens with 128-bit entropy, and visibility-transition side effects
|
||||
- ShareModal with Google Docs-style UX — visibility picker, link creation/expiry, revoke, deactivation warning
|
||||
- Shared setup viewer with short URL redirect, read-only mode, and three-way data source logic
|
||||
- Multi-currency pricing: ECB exchange rates with 24h cache, market_prices and community_prices tables, ownership-validated submissions, median aggregation
|
||||
- Market-aware MSRP on catalog detail pages with collapsible "Other Markets" section
|
||||
- i18n framework: react-i18next, 7 namespaces, English + German translations, language detection, language picker
|
||||
|
||||
### What Worked
|
||||
- Phased schema approach: do the migration first (32-01), service layer next, UI last — no mid-phase schema surprises
|
||||
- Dynamic import to break circular dependency (setup.service.ts → share.service.ts) was clean and discovered quickly
|
||||
- ECB exchange rate module-level cache is dead simple and effective for a single-process Bun app
|
||||
- Namespace-per-feature for i18n matches the existing file-based routing structure naturally
|
||||
|
||||
### What Was Inefficient
|
||||
- Phase 32 progress table in ROADMAP.md showed 0/4 Planned despite all plans being complete — tracking drift not caught until milestone close
|
||||
- Several todos from early in the milestone (April 10) accumulated and weren't cleared before close — 6 deferred items
|
||||
- REQUIREMENTS.md was never refreshed for v2.2 or v2.3; requirements were tracked informally in STATE.md decisions
|
||||
|
||||
### Patterns Established
|
||||
- `visibility` text enum over boolean flags for any future toggle-able states (shareable, public, featured)
|
||||
- Shares as a separate table with revocation semantics — reusable pattern for future permission systems
|
||||
- Community aggregation floor (3 reports minimum) before surfacing median — prevents single-user stat manipulation
|
||||
- i18n namespace per feature domain matches the codebase's existing routing and component organization
|
||||
|
||||
### Key Lessons
|
||||
1. Keep REQUIREMENTS.md current across milestones — informal tracking in STATE.md decisions is not a substitute
|
||||
2. Todo triage at milestone close works, but earlier triage (mid-milestone) would reduce the deferred backlog
|
||||
3. The shares deactivate/reactivate pattern (not destroy) gives users a better experience at near-zero complexity cost
|
||||
4. Language detection: localStorage-first is the right call — user preference must win over browser default
|
||||
|
||||
### Cost Observations
|
||||
- Model mix: sonnet throughout
|
||||
- Sessions: ~18 plan executions across 6 days
|
||||
- Notable: Phase 34 (i18n) was the heaviest at 8 plans — string extraction across the full app touches every component
|
||||
|
||||
---
|
||||
|
||||
## Milestone: v1.0 — MVP
|
||||
|
||||
**Shipped:** 2026-03-15
|
||||
|
||||
@@ -9,7 +9,7 @@
|
||||
- ✅ **v2.0 Platform Foundation** — Phases 14-23 (shipped 2026-04-08)
|
||||
- ✅ **v2.1 Public Discovery** — Phases 24-27 (shipped 2026-04-12)
|
||||
- ✅ **v2.2 User Experience Polish** — Phases 28-31 (shipped 2026-04-13)
|
||||
- 🚧 **v2.3 Global & Social Ready** — Phases 32-34 (planned)
|
||||
- ✅ **v2.3 Global & Social Ready** — Phases 32-34 (shipped 2026-04-19)
|
||||
|
||||
## Phases
|
||||
|
||||
@@ -86,13 +86,14 @@
|
||||
|
||||
</details>
|
||||
|
||||
### v2.3 Global & Social Ready (Planned)
|
||||
<details>
|
||||
<summary>✅ v2.3 Global & Social Ready (Phases 32-34) — SHIPPED 2026-04-19</summary>
|
||||
|
||||
**Milestone Goal:** Make GearBox work for a global audience with setup sharing, multi-currency support, and localization infrastructure.
|
||||
- [x] Phase 32: Setup Sharing System (4/4 plans) — completed 2026-04-15
|
||||
- [x] Phase 33: Currency System (6/6 plans) — completed 2026-04-13
|
||||
- [x] Phase 34: i18n Foundation (8/8 plans) — completed 2026-04-18
|
||||
|
||||
- [ ] **Phase 32: Setup Sharing System** — Visibility toggle (private/link/public), link sharing, schema future-proofed for likes, friends, and collaborative editing
|
||||
- [x] **Phase 33: Currency System** — Multi-currency support (USD/EUR/GBP), price display per user preference (completed 2026-04-13)
|
||||
- [x] **Phase 34: i18n Foundation** — Translation framework, string extraction, locale-aware formatting (completed 2026-04-13)
|
||||
</details>
|
||||
|
||||
## Phase Details
|
||||
|
||||
@@ -247,7 +248,7 @@ Plans:
|
||||
| 29. Image Presentation | v2.2 | 5/5 | Complete | 2026-04-13 |
|
||||
| 30. Onboarding Redesign | v2.2 | 3/3 | Complete | 2026-04-12 |
|
||||
| 31. Mobile Polish | v2.2 | 2/2 | Complete | 2026-04-12 |
|
||||
| 32. Setup Sharing System | v2.3 | 0/4 | Planned | — |
|
||||
| 32. Setup Sharing System | v2.3 | 4/4 | Complete | 2026-04-15 |
|
||||
| 33. Currency System | v2.3 | 6/6 | Complete | 2026-04-13 |
|
||||
| 34. i18n Foundation | v2.3 | 8/8 | Complete | 2026-04-18 |
|
||||
|
||||
|
||||
@@ -3,8 +3,8 @@ gsd_state_version: 1.0
|
||||
milestone: v2.3
|
||||
milestone_name: Global & Social Ready
|
||||
status: executing
|
||||
stopped_at: Completed 34-02-PLAN.md
|
||||
last_updated: "2026-04-18T12:41:36.836Z"
|
||||
stopped_at: context exhaustion at 90% (2026-04-19)
|
||||
last_updated: "2026-04-19T14:11:38.116Z"
|
||||
last_activity: 2026-04-18
|
||||
progress:
|
||||
total_phases: 16
|
||||
@@ -94,6 +94,19 @@ v2.1 decisions:
|
||||
|
||||
None.
|
||||
|
||||
## Deferred Items
|
||||
|
||||
Items acknowledged and deferred at milestone close on 2026-04-19:
|
||||
|
||||
| Category | Item | Status |
|
||||
|----------|------|--------|
|
||||
| quick_task | 260406-j44-comprehensive-dev-seed-script-for-bikepa | missing tracking marker (work complete) |
|
||||
| todo | 2026-04-10-add-cursor-pointer-to-all-clickable-links | pending |
|
||||
| todo | 2026-04-10-fix-item-image-not-showing-on-collection-overview | pending |
|
||||
| todo | 2026-04-10-investigate-slow-image-loading | pending |
|
||||
| todo | 2026-04-13-auth-prompt-sign-in-button-should-redirect-directly-to-logto | pending |
|
||||
| todo | 2026-04-13-fix-add-candidate-button-shows-wrong-modal-on-thread-page | pending |
|
||||
|
||||
### Quick Tasks Completed
|
||||
|
||||
| # | Description | Date | Commit | Directory |
|
||||
@@ -105,6 +118,6 @@ None.
|
||||
|
||||
## Session Continuity
|
||||
|
||||
Last session: 2026-04-18T12:02:16.060Z
|
||||
Stopped at: Completed 34-02-PLAN.md
|
||||
Last session: 2026-04-19T14:11:38.113Z
|
||||
Stopped at: context exhaustion at 90% (2026-04-19)
|
||||
Resume file: None
|
||||
|
||||
78
.planning/milestones/v2.3-REQUIREMENTS.md
Normal file
78
.planning/milestones/v2.3-REQUIREMENTS.md
Normal file
@@ -0,0 +1,78 @@
|
||||
# Requirements Archive: GearBox v2.3 Global & Social Ready
|
||||
|
||||
**Archived:** 2026-04-19
|
||||
**Milestone shipped:** v2.3
|
||||
|
||||
> Note: The active REQUIREMENTS.md at close was scoped to v2.1 Public Discovery requirements (all complete).
|
||||
> v2.3-specific requirements (sharing, currency, i18n) were tracked as decisions in STATE.md and active items in PROJECT.md.
|
||||
|
||||
---
|
||||
|
||||
# Requirements: GearBox v2.1 Public Discovery
|
||||
|
||||
**Defined:** 2026-04-09
|
||||
**Core Value:** Help people make better gear decisions — discover what others use, compare real-world data, and see how a potential buy affects your setup before committing.
|
||||
|
||||
## v2.1 Requirements
|
||||
|
||||
### Public Access
|
||||
|
||||
- [x] **PUBL-01**: User can browse the global item catalog without logging in
|
||||
- [x] **PUBL-02**: User can view public setups without logging in
|
||||
- [x] **PUBL-03**: User can view user profiles without logging in
|
||||
- [x] **PUBL-04**: Anonymous visitors see the landing page without auth spinner or redirect
|
||||
- [x] **PUBL-05**: Login is only required when user attempts to create/edit/delete their own data
|
||||
|
||||
### Discovery
|
||||
|
||||
- [x] **DISC-01**: Landing page displays an always-visible catalog search bar at the top
|
||||
- [x] **DISC-02**: Landing page shows a feed of popular setups below the search
|
||||
- [x] **DISC-03**: Landing page shows recently added catalog items
|
||||
- [x] **DISC-04**: Landing page shows trending categories
|
||||
- [x] **DISC-05**: Authenticated users see a "Go to Collection" entry point from the landing page
|
||||
|
||||
### Catalog Enrichment
|
||||
|
||||
- [x] **CATL-01**: Global items have attribution fields (sourceUrl, manufacturer, imageCredit, imageSourceUrl)
|
||||
- [x] **CATL-02**: Global items have a unique constraint on (brand, model) preventing duplicates
|
||||
- [x] **CATL-03**: Catalog detail pages display image attribution with credit and source link
|
||||
- [x] **CATL-04**: Bulk import API endpoint accepts multiple catalog items in one request
|
||||
- [x] **CATL-05**: Bulk import uses upsert semantics (ON CONFLICT update, not fail)
|
||||
|
||||
### Agent Seeding Tools
|
||||
|
||||
- [x] **SEED-01**: MCP server has a dedicated `upsert_catalog_item` tool that writes to globalItems (not user-scoped)
|
||||
- [x] **SEED-02**: MCP server has a `bulk_upsert_catalog` tool for batch catalog population
|
||||
- [x] **SEED-03**: Catalog MCP tools include attribution fields (sourceUrl, manufacturer, imageCredit) as parameters
|
||||
|
||||
### Infrastructure
|
||||
|
||||
- [x] **INFR-01**: Public API endpoints are rate-limited to prevent abuse
|
||||
- [x] **INFR-02**: Discovery feed endpoint uses cursor pagination for scalability
|
||||
|
||||
## Traceability
|
||||
|
||||
| Requirement | Phase | Status |
|
||||
|-------------|-------|--------|
|
||||
| PUBL-01 | Phase 24 | Complete |
|
||||
| PUBL-02 | Phase 24 | Complete |
|
||||
| PUBL-03 | Phase 24 | Complete |
|
||||
| PUBL-04 | Phase 24 | Complete |
|
||||
| PUBL-05 | Phase 24 | Complete |
|
||||
| INFR-01 | Phase 24 | Complete |
|
||||
| CATL-01 | Phase 25 | Complete |
|
||||
| CATL-02 | Phase 25 | Complete |
|
||||
| CATL-03 | Phase 25 | Complete |
|
||||
| CATL-04 | Phase 25 | Complete |
|
||||
| CATL-05 | Phase 25 | Complete |
|
||||
| SEED-01 | Phase 25 | Complete |
|
||||
| SEED-02 | Phase 25 | Complete |
|
||||
| SEED-03 | Phase 25 | Complete |
|
||||
| DISC-01 | Phase 26 | Complete |
|
||||
| DISC-02 | Phase 26 | Complete |
|
||||
| DISC-03 | Phase 26 | Complete |
|
||||
| DISC-04 | Phase 26 | Complete |
|
||||
| DISC-05 | Phase 26 | Complete |
|
||||
| INFR-02 | Phase 26 | Complete |
|
||||
|
||||
**Coverage:** 20/20 v2.1 requirements complete.
|
||||
111
.planning/milestones/v2.3-ROADMAP.md
Normal file
111
.planning/milestones/v2.3-ROADMAP.md
Normal file
@@ -0,0 +1,111 @@
|
||||
# Milestone v2.3: Global & Social Ready
|
||||
|
||||
**Status:** ✅ SHIPPED 2026-04-19
|
||||
**Phases:** 32-34
|
||||
**Total Plans:** 18
|
||||
|
||||
## Overview
|
||||
|
||||
Made GearBox work for a global audience. Setup sharing with fine-grained visibility control, a full multi-currency pricing system with ECB exchange rates and community price aggregation, and an i18n foundation with English + German translations — all delivered in 6 days across 3 phases and 18 plans.
|
||||
|
||||
## Phases
|
||||
|
||||
### Phase 32: Setup Sharing System
|
||||
|
||||
**Goal**: Setup owners can toggle visibility between private, link-shared, and public, with schema designed for future likes, friends, and collaborative editing
|
||||
**Depends on**: Phase 28 (profiles working)
|
||||
**Plans**: 4 plans
|
||||
|
||||
Plans:
|
||||
- [x] 32-01-PLAN.md — Schema migration (isPublic to visibility) + shares table + full-stack update
|
||||
- [x] 32-02-PLAN.md — Share link service, API routes, and short URL redirect
|
||||
- [x] 32-03-PLAN.md — Share modal UI component with visibility picker and link management
|
||||
- [x] 32-04-PLAN.md — Shared setup viewer with token detection and read-only mode
|
||||
|
||||
**Details:**
|
||||
- `visibility` text column (private/link/public) replaces `isPublic` boolean on setups table
|
||||
- `shares` table with token, permission, expiresAt, userId, revokedAt — schema future-proofed for person-specific shares and write permissions
|
||||
- Share tokens use randomBytes(16).toString("base64url") — 128-bit entropy, URL-safe
|
||||
- Visibility→private deactivates share links; switching back reactivates non-expired ones
|
||||
- `/s/:token` short URL redirects to `/setups/:id?share=token`; `/api/shared/:token` returns setup data without auth
|
||||
- ShareModal replaces old globe toggle — Google Docs-style with visibility picker + link management
|
||||
- Three-way data source in setup detail page: share token > authenticated owner > public viewer
|
||||
|
||||
### Phase 33: Currency System
|
||||
|
||||
**Goal**: Users can select their preferred currency (USD/EUR/GBP) and all prices display accordingly — full market-aware pricing system with community price data
|
||||
**Depends on**: Phase 32
|
||||
**Plans**: 6 plans
|
||||
|
||||
Plans:
|
||||
- [x] 33-01-PLAN.md — Schema (market_prices, community_prices tables) + currency conversion service
|
||||
- [x] 33-02-PLAN.md — Database migration generation and push
|
||||
- [x] 33-03-PLAN.md — Market prices API, exchange rates endpoint, item/candidate currency context
|
||||
- [x] 33-04-PLAN.md — Community price service (ownership validation, median aggregation) + setup totals
|
||||
- [x] 33-05-PLAN.md — Formatter evolution, market/currency selector, auto-suggestion, conversion toggle
|
||||
- [x] 33-06-PLAN.md — Catalog detail market prices, comparison table normalization, MCP tool updates
|
||||
|
||||
**Details:**
|
||||
- `market_prices` and `community_prices` tables with unique constraints
|
||||
- `priceCurrency` column on items; `foundPriceCents/Currency/Date` on thread_candidates
|
||||
- Exchange rates fetched daily from ECB via frankfurter.app with 24h module-level cache
|
||||
- Community price aggregation: PERCENTILE_CONT(0.5) median with 3-report minimum, ownership-validated submissions
|
||||
- Converted prices labeled with ~ prefix and dual display format
|
||||
- `CurrencyContext` interface (currency, market, showConversions) from `useCurrency()`
|
||||
- Market-aware MSRP section on catalog detail page with collapsible "Other Markets"
|
||||
|
||||
### Phase 34: i18n Foundation
|
||||
|
||||
**Goal**: Translation framework in place with string extraction, locale-aware formatting, and at least English + one additional language
|
||||
**Depends on**: Phase 33
|
||||
**Plans**: 8 plans
|
||||
|
||||
Plans:
|
||||
- [x] 34-01-PLAN.md — i18next + react-i18next setup, English namespace JSON files
|
||||
- [x] 34-02-PLAN.md — German translations for all 6 namespaces
|
||||
- [x] 34-03-PLAN.md — Component wiring (collection, threads, setups namespaces)
|
||||
- [x] 34-04-PLAN.md — Settings and onboarding namespace wiring
|
||||
- [x] 34-05-PLAN.md — Language picker component in settings
|
||||
- [x] 34-06-PLAN.md — Locale-aware formatting (dates, numbers)
|
||||
- [x] 34-07-PLAN.md — catalog namespace for global-items/discover page
|
||||
- [x] 34-08-PLAN.md — Final wiring and verification
|
||||
|
||||
**Details:**
|
||||
- react-i18next with i18next-browser-languagedetector
|
||||
- 6 namespaces: common, collection, threads, setups, onboarding, settings (+ catalog added in 34-07)
|
||||
- Detection order: localStorage (key: gearbox-language) then navigator.language
|
||||
- Static lookup tables (icons, CSS) kept at module level; only label strings moved inside components for t() access
|
||||
- English + German locales, language picker in settings
|
||||
|
||||
---
|
||||
|
||||
## Milestone Summary
|
||||
|
||||
**Key Decisions:**
|
||||
- isPublic boolean replaced with visibility text column (private/link/public) — RESOLVED
|
||||
- shares table future-proofed for person-specific shares and write permissions — RESOLVED
|
||||
- Share tokens: randomBytes(16).toString("base64url") — 128-bit entropy, URL-safe — RESOLVED
|
||||
- Visibility→private deactivates share links; switching back reactivates non-expired ones — RESOLVED
|
||||
- EUR as default price currency matching existing data assumption — RESOLVED
|
||||
- Module-level caching for exchange rates (simple, effective for single-process) — RESOLVED
|
||||
- Community price aggregation uses PERCENTILE_CONT(0.5) with 3-report minimum — RESOLVED
|
||||
- Detection order for locale: localStorage first, then navigator.language — RESOLVED
|
||||
- defaultNS is common; escapeValue: false (React handles XSS) — RESOLVED
|
||||
|
||||
**Issues Resolved:**
|
||||
- isPublic boolean → visibility text migration handled with data migration SQL
|
||||
- Dynamic import in setup.service.ts to avoid circular dependency with share.service.ts
|
||||
|
||||
**Issues Deferred:**
|
||||
- ComparisonTable currency normalization (hooks available, deferred pending real multi-currency test data)
|
||||
- MCP tool currency updates (existing priceCents responses work with currency context client-side)
|
||||
- E2E tests rewrite for OIDC auth (backlog 999.1)
|
||||
|
||||
**Technical Debt Incurred:**
|
||||
- 6 pending todos deferred to v2.4 (cursor pointers, image loading, auth redirect, add-candidate modal)
|
||||
|
||||
**Known deferred items at close:** 6 (see STATE.md Deferred Items)
|
||||
|
||||
---
|
||||
|
||||
_For current project status, see .planning/ROADMAP.md_
|
||||
Reference in New Issue
Block a user