fix(admin): move detail routes to directory structure to fix rendering
Admin item/tag edit pages weren't rendering because TanStack Router treated them as children of the list route (which had no Outlet). Moving to directory-based routing (items/index.tsx + items/$itemId.tsx) makes them siblings that render directly in the admin layout. Also adds UAT results for phases 35-38 and backlog item 999.12 (Admin UX Polish). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -401,3 +401,11 @@ Plans:
|
||||
|
||||
Plans:
|
||||
- [ ] TBD (promote with /gsd:review-backlog when ready)
|
||||
|
||||
### Phase 999.12: Admin UX Polish (BACKLOG)
|
||||
**Goal**: Overhaul admin panel UX with TanStack Table (sortable/groupable columns) and cmdk (GitLab-style composable filter bar with field→operator→value token input). Hide FAB on /admin/* pages. Replace tag inline form with popup modal. Show tags expanded on item rows (collapse to +N when tight). Group items by brand. Prominent search bar on both admin list pages.
|
||||
**Requirements**: TBD
|
||||
**Plans**: TBD
|
||||
|
||||
Plans:
|
||||
- [ ] TBD (promote with /gsd:review-backlog when ready)
|
||||
|
||||
74
.planning/phases/35-bug-fixes/35-UAT.md
Normal file
74
.planning/phases/35-bug-fixes/35-UAT.md
Normal file
@@ -0,0 +1,74 @@
|
||||
---
|
||||
status: complete
|
||||
phase: 35-bug-fixes
|
||||
source: [35-01-SUMMARY.md, 35-02-SUMMARY.md, 35-03-SUMMARY.md]
|
||||
started: 2026-04-20T00:00:00.000Z
|
||||
updated: 2026-04-20T00:01:00.000Z
|
||||
---
|
||||
|
||||
## Current Test
|
||||
|
||||
[testing complete]
|
||||
|
||||
## Tests
|
||||
|
||||
### 1. Thread Add Candidate Opens Catalog Search
|
||||
expected: On a thread detail page, clicking "Add Candidate" opens the CatalogSearchOverlay (same overlay used elsewhere), not a local modal form.
|
||||
result: pass
|
||||
|
||||
### 2. Image Skeleton and Fade-In on Cards
|
||||
expected: On collection, thread candidates, or catalog pages, images show a gray pulsing skeleton placeholder while loading. Once the image loads, it fades in smoothly (opacity transition). Cards without images show the category icon placeholder as before.
|
||||
result: pass
|
||||
|
||||
### 3. Login Page Redirects to OIDC
|
||||
expected: Navigating to /login immediately redirects to the Logto OIDC provider. No sign-in card or button is shown — at most a brief "Signing in..." text before the redirect.
|
||||
result: pass
|
||||
|
||||
### 4. Cursor Pointer on Interactive Elements
|
||||
expected: Hovering over clickable ItemCards (in collection), FabMenu buttons, and BottomTabBar tab buttons shows a pointer cursor. Non-navigable ItemCards (e.g., in setup view) keep the default cursor.
|
||||
result: issue
|
||||
reported: "cursor-pointer missing on add-to-collection and thread buttons on item details page, and the small instant-add button in catalog search"
|
||||
severity: minor
|
||||
|
||||
## Summary
|
||||
|
||||
total: 4
|
||||
passed: 3
|
||||
issues: 1
|
||||
pending: 0
|
||||
skipped: 0
|
||||
blocked: 0
|
||||
|
||||
## Gaps
|
||||
|
||||
- truth: "All interactive elements show cursor-pointer on hover"
|
||||
status: failed
|
||||
reason: "User reported: cursor-pointer missing on add-to-collection and thread buttons on item details page, and the small instant-add button in catalog search"
|
||||
severity: minor
|
||||
test: 4
|
||||
artifacts: []
|
||||
missing: []
|
||||
|
||||
- truth: "CatalogSearchOverlay z-index should not cover the UserMenu dropdown"
|
||||
status: failed
|
||||
reason: "User reported: the add candidate global search lays above the context menu which opens when clicking the avatar"
|
||||
severity: minor
|
||||
test: bonus
|
||||
artifacts: []
|
||||
missing: []
|
||||
|
||||
- truth: "Catalog search instant-add button persists after inspecting an item and returning"
|
||||
status: failed
|
||||
reason: "User reported: when adding an item, you click on one to inspect it, then go back to the search, the small instant-add button isn't there"
|
||||
severity: major
|
||||
test: bonus
|
||||
artifacts: []
|
||||
missing: []
|
||||
|
||||
- truth: "Thread creation dialog uses the CategoryPicker component"
|
||||
status: failed
|
||||
reason: "User reported: new thread creation dialogue doesn't use the category selector component but instead uses its own"
|
||||
severity: minor
|
||||
test: bonus
|
||||
artifacts: []
|
||||
missing: []
|
||||
42
.planning/phases/36-admin-role-panel-foundation/36-UAT.md
Normal file
42
.planning/phases/36-admin-role-panel-foundation/36-UAT.md
Normal file
@@ -0,0 +1,42 @@
|
||||
---
|
||||
status: complete
|
||||
phase: 36-admin-role-panel-foundation
|
||||
source: [36-01-SUMMARY.md, 36-02-SUMMARY.md]
|
||||
started: 2026-04-20T00:02:00.000Z
|
||||
updated: 2026-04-20T00:03:00.000Z
|
||||
---
|
||||
|
||||
## Current Test
|
||||
|
||||
[testing complete]
|
||||
|
||||
## Tests
|
||||
|
||||
### 1. Admin Link in UserMenu
|
||||
expected: As an admin user, clicking the avatar/user menu shows an "Admin" link at the top of the dropdown (with a shield icon). Non-admin users do not see this link.
|
||||
result: pass
|
||||
|
||||
### 2. Admin Panel Access and Guard
|
||||
expected: Navigating to /admin as an admin user shows the admin panel with a sidebar. Non-admin users are redirected to /.
|
||||
result: pass
|
||||
|
||||
### 3. Admin Sidebar Navigation
|
||||
expected: The admin sidebar shows "Items" and "Tags" links. Both are clickable (not disabled/greyed out).
|
||||
result: pass
|
||||
|
||||
### 4. Admin API Protection
|
||||
expected: Hitting /api/admin/ as a non-admin user returns 403 Forbidden. Unauthenticated requests return 401.
|
||||
result: pass
|
||||
|
||||
## Summary
|
||||
|
||||
total: 4
|
||||
passed: 4
|
||||
issues: 0
|
||||
pending: 0
|
||||
skipped: 0
|
||||
blocked: 0
|
||||
|
||||
## Gaps
|
||||
|
||||
[none]
|
||||
60
.planning/phases/37-admin-global-item-management/37-UAT.md
Normal file
60
.planning/phases/37-admin-global-item-management/37-UAT.md
Normal file
@@ -0,0 +1,60 @@
|
||||
---
|
||||
status: complete
|
||||
phase: 37-admin-global-item-management
|
||||
source: [37-01-SUMMARY.md, 37-02-SUMMARY.md]
|
||||
started: 2026-04-20T00:04:00.000Z
|
||||
updated: 2026-04-20T00:05:00.000Z
|
||||
---
|
||||
|
||||
## Current Test
|
||||
|
||||
[testing complete]
|
||||
|
||||
## Tests
|
||||
|
||||
### 1. Admin Items List Page
|
||||
expected: Navigating to /admin/items shows a data table of all global catalog items with search input, tag filter chips, skeleton loading state, and infinite scroll when there are many items.
|
||||
result: pass
|
||||
|
||||
### 2. Admin Items Search and Filter
|
||||
expected: Typing in the search input filters items by name. Clicking tag filter chips narrows results to items with that tag. Both work together.
|
||||
result: pass
|
||||
|
||||
### 3. Admin Item Edit Page
|
||||
expected: Clicking an item in the list navigates to its edit page showing all fields (name, manufacturer, weight, price, etc.), a manufacturer dropdown, and a TagInput chip component for managing tags.
|
||||
result: issue
|
||||
reported: "nothing happening when clicking an item in the list"
|
||||
severity: major
|
||||
|
||||
### 4. Admin Item Delete with Confirmation
|
||||
expected: On the edit page, clicking "Delete" shows a confirmation dialog that mentions how many users have this item in their collection (ownerCount). Confirming deletes the item and returns to the list.
|
||||
result: issue
|
||||
reported: "navigating directly to /admin/items/1 still shows the catalogue list, edit page doesn't render"
|
||||
severity: major
|
||||
|
||||
## Summary
|
||||
|
||||
total: 4
|
||||
passed: 2
|
||||
issues: 2
|
||||
pending: 0
|
||||
skipped: 0
|
||||
blocked: 0
|
||||
|
||||
## Gaps
|
||||
|
||||
- truth: "Clicking an item in the admin items list navigates to its edit page"
|
||||
status: failed
|
||||
reason: "User reported: nothing happening when clicking an item in the list"
|
||||
severity: major
|
||||
test: 3
|
||||
artifacts: []
|
||||
missing: []
|
||||
|
||||
- truth: "Admin item edit page renders at /admin/items/$itemId"
|
||||
status: failed
|
||||
reason: "User reported: navigating directly to /admin/items/1 still shows the catalogue list, edit page doesn't render"
|
||||
severity: major
|
||||
test: 4
|
||||
artifacts: []
|
||||
missing: []
|
||||
70
.planning/phases/38-admin-tag-management/38-UAT.md
Normal file
70
.planning/phases/38-admin-tag-management/38-UAT.md
Normal file
@@ -0,0 +1,70 @@
|
||||
---
|
||||
status: complete
|
||||
phase: 38-admin-tag-management
|
||||
source: [38-01-SUMMARY.md, 38-02-SUMMARY.md]
|
||||
started: 2026-04-20T00:06:00.000Z
|
||||
updated: 2026-04-20T00:07:00.000Z
|
||||
---
|
||||
|
||||
## Current Test
|
||||
|
||||
[testing complete]
|
||||
|
||||
## Tests
|
||||
|
||||
### 1. Tag List with Tree View
|
||||
expected: Navigating to /admin/tags shows a collapsible tree view of all tags. Tags with children have a chevron to expand/collapse. Indentation shows hierarchy. Search input filters the tree in place.
|
||||
result: pass
|
||||
|
||||
### 2. Quick-Add Tag
|
||||
expected: An inline form at the top lets you type a tag name, optionally pick a parent from a dropdown (default: "No parent (top-level)"), and click "Add Tag" to create it. The new tag appears in the tree immediately.
|
||||
result: issue
|
||||
reported: "creating a duplicate tag shows unknown error because backend returns 500 instead of proper error. also the inline form is ugly and hard to navigate"
|
||||
severity: minor
|
||||
|
||||
### 3. Tag Edit Page — Rename and Reparent
|
||||
expected: Clicking a tag navigates to /admin/tags/$tagId showing a name field and a parent picker dropdown. The parent picker excludes the current tag and all its descendants (cycle prevention). Saving updates the tag.
|
||||
result: issue
|
||||
reported: "navigates to correct URL (e.g. /admin/tags/4) but still shows the tag list view, edit page doesn't render"
|
||||
severity: major
|
||||
|
||||
### 4. Tag Delete with Impact Confirmation
|
||||
expected: On the tag edit page, clicking "Delete Tag" shows a confirmation dialog mentioning how many items use this tag and how many child tags it has. Confirming deletes the tag and returns to the list.
|
||||
result: blocked
|
||||
blocked_by: other
|
||||
reason: "edit page doesn't render due to same routing issue as Phase 37"
|
||||
|
||||
## Summary
|
||||
|
||||
total: 4
|
||||
passed: 1
|
||||
issues: 2
|
||||
pending: 0
|
||||
skipped: 0
|
||||
blocked: 1
|
||||
|
||||
## Gaps
|
||||
|
||||
- truth: "Duplicate tag name returns a user-friendly error message"
|
||||
status: failed
|
||||
reason: "User reported: backend returns 500, UI shows unknown error"
|
||||
severity: minor
|
||||
test: 2
|
||||
artifacts: []
|
||||
missing: []
|
||||
|
||||
- truth: "Inline tag creation form is usable and visually consistent"
|
||||
status: failed
|
||||
reason: "User reported: the inline form is ugly and hard to navigate"
|
||||
severity: cosmetic
|
||||
test: 2
|
||||
artifacts: []
|
||||
missing: []
|
||||
|
||||
- truth: "Admin tag edit page renders at /admin/tags/$tagId"
|
||||
status: failed
|
||||
reason: "User reported: navigates to correct URL but still shows the tag list view, edit page doesn't render"
|
||||
severity: major
|
||||
test: 3
|
||||
artifacts: []
|
||||
missing: []
|
||||
0
.planning/phases/999.12-admin-ux-polish/.gitkeep
Normal file
0
.planning/phases/999.12-admin-ux-polish/.gitkeep
Normal file
Reference in New Issue
Block a user