feat(09-01): add classification column to setupItems with service layer and tests

- Add classification text column (default 'base') to setupItems schema
- Add classificationSchema and updateClassificationSchema Zod validators
- Add UpdateClassification type inferred from Zod schema
- Implement updateItemClassification service function
- Modify getSetupWithItems to return classification field
- Modify syncSetupItems to preserve classifications across re-sync
- Add tests for classification CRUD, preservation, and cross-setup independence
- Generate and apply Drizzle migration

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-03-16 15:11:18 +01:00
parent 0e23996986
commit 4491e4c6f1
9 changed files with 642 additions and 3 deletions

View File

@@ -7,6 +7,7 @@ import {
getSetupWithItems,
removeSetupItem,
syncSetupItems,
updateItemClassification,
updateSetup,
} from "../../src/server/services/setup.service.ts";
import { createTestDb } from "../helpers/db.ts";
@@ -172,6 +173,106 @@ describe("Setup Service", () => {
});
});
describe("getSetupWithItems - classification", () => {
it("returns classification field defaulting to 'base' for each item", () => {
const setup = createSetup(db, { name: "Day Hike" });
const item = createItem(db, {
name: "Water Bottle",
categoryId: 1,
weightGrams: 200,
priceCents: 2500,
});
syncSetupItems(db, setup.id, [item.id]);
const result = getSetupWithItems(db, setup.id);
expect(result?.items).toHaveLength(1);
expect(result?.items[0].classification).toBe("base");
});
});
describe("syncSetupItems - classification preservation", () => {
it("preserves existing classifications when re-syncing items", () => {
const setup = createSetup(db, { name: "Kit" });
const item1 = createItem(db, { name: "Tent", categoryId: 1 });
const item2 = createItem(db, { name: "Jacket", categoryId: 1 });
const item3 = createItem(db, { name: "Stove", categoryId: 1 });
// Initial sync
syncSetupItems(db, setup.id, [item1.id, item2.id]);
// Change classifications
updateItemClassification(db, setup.id, item1.id, "worn");
updateItemClassification(db, setup.id, item2.id, "consumable");
// Re-sync with item2 kept and item3 added (item1 removed)
syncSetupItems(db, setup.id, [item2.id, item3.id]);
const result = getSetupWithItems(db, setup.id);
expect(result?.items).toHaveLength(2);
const item2Result = result?.items.find((i: any) => i.name === "Jacket");
const item3Result = result?.items.find((i: any) => i.name === "Stove");
expect(item2Result?.classification).toBe("consumable");
expect(item3Result?.classification).toBe("base");
});
it("assigns 'base' to newly added items with no prior classification", () => {
const setup = createSetup(db, { name: "Kit" });
const item1 = createItem(db, { name: "Item 1", categoryId: 1 });
syncSetupItems(db, setup.id, [item1.id]);
const result = getSetupWithItems(db, setup.id);
expect(result?.items[0].classification).toBe("base");
});
});
describe("updateItemClassification", () => {
it("sets classification for a specific item in a specific setup", () => {
const setup = createSetup(db, { name: "Kit" });
const item = createItem(db, { name: "Tent", categoryId: 1 });
syncSetupItems(db, setup.id, [item.id]);
updateItemClassification(db, setup.id, item.id, "worn");
const result = getSetupWithItems(db, setup.id);
expect(result?.items[0].classification).toBe("worn");
});
it("changes item from default 'base' to 'worn'", () => {
const setup = createSetup(db, { name: "Kit" });
const item = createItem(db, { name: "Jacket", categoryId: 1 });
syncSetupItems(db, setup.id, [item.id]);
// Verify default
let result = getSetupWithItems(db, setup.id);
expect(result?.items[0].classification).toBe("base");
// Update
updateItemClassification(db, setup.id, item.id, "worn");
result = getSetupWithItems(db, setup.id);
expect(result?.items[0].classification).toBe("worn");
});
it("same item in two different setups can have different classifications", () => {
const setup1 = createSetup(db, { name: "Hiking" });
const setup2 = createSetup(db, { name: "Biking" });
const item = createItem(db, { name: "Jacket", categoryId: 1 });
syncSetupItems(db, setup1.id, [item.id]);
syncSetupItems(db, setup2.id, [item.id]);
updateItemClassification(db, setup1.id, item.id, "worn");
updateItemClassification(db, setup2.id, item.id, "base");
const result1 = getSetupWithItems(db, setup1.id);
const result2 = getSetupWithItems(db, setup2.id);
expect(result1?.items[0].classification).toBe("worn");
expect(result2?.items[0].classification).toBe("base");
});
});
describe("cascade behavior", () => {
it("deleting a collection item removes it from all setups", () => {
const setup = createSetup(db, { name: "Kit" });