makiolaj/GearBox
1
0
Fork 0
Code Issues 8 Pull Requests Actions Packages Projects Releases 10 Wiki Activity

feat(14-06): convert all 9 service test files to async PGlite

Browse Source 
- All beforeEach now use async/await createTestDb()
- All service calls in tests now awaited
- All direct DB calls (.run()/.all()) replaced with await
- All test callbacks made async
- Fixed PostgreSQL GROUP BY strictness in totals.service.ts (categories.name and categories.icon added to groupBy)
- db type changed to 'any' to accommodate PGlite type differences

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jean-Luc Makiola
2026-04-04 13:11:52 +02:00
parent cb2a192cb5
commit 458b33f1c7
9 changed files with 406 additions and 408 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
tests/services/category.service.test.ts
View File

@@ -11,15 +11,15 @@ import { createItem } from "../../src/server/services/item.service.ts";
import { createTestDb } from "../helpers/db.ts";
describe("Category Service", () => {
let db: ReturnType<typeof createTestDb>;
let db: any;
beforeEach(() => {
db = createTestDb();
beforeEach(async () => {
db = await createTestDb();
});
describe("createCategory", () => {
it("creates with name and icon", () => {
const cat = createCategory(db, { name: "Shelter", icon: "tent" });
it("creates with name and icon", async () => {
const cat = await createCategory(db, { name: "Shelter", icon: "tent" });
expect(cat).toBeDefined();
expect(cat?.id).toBeGreaterThan(0);
@@ -27,8 +27,8 @@ describe("Category Service", () => {
expect(cat?.icon).toBe("tent");
});
it("uses default icon if not provided", () => {
const cat = createCategory(db, { name: "Cooking" });
it("uses default icon if not provided", async () => {
const cat = await createCategory(db, { name: "Cooking" });
expect(cat).toBeDefined();
expect(cat?.icon).toBe("package");
@@ -36,61 +36,60 @@ describe("Category Service", () => {
});
describe("getAllCategories", () => {
it("returns all categories", () => {
createCategory(db, { name: "Shelter", icon: "tent" });
createCategory(db, { name: "Cooking", icon: "cooking-pot" });
it("returns all categories", async () => {
await createCategory(db, { name: "Shelter", icon: "tent" });
await createCategory(db, { name: "Cooking", icon: "cooking-pot" });
const all = getAllCategories(db);
const all = await getAllCategories(db);
// Includes seeded Uncategorized + 2 new
expect(all.length).toBeGreaterThanOrEqual(3);
});
});
describe("updateCategory", () => {
it("renames category", () => {
const cat = createCategory(db, { name: "Shelter", icon: "tent" });
const updated = updateCategory(db, cat?.id, { name: "Sleep System" });
it("renames category", async () => {
const cat = await createCategory(db, { name: "Shelter", icon: "tent" });
const updated = await updateCategory(db, cat?.id, { name: "Sleep System" });
expect(updated).toBeDefined();
expect(updated?.name).toBe("Sleep System");
expect(updated?.icon).toBe("tent");
});
it("changes icon", () => {
const cat = createCategory(db, { name: "Shelter", icon: "tent" });
const updated = updateCategory(db, cat?.id, { icon: "home" });
it("changes icon", async () => {
const cat = await createCategory(db, { name: "Shelter", icon: "tent" });
const updated = await updateCategory(db, cat?.id, { icon: "home" });
expect(updated).toBeDefined();
expect(updated?.icon).toBe("home");
});
it("returns null for non-existent id", () => {
const result = updateCategory(db, 9999, { name: "Ghost" });
it("returns null for non-existent id", async () => {
const result = await updateCategory(db, 9999, { name: "Ghost" });
expect(result).toBeNull();
});
});
describe("deleteCategory", () => {
it("reassigns items to Uncategorized (id=1) then deletes", () => {
const shelter = createCategory(db, { name: "Shelter", icon: "tent" });
createItem(db, { name: "Tent", categoryId: shelter?.id });
createItem(db, { name: "Tarp", categoryId: shelter?.id });
it("reassigns items to Uncategorized (id=1) then deletes", async () => {
const shelter = await createCategory(db, { name: "Shelter", icon: "tent" });
await createItem(db, { name: "Tent", categoryId: shelter?.id });
await createItem(db, { name: "Tarp", categoryId: shelter?.id });
const result = deleteCategory(db, shelter?.id);
const result = await deleteCategory(db, shelter?.id);
expect(result.success).toBe(true);
// Items should now be in Uncategorized (id=1)
const reassigned = db
const reassigned = await db
.select()
.from(items)
.where(eq(items.categoryId, 1))
.all();
.where(eq(items.categoryId, 1));
expect(reassigned).toHaveLength(2);
expect(reassigned.map((i) => i.name).sort()).toEqual(["Tarp", "Tent"]);
expect(reassigned.map((i: any) => i.name).sort()).toEqual(["Tarp", "Tent"]);
});
it("cannot delete Uncategorized (id=1)", () => {
const result = deleteCategory(db, 1);
it("cannot delete Uncategorized (id=1)", async () => {
const result = await deleteCategory(db, 1);
expect(result.success).toBe(false);
expect(result.error).toBeDefined();
});