makiolaj/GearBox
1
0
Fork 0
Code Issues 8 Pull Requests Actions Packages Projects Releases 10 Wiki Activity

feat(14-06): convert all 9 service test files to async PGlite

Browse Source 
- All beforeEach now use async/await createTestDb()
- All service calls in tests now awaited
- All direct DB calls (.run()/.all()) replaced with await
- All test callbacks made async
- Fixed PostgreSQL GROUP BY strictness in totals.service.ts (categories.name and categories.icon added to groupBy)
- db type changed to 'any' to accommodate PGlite type differences

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jean-Luc Makiola
2026-04-04 13:11:52 +02:00
parent cb2a192cb5
commit 458b33f1c7
9 changed files with 406 additions and 408 deletions
Download Patch File Download Diff File Expand all files Collapse all files

68
tests/services/item.service.test.ts
View File

@@ -10,15 +10,15 @@ import {
import { createTestDb } from "../helpers/db.ts";
describe("Item Service", () => {
let db: ReturnType<typeof createTestDb>;
let db: any;
beforeEach(() => {
db = createTestDb();
beforeEach(async () => {
db = await createTestDb();
});
describe("createItem", () => {
it("creates item with all fields, returns item with id and timestamps", () => {
const item = createItem(db, {
it("creates item with all fields, returns item with id and timestamps", async () => {
const item = await createItem(db, {
name: "Tent",
weightGrams: 1200,
priceCents: 35000,
@@ -39,8 +39,8 @@ describe("Item Service", () => {
expect(item?.updatedAt).toBeDefined();
});
it("only name and categoryId are required, other fields optional", () => {
const item = createItem(db, { name: "Spork", categoryId: 1 });
it("only name and categoryId are required, other fields optional", async () => {
const item = await createItem(db, { name: "Spork", categoryId: 1 });
expect(item).toBeDefined();
expect(item?.name).toBe("Spork");
@@ -52,11 +52,11 @@ describe("Item Service", () => {
});
describe("getAllItems", () => {
it("returns all items with category info joined", () => {
createItem(db, { name: "Tent", categoryId: 1 });
createItem(db, { name: "Sleeping Bag", categoryId: 1 });
it("returns all items with category info joined", async () => {
await createItem(db, { name: "Tent", categoryId: 1 });
await createItem(db, { name: "Sleeping Bag", categoryId: 1 });
const all = getAllItems(db);
const all = await getAllItems(db);
expect(all).toHaveLength(2);
expect(all[0].categoryName).toBe("Uncategorized");
expect(all[0].categoryIcon).toBeDefined();
@@ -64,26 +64,26 @@ describe("Item Service", () => {
});
describe("getItemById", () => {
it("returns single item or null", () => {
const created = createItem(db, { name: "Tent", categoryId: 1 });
const found = getItemById(db, created?.id);
it("returns single item or null", async () => {
const created = await createItem(db, { name: "Tent", categoryId: 1 });
const found = await getItemById(db, created?.id);
expect(found).toBeDefined();
expect(found?.name).toBe("Tent");
const notFound = getItemById(db, 9999);
const notFound = await getItemById(db, 9999);
expect(notFound).toBeNull();
});
});
describe("updateItem", () => {
it("updates specified fields, sets updatedAt", () => {
const created = createItem(db, {
it("updates specified fields, sets updatedAt", async () => {
const created = await createItem(db, {
name: "Tent",
weightGrams: 1200,
categoryId: 1,
});
const updated = updateItem(db, created?.id, {
const updated = await updateItem(db, created?.id, {
name: "Big Agnes Tent",
weightGrams: 1100,
});
@@ -93,15 +93,15 @@ describe("Item Service", () => {
expect(updated?.weightGrams).toBe(1100);
});
it("returns null for non-existent id", () => {
const result = updateItem(db, 9999, { name: "Ghost" });
it("returns null for non-existent id", async () => {
const result = await updateItem(db, 9999, { name: "Ghost" });
expect(result).toBeNull();
});
});
describe("duplicateItem", () => {
it("creates a copy with '(copy)' suffix in name", () => {
const original = createItem(db, {
it("creates a copy with '(copy)' suffix in name", async () => {
const original = await createItem(db, {
name: "Tent",
weightGrams: 1200,
priceCents: 35000,
@@ -110,7 +110,7 @@ describe("Item Service", () => {
productUrl: "https://example.com/tent",
});
const copy = duplicateItem(db, original?.id);
const copy = await duplicateItem(db, original?.id);
expect(copy).toBeDefined();
expect(copy?.name).toBe("Tent (copy)");
@@ -121,39 +121,39 @@ describe("Item Service", () => {
expect(copy?.productUrl).toBe("https://example.com/tent");
});
it("copy has a different ID from the original", () => {
const original = createItem(db, { name: "Helmet", categoryId: 1 });
const copy = duplicateItem(db, original?.id);
it("copy has a different ID from the original", async () => {
const original = await createItem(db, { name: "Helmet", categoryId: 1 });
const copy = await duplicateItem(db, original?.id);
expect(copy?.id).not.toBe(original?.id);
});
it("returns null for non-existent item", () => {
const result = duplicateItem(db, 9999);
it("returns null for non-existent item", async () => {
const result = await duplicateItem(db, 9999);
expect(result).toBeNull();
});
});
describe("deleteItem", () => {
it("removes item from DB, returns deleted item", () => {
const created = createItem(db, {
it("removes item from DB, returns deleted item", async () => {
const created = await createItem(db, {
name: "Tent",
categoryId: 1,
imageFilename: "tent.jpg",
});
const deleted = deleteItem(db, created?.id);
const deleted = await deleteItem(db, created?.id);
expect(deleted).toBeDefined();
expect(deleted?.name).toBe("Tent");
expect(deleted?.imageFilename).toBe("tent.jpg");
// Verify it's gone
const found = getItemById(db, created?.id);
const found = await getItemById(db, created?.id);
expect(found).toBeNull();
});
it("returns null for non-existent id", () => {
const result = deleteItem(db, 9999);
it("returns null for non-existent id", async () => {
const result = await deleteItem(db, 9999);
expect(result).toBeNull();
});
});