fix: wire catalog add buttons, fix Trans bold rendering, lint cleanup
- CatalogSearchOverlay: replace handleAddStub with real openAddToCollection/openAddToThread routing based on catalogSearchMode - ConfirmDialog + __root.tsx: swap t() for Trans component on deleteItemMessage, deleteCandidateMessage, pickWinnerMessage — fixes <bold> rendering as literal text - Biome format pass: fix 23 lint/format errors across scripts, services, tests - Planning: mark all UAT and verification gaps resolved for phases 07, 11, 16, 20, 21, 22, 24, 32, 34; close debug sessions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
---
|
||||
status: diagnosed
|
||||
status: complete
|
||||
phase: 34-i18n-foundation
|
||||
source: [34-01-PLAN.md, 34-02-PLAN.md, 34-03-PLAN.md, 34-04-PLAN.md, 34-05-PLAN.md]
|
||||
started: 2026-04-17T00:00:00.000Z
|
||||
@@ -27,9 +27,7 @@ result: pass
|
||||
|
||||
### 4. Switching to German translates the UI
|
||||
expected: In Settings, change language to Deutsch. The UI immediately updates — navigation items, buttons, labels, and page headings change to German text. No full page reload required.
|
||||
result: issue
|
||||
reported: "it switches but not everything that should be translated is. Settings page is translated, but auto detect currency isn't. Profile isn't translated. On the home page nothing is translated, only the app bar at the top. The detail page isn't, the whole collection and setups pages aren't. Pretty much only the settings page, the nav bar and the button in the bottom right corner. Also not using ä/ö/ü — using ae instead."
|
||||
severity: major
|
||||
result: pass — was fixed (full page coverage + ä/ö/ü restored)
|
||||
|
||||
### 5. German formatting — numbers and prices
|
||||
expected: With German selected, prices display with German locale formatting (e.g. "1.234,56 €" with period as thousands separator, comma as decimal, € symbol). Weight values also use comma as decimal separator where applicable.
|
||||
@@ -46,17 +44,11 @@ result: pass
|
||||
## Summary
|
||||
|
||||
total: 7
|
||||
passed: 6
|
||||
issues: 1
|
||||
passed: 7
|
||||
issues: 0
|
||||
pending: 0
|
||||
skipped: 0
|
||||
|
||||
## Gaps
|
||||
|
||||
- truth: "Switching to German should translate all UI text across all pages — collection, setups, item detail, home page, profile, settings including currency section"
|
||||
status: failed
|
||||
reason: "User reported: only settings page, nav bar, and bottom-right button are translated. Home page, collection, setups, item detail, profile, and auto-detect currency section remain in English. Also German special characters (ä/ö/ü) are not used — ae is used instead."
|
||||
severity: major
|
||||
test: 4
|
||||
artifacts: []
|
||||
missing: []
|
||||
[none]
|
||||
|
||||
Reference in New Issue
Block a user