feat(06-01): migrate categories from emoji to Lucide icon field
- Rename emoji column to icon in schema, Zod schemas, and all services - Add Drizzle migration with emoji-to-icon data conversion - Update test helper, seed, and all test files for icon field - All 87 tests pass with new icon-based schema Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -11,7 +11,7 @@ export function createTestDb() {
|
||||
CREATE TABLE categories (
|
||||
id INTEGER PRIMARY KEY AUTOINCREMENT,
|
||||
name TEXT NOT NULL UNIQUE,
|
||||
emoji TEXT NOT NULL DEFAULT '📦',
|
||||
icon TEXT NOT NULL DEFAULT 'package',
|
||||
created_at INTEGER NOT NULL DEFAULT (unixepoch())
|
||||
)
|
||||
`);
|
||||
@@ -87,7 +87,7 @@ export function createTestDb() {
|
||||
|
||||
// Seed default Uncategorized category
|
||||
db.insert(schema.categories)
|
||||
.values({ name: "Uncategorized", emoji: "\u{1F4E6}" })
|
||||
.values({ name: "Uncategorized", icon: "package" })
|
||||
.run();
|
||||
|
||||
return db;
|
||||
|
||||
@@ -31,13 +31,13 @@ describe("Category Routes", () => {
|
||||
const res = await app.request("/api/categories", {
|
||||
method: "POST",
|
||||
headers: { "Content-Type": "application/json" },
|
||||
body: JSON.stringify({ name: "Shelter", emoji: "\u{26FA}" }),
|
||||
body: JSON.stringify({ name: "Shelter", icon: "tent" }),
|
||||
});
|
||||
|
||||
expect(res.status).toBe(201);
|
||||
const body = await res.json();
|
||||
expect(body.name).toBe("Shelter");
|
||||
expect(body.emoji).toBe("\u{26FA}");
|
||||
expect(body.icon).toBe("tent");
|
||||
expect(body.id).toBeGreaterThan(0);
|
||||
});
|
||||
|
||||
@@ -55,7 +55,7 @@ describe("Category Routes", () => {
|
||||
const catRes = await app.request("/api/categories", {
|
||||
method: "POST",
|
||||
headers: { "Content-Type": "application/json" },
|
||||
body: JSON.stringify({ name: "Shelter", emoji: "\u{26FA}" }),
|
||||
body: JSON.stringify({ name: "Shelter", icon: "tent" }),
|
||||
});
|
||||
const cat = await catRes.json();
|
||||
|
||||
|
||||
@@ -18,27 +18,27 @@ describe("Category Service", () => {
|
||||
});
|
||||
|
||||
describe("createCategory", () => {
|
||||
it("creates with name and emoji", () => {
|
||||
const cat = createCategory(db, { name: "Shelter", emoji: "\u{26FA}" });
|
||||
it("creates with name and icon", () => {
|
||||
const cat = createCategory(db, { name: "Shelter", icon: "tent" });
|
||||
|
||||
expect(cat).toBeDefined();
|
||||
expect(cat!.id).toBeGreaterThan(0);
|
||||
expect(cat!.name).toBe("Shelter");
|
||||
expect(cat!.emoji).toBe("\u{26FA}");
|
||||
expect(cat!.icon).toBe("tent");
|
||||
});
|
||||
|
||||
it("uses default emoji if not provided", () => {
|
||||
it("uses default icon if not provided", () => {
|
||||
const cat = createCategory(db, { name: "Cooking" });
|
||||
|
||||
expect(cat).toBeDefined();
|
||||
expect(cat!.emoji).toBe("\u{1F4E6}");
|
||||
expect(cat!.icon).toBe("package");
|
||||
});
|
||||
});
|
||||
|
||||
describe("getAllCategories", () => {
|
||||
it("returns all categories", () => {
|
||||
createCategory(db, { name: "Shelter", emoji: "\u{26FA}" });
|
||||
createCategory(db, { name: "Cooking", emoji: "\u{1F373}" });
|
||||
createCategory(db, { name: "Shelter", icon: "tent" });
|
||||
createCategory(db, { name: "Cooking", icon: "cooking-pot" });
|
||||
|
||||
const all = getAllCategories(db);
|
||||
// Includes seeded Uncategorized + 2 new
|
||||
@@ -48,20 +48,20 @@ describe("Category Service", () => {
|
||||
|
||||
describe("updateCategory", () => {
|
||||
it("renames category", () => {
|
||||
const cat = createCategory(db, { name: "Shelter", emoji: "\u{26FA}" });
|
||||
const cat = createCategory(db, { name: "Shelter", icon: "tent" });
|
||||
const updated = updateCategory(db, cat!.id, { name: "Sleep System" });
|
||||
|
||||
expect(updated).toBeDefined();
|
||||
expect(updated!.name).toBe("Sleep System");
|
||||
expect(updated!.emoji).toBe("\u{26FA}");
|
||||
expect(updated!.icon).toBe("tent");
|
||||
});
|
||||
|
||||
it("changes emoji", () => {
|
||||
const cat = createCategory(db, { name: "Shelter", emoji: "\u{26FA}" });
|
||||
const updated = updateCategory(db, cat!.id, { emoji: "\u{1F3E0}" });
|
||||
it("changes icon", () => {
|
||||
const cat = createCategory(db, { name: "Shelter", icon: "tent" });
|
||||
const updated = updateCategory(db, cat!.id, { icon: "home" });
|
||||
|
||||
expect(updated).toBeDefined();
|
||||
expect(updated!.emoji).toBe("\u{1F3E0}");
|
||||
expect(updated!.icon).toBe("home");
|
||||
});
|
||||
|
||||
it("returns null for non-existent id", () => {
|
||||
@@ -72,7 +72,7 @@ describe("Category Service", () => {
|
||||
|
||||
describe("deleteCategory", () => {
|
||||
it("reassigns items to Uncategorized (id=1) then deletes", () => {
|
||||
const shelter = createCategory(db, { name: "Shelter", emoji: "\u{26FA}" });
|
||||
const shelter = createCategory(db, { name: "Shelter", icon: "tent" });
|
||||
createItem(db, { name: "Tent", categoryId: shelter!.id });
|
||||
createItem(db, { name: "Tarp", categoryId: shelter!.id });
|
||||
|
||||
|
||||
@@ -61,7 +61,7 @@ describe("Item Service", () => {
|
||||
const all = getAllItems(db);
|
||||
expect(all).toHaveLength(2);
|
||||
expect(all[0].categoryName).toBe("Uncategorized");
|
||||
expect(all[0].categoryEmoji).toBeDefined();
|
||||
expect(all[0].categoryIcon).toBeDefined();
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
@@ -83,7 +83,7 @@ describe("Setup Service", () => {
|
||||
expect(result!.items).toHaveLength(1);
|
||||
expect(result!.items[0].name).toBe("Water Bottle");
|
||||
expect(result!.items[0].categoryName).toBe("Uncategorized");
|
||||
expect(result!.items[0].categoryEmoji).toBeDefined();
|
||||
expect(result!.items[0].categoryIcon).toBeDefined();
|
||||
});
|
||||
|
||||
it("returns null for non-existent setup", () => {
|
||||
|
||||
@@ -100,7 +100,7 @@ describe("Thread Service", () => {
|
||||
expect(result!.candidates).toHaveLength(1);
|
||||
expect(result!.candidates[0].name).toBe("Tent A");
|
||||
expect(result!.candidates[0].categoryName).toBe("Uncategorized");
|
||||
expect(result!.candidates[0].categoryEmoji).toBeDefined();
|
||||
expect(result!.candidates[0].categoryIcon).toBeDefined();
|
||||
});
|
||||
|
||||
it("returns null for non-existent thread", () => {
|
||||
|
||||
@@ -16,7 +16,7 @@ describe("Totals Service", () => {
|
||||
|
||||
describe("getCategoryTotals", () => {
|
||||
it("returns weight sum, cost sum, item count per category", () => {
|
||||
const shelter = createCategory(db, { name: "Shelter", emoji: "\u{26FA}" });
|
||||
const shelter = createCategory(db, { name: "Shelter", icon: "tent" });
|
||||
createItem(db, {
|
||||
name: "Tent",
|
||||
weightGrams: 1200,
|
||||
@@ -39,7 +39,7 @@ describe("Totals Service", () => {
|
||||
});
|
||||
|
||||
it("excludes empty categories (no items)", () => {
|
||||
createCategory(db, { name: "Shelter", emoji: "\u{26FA}" });
|
||||
createCategory(db, { name: "Shelter", icon: "tent" });
|
||||
// No items added
|
||||
const totals = getCategoryTotals(db);
|
||||
expect(totals).toHaveLength(0);
|
||||
|
||||
Reference in New Issue
Block a user