feat(17-02): refactor image service and routes to use S3 storage service
- Replace Bun.write/mkdir with uploadImage() from storage.service - Remove uploadsDir parameter from fetchImageFromUrl - Update tests to mock storage service instead of checking filesystem
This commit is contained in:
@@ -1,8 +1,29 @@
|
||||
import { beforeEach, describe, expect, test } from "bun:test";
|
||||
import { beforeEach, describe, expect, mock, test } from "bun:test";
|
||||
import { Hono } from "hono";
|
||||
import { imageRoutes } from "../../src/server/routes/images";
|
||||
import { createTestDb } from "../helpers/db.ts";
|
||||
|
||||
// Mock storage service before importing routes
|
||||
const mockUploadImage = mock(() => Promise.resolve());
|
||||
mock.module("../../src/server/services/storage.service", () => ({
|
||||
uploadImage: mockUploadImage,
|
||||
deleteImage: mock(() => Promise.resolve()),
|
||||
getImageUrl: mock(() => Promise.resolve("https://s3.example.com/test.png")),
|
||||
withImageUrl: mock((r: any) => Promise.resolve({ ...r, imageUrl: null })),
|
||||
withImageUrls: mock((rs: any[]) =>
|
||||
Promise.resolve(rs.map((r) => ({ ...r, imageUrl: null }))),
|
||||
),
|
||||
}));
|
||||
|
||||
// Also mock image service for from-url test
|
||||
const mockFetchImageFromUrl = mock(() =>
|
||||
Promise.resolve({ filename: "test.png", sourceUrl: "https://example.com/img.png" }),
|
||||
);
|
||||
mock.module("../../src/server/services/image.service", () => ({
|
||||
fetchImageFromUrl: mockFetchImageFromUrl,
|
||||
}));
|
||||
|
||||
const { imageRoutes } = await import("../../src/server/routes/images.ts");
|
||||
|
||||
let app: Hono;
|
||||
|
||||
beforeEach(async () => {
|
||||
@@ -14,6 +35,8 @@ beforeEach(async () => {
|
||||
await next();
|
||||
});
|
||||
app.route("/api/images", imageRoutes);
|
||||
mockUploadImage.mockClear();
|
||||
mockFetchImageFromUrl.mockClear();
|
||||
});
|
||||
|
||||
describe("POST /api/images/from-url", () => {
|
||||
@@ -35,3 +58,48 @@ describe("POST /api/images/from-url", () => {
|
||||
expect(res.status).toBe(400);
|
||||
});
|
||||
});
|
||||
|
||||
describe("POST /api/images", () => {
|
||||
test("returns 400 when no image file provided", async () => {
|
||||
const formData = new FormData();
|
||||
const res = await app.request("/api/images", {
|
||||
method: "POST",
|
||||
body: formData,
|
||||
});
|
||||
expect(res.status).toBe(400);
|
||||
const json = await res.json();
|
||||
expect(json.error).toBe("No image file provided");
|
||||
});
|
||||
|
||||
test("returns 400 for invalid file type", async () => {
|
||||
const formData = new FormData();
|
||||
formData.append(
|
||||
"image",
|
||||
new Blob(["test"], { type: "text/plain" }),
|
||||
"test.txt",
|
||||
);
|
||||
const res = await app.request("/api/images", {
|
||||
method: "POST",
|
||||
body: formData,
|
||||
});
|
||||
expect(res.status).toBe(400);
|
||||
const json = await res.json();
|
||||
expect(json.error).toContain("Invalid file type");
|
||||
});
|
||||
|
||||
test("uploads valid image and calls storage service", async () => {
|
||||
const formData = new FormData();
|
||||
const pngBlob = new Blob([new Uint8Array([0x89, 0x50, 0x4e, 0x47])], {
|
||||
type: "image/png",
|
||||
});
|
||||
formData.append("image", pngBlob, "test.png");
|
||||
const res = await app.request("/api/images", {
|
||||
method: "POST",
|
||||
body: formData,
|
||||
});
|
||||
expect(res.status).toBe(201);
|
||||
const json = await res.json();
|
||||
expect(json.filename).toMatch(/^\d+-[\w-]+\.png$/);
|
||||
expect(mockUploadImage).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user