makiolaj/GearBox
1
0
Fork 0
Code Issues 8 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

feat(05-02): add always-visible 4:3 image area with placeholders to ItemCard and CandidateCard

Browse Source 
- Replace conditional image rendering with always-present 4:3 aspect ratio area
- Show category emoji centered on gray background when no image exists
- Ensures consistent card heights across grid layouts

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jean-Luc Makiola
2026-03-15 17:14:20 +01:00
parent 036d8ac183
commit acf34c33d9
2 changed files with 177 additions and 159 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/client/components/CandidateCard.tsx
View File

@@ -1,4 +1,4 @@
import { formatWeight, formatPrice } from "../lib/formatters"; import { formatPrice, formatWeight } from "../lib/formatters";
import { useUIStore } from "../stores/uiStore"; import { useUIStore } from "../stores/uiStore";
interface CandidateCardProps { interface CandidateCardProps {
@@ -32,15 +32,19 @@ export function CandidateCard({
return ( return (
<div className="bg-white rounded-xl border border-gray-100 hover:border-gray-200 hover:shadow-sm transition-all overflow-hidden"> <div className="bg-white rounded-xl border border-gray-100 hover:border-gray-200 hover:shadow-sm transition-all overflow-hidden">
{imageFilename && (
<div className="aspect-[4/3] bg-gray-50"> <div className="aspect-[4/3] bg-gray-50">
{imageFilename ? (
<img <img
src={`/uploads/${imageFilename}`} src={`/uploads/${imageFilename}`}
alt={name} alt={name}
className="w-full h-full object-cover" className="w-full h-full object-cover"
/> />
) : (
<div className="w-full h-full flex flex-col items-center justify-center">
<span className="text-3xl">{categoryEmoji}</span>
</div> </div>
)} )}
</div>
<div className="p-4"> <div className="p-4">
<h3 className="text-sm font-semibold text-gray-900 mb-2 truncate"> <h3 className="text-sm font-semibold text-gray-900 mb-2 truncate">
{name} {name}

22
src/client/components/ItemCard.tsx
View File

@@ -1,4 +1,4 @@
import { formatWeight, formatPrice } from "../lib/formatters"; import { formatPrice, formatWeight } from "../lib/formatters";
import { useUIStore } from "../stores/uiStore"; import { useUIStore } from "../stores/uiStore";
interface ItemCardProps { interface ItemCardProps {
@@ -47,20 +47,34 @@ export function ItemCard({
className="absolute top-2 right-2 z-10 w-6 h-6 flex items-center justify-center rounded-full bg-gray-100/80 text-gray-400 hover:bg-red-100 hover:text-red-500 opacity-0 group-hover:opacity-100 transition-all cursor-pointer" className="absolute top-2 right-2 z-10 w-6 h-6 flex items-center justify-center rounded-full bg-gray-100/80 text-gray-400 hover:bg-red-100 hover:text-red-500 opacity-0 group-hover:opacity-100 transition-all cursor-pointer"
title="Remove from setup" title="Remove from setup"
> >
<svg className="w-3.5 h-3.5" fill="none" stroke="currentColor" viewBox="0 0 24 24"> <svg
<path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M6 18L18 6M6 6l12 12" /> className="w-3.5 h-3.5"
fill="none"
stroke="currentColor"
viewBox="0 0 24 24"
>
<path
strokeLinecap="round"
strokeLinejoin="round"
strokeWidth={2}
d="M6 18L18 6M6 6l12 12"
/>
</svg> </svg>
</span> </span>
)} )}
{imageFilename && (
<div className="aspect-[4/3] bg-gray-50"> <div className="aspect-[4/3] bg-gray-50">
{imageFilename ? (
<img <img
src={`/uploads/${imageFilename}`} src={`/uploads/${imageFilename}`}
alt={name} alt={name}
className="w-full h-full object-cover" className="w-full h-full object-cover"
/> />
) : (
<div className="w-full h-full flex flex-col items-center justify-center">
<span className="text-3xl">{categoryEmoji}</span>
</div> </div>
)} )}
</div>
<div className="p-4"> <div className="p-4">
<h3 className="text-sm font-semibold text-gray-900 mb-2 truncate"> <h3 className="text-sm font-semibold text-gray-900 mb-2 truncate">
{name} {name}