fix(25): revise plans based on checker feedback
This commit is contained in:
@@ -423,7 +423,7 @@ interface GlobalItemWithOwnerCount extends GlobalItem { ownerCount: number; }
|
||||
Add a `describe("catalog tools")` block with tests:
|
||||
- `upsert_catalog_item` creates a new global item and returns it with created: true
|
||||
- `upsert_catalog_item` updates existing item on (brand, model) match
|
||||
- `upsert_catalog_item` includes attribution fields (sourceUrl, imageCredit, imageSourceUrl) in result
|
||||
- `upsert_catalog_item` includes attribution fields (sourceUrl, imageCredit, imageSourceUrl) in result — pass all three attribution fields and assert they appear in the returned item (SEED-03 coverage)
|
||||
- `bulk_upsert_catalog` processes array and returns created/updated counts
|
||||
- `bulk_upsert_catalog` returns totalProcessed matching input length
|
||||
- Tool definitions include all attribution fields in inputSchema
|
||||
@@ -442,6 +442,7 @@ interface GlobalItemWithOwnerCount extends GlobalItem { ownerCount: number; }
|
||||
- src/server/mcp/index.ts contains `import.*catalogToolDefinitions.*registerCatalogTools`
|
||||
- src/server/mcp/index.ts contains `registerCatalogTools(db)`
|
||||
- tests/mcp/tools.test.ts contains `upsert_catalog_item` in at least 2 test descriptions
|
||||
- tests/mcp/tools.test.ts contains at least one test that passes sourceUrl, imageCredit, and imageSourceUrl to upsert_catalog_item and asserts they appear in the returned item (SEED-03 coverage)
|
||||
- `bun test tests/mcp/tools.test.ts` exits 0
|
||||
</acceptance_criteria>
|
||||
<done>Two MCP catalog tools registered and functional with attribution fields, all MCP tool tests passing</done>
|
||||
@@ -534,7 +535,7 @@ interface GlobalItemWithOwnerCount extends GlobalItem { ownerCount: number; }
|
||||
- `bun run build` exits 0 (no TypeScript errors)
|
||||
- `bun run lint` exits 0
|
||||
</acceptance_criteria>
|
||||
<done>Catalog detail page shows image attribution inline below image (credit + source link) and product page link, client types updated</done>
|
||||
<done>Catalog detail page shows image attribution inline below image (credit + source link) and product page link, client types updated. Manual verification required: open a catalog item with imageCredit set and confirm credit and source link render below the image (CATL-03 is visual — no automated test).</done>
|
||||
</task>
|
||||
|
||||
</tasks>
|
||||
|
||||
Reference in New Issue
Block a user