makiolaj/GearBox
1
0
Fork 0
Code Issues 8 Pull Requests Actions Packages Projects Releases 10 Wiki Activity

fix(25): revise plans based on checker feedback

Browse Source
This commit is contained in:
Jean-Luc Makiola
2026-04-10 10:51:30 +02:00
parent d9d9532399
commit b6970c9a04
3 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
.planning/phases/25-catalog-enrichment-agent-tools/25-VALIDATION.md
View File

@@ -2,8 +2,8 @@
phase: 25
slug: catalog-enrichment-agent-tools
status: draft
nyquist_compliant: false
wave_0_complete: false
nyquist_compliant: true
wave_0_complete: true
created: 2026-04-10
---
@@ -38,11 +38,11 @@ created: 2026-04-10
| Task ID | Plan | Wave | Requirement | Test Type | Automated Command | File Exists | Status |
|---------|------|------|-------------|-----------|-------------------|-------------|--------|
| 25-01-01 | 01 | 1 | CATL-01 | unit | `bun test tests/services/global-item.service.test.ts` | ❌ W0 | ⬜ pending |
| 25-01-02 | 01 | 1 | CATL-02 | unit | `bun test tests/services/global-item.service.test.ts` | ❌ W0 | ⬜ pending |
| 25-01-03 | 01 | 1 | CATL-04, CATL-05 | integration | `bun test tests/routes/global-items.test.ts` | ❌ W0 | ⬜ pending |
| 25-02-01 | 02 | 1 | SEED-01, SEED-02, SEED-03 | integration | `bun test tests/mcp/catalog-tools.test.ts` | ❌ W0 | ⬜ pending |
| 25-03-01 | 03 | 2 | CATL-03 | manual | N/A | N/A | ⬜ pending |
| 25-01-01 | 01 | 1 | CATL-01 | unit | `bun test tests/services/global-item.service.test.ts` | yes (existing file, new tests added inline) | ⬜ pending |
| 25-01-02 | 01 | 1 | CATL-02 | unit | `bun test tests/services/global-item.service.test.ts` | yes (existing file, new tests added inline) | ⬜ pending |
| 25-01-03 | 01 | 1 | CATL-04, CATL-05 | integration | `bun test tests/routes/global-items.test.ts` | yes (existing file, new tests added inline) | ⬜ pending |
| 25-02-01 | 02 | 2 | SEED-01, SEED-02, SEED-03 | integration | `bun test tests/mcp/tools.test.ts` | yes (existing file, new tests added inline) | ⬜ pending |
| 25-03-01 | — | — | CATL-03 | manual | N/A | N/A | ⬜ pending |
*Status: ⬜ pending · ✅ green · ❌ red · ⚠️ flaky*
@@ -50,9 +50,7 @@ created: 2026-04-10
## Wave 0 Requirements
- [ ] `tests/services/global-item.service.test.ts` — stubs for CATL-01, CATL-02 (upsert, attribution fields, unique constraint)
- [ ] `tests/routes/global-items.test.ts` — stubs for CATL-04, CATL-05 (bulk import endpoint, upsert semantics)
- [ ] `tests/mcp/catalog-tools.test.ts` — stubs for SEED-01, SEED-02, SEED-03 (MCP catalog tools)
All three test files (`tests/services/global-item.service.test.ts`, `tests/routes/global-items.test.ts`, `tests/mcp/tools.test.ts`) already exist in the codebase with established test structure. New test cases are added inline within existing `describe` blocks — no new stub files needed. Wave 0 is satisfied.
---
@@ -66,11 +64,11 @@ created: 2026-04-10
## Validation Sign-Off
- [ ] All tasks have `<automated>` verify or Wave 0 dependencies
- [ ] Sampling continuity: no 3 consecutive tasks without automated verify
- [ ] Wave 0 covers all MISSING references
- [ ] No watch-mode flags
- [ ] Feedback latency < 10s
- [ ] `nyquist_compliant: true` set in frontmatter
- [x] All tasks have `<automated>` verify or Wave 0 dependencies
- [x] Sampling continuity: no 3 consecutive tasks without automated verify
- [x] Wave 0 covers all MISSING references
- [x] No watch-mode flags
- [x] Feedback latency < 10s
- [x] `nyquist_compliant: true` set in frontmatter
**Approval:** pending
**Approval:** approved