Jean-Luc Makiola
261c1f9d02
Archive roadmap, requirements, and phase directories to milestones/. Evolve PROJECT.md with validated requirements and key decisions. Reorganize ROADMAP.md with milestone grouping. Delete REQUIREMENTS.md (fresh for next milestone).
15 KiB
15 KiB
phase, plan, type, wave, depends_on, files_modified, autonomous, requirements, must_haves
| phase | plan | type | wave | depends_on | files_modified | autonomous | requirements | must_haves | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 02-planning-threads | 02 | execute | 2 |
|
|
true |
|
|
Purpose: Give users the full planning thread workflow in the UI -- create threads, add candidates, compare them visually, and resolve by picking a winner.
Output: Fully interactive thread planning UI that consumes the API from Plan 01.
<execution_context> @/home/jean-luc-makiola/.claude/get-shit-done/workflows/execute-plan.md @/home/jean-luc-makiola/.claude/get-shit-done/templates/summary.md </execution_context>
@.planning/PROJECT.md @.planning/ROADMAP.md @.planning/phases/02-planning-threads/02-CONTEXT.md @.planning/phases/02-planning-threads/02-RESEARCH.md @.planning/phases/02-planning-threads/02-01-SUMMARY.mdFrom src/client/stores/uiStore.ts (extend this):
interface UIState {
panelMode: "closed" | "add" | "edit";
editingItemId: number | null;
confirmDeleteItemId: number | null;
openAddPanel: () => void;
openEditPanel: (itemId: number) => void;
closePanel: () => void;
openConfirmDelete: (itemId: number) => void;
closeConfirmDelete: () => void;
}
From src/client/routes/__root.tsx (modify for tab-aware layout):
// Currently renders TotalsBar, Outlet, SlideOutPanel (item-specific), ConfirmDialog, FAB
// Need to: make SlideOutPanel and FAB context-aware (items vs candidates)
// Need to: add candidate panel handling alongside item panel
From src/client/routes/index.tsx (refactor to add tabs):
// Currently: CollectionPage renders items grouped by category
// Becomes: HomePage with tab switcher, CollectionView (existing content) and PlanningView (new)
From src/client/hooks/useItems.ts (pattern to follow for hooks):
// Uses apiGet, apiPost, apiPut, apiDelete from "../lib/api"
// Uses useQuery with queryKey: ["items"]
// Uses useMutation with onSuccess: invalidateQueries(["items"])
API endpoints from Plan 01:
- GET /api/threads (optional ?includeResolved=true)
- POST /api/threads { name }
- GET /api/threads/:id (returns thread with candidates)
- PUT /api/threads/:id { name }
- DELETE /api/threads/:id
- POST /api/threads/:id/candidates (form data with optional image)
- PUT /api/threads/:threadId/candidates/:candidateId
- DELETE /api/threads/:threadId/candidates/:candidateId
- POST /api/threads/:id/resolve { candidateId }
2. **Create `src/client/hooks/useCandidates.ts`:** TanStack Query mutation hooks.
- `useCreateCandidate(threadId: number)`: POST /api/threads/:id/candidates (use apiUpload for form data with optional image), onSuccess invalidates ["threads", threadId] and ["threads"] (list needs updated candidate count)
- `useUpdateCandidate(threadId: number)`: PUT endpoint, onSuccess invalidates ["threads", threadId]
- `useDeleteCandidate(threadId: number)`: DELETE endpoint, onSuccess invalidates ["threads", threadId] and ["threads"]
3. **Extend `src/client/stores/uiStore.ts`:** Add thread-specific UI state alongside existing item state. Add:
- `candidatePanelMode: "closed" | "add" | "edit"` (separate from item panelMode)
- `editingCandidateId: number | null`
- `confirmDeleteCandidateId: number | null`
- `resolveThreadId: number | null` and `resolveCandidateId: number | null` (for resolution confirm dialog)
- Actions: `openCandidateAddPanel()`, `openCandidateEditPanel(id)`, `closeCandidatePanel()`, `openConfirmDeleteCandidate(id)`, `closeConfirmDeleteCandidate()`, `openResolveDialog(threadId, candidateId)`, `closeResolveDialog()`
- Keep all existing item state unchanged.
4. **Create `src/client/components/ThreadTabs.tsx`:** Tab switcher component.
- Two tabs: "My Gear" and "Planning"
- Accept `active: "gear" | "planning"` and `onChange: (tab) => void` props
- Clean, minimal styling consistent with the app. Underline/highlight active tab.
5. **Create `src/client/components/ThreadCard.tsx`:** Card for thread list.
- Props: id, name, candidateCount, minPriceCents, maxPriceCents, createdAt, status
- Card layout matching ItemCard visual pattern (same rounded corners, shadows, padding)
- Name displayed prominently
- Pill/chip tags for: candidate count (e.g. "3 candidates"), creation date (formatted), price range (e.g. "$50-$120" or "No prices" if null)
- Click navigates to thread detail: `navigate({ to: "/threads/$threadId", params: { threadId: String(id) } })`
- Visual distinction for resolved threads (muted/grayed)
6. **Refactor `src/client/routes/index.tsx`:** Transform from CollectionPage into tabbed HomePage.
- Add `validateSearch` with `z.object({ tab: z.enum(["gear", "planning"]).catch("gear") })`
- Render ThreadTabs at the top
- When tab="gear": render existing collection content (extract into a CollectionView section or keep inline)
- When tab="planning": render PlanningView with thread list
- PlanningView shows: thread cards in a grid, "Create Thread" button (inline input or small form -- use a simple text input + button above the grid), empty state if no threads ("No planning threads yet. Start one to research your next purchase.")
- Toggle for "Show archived threads" that passes includeResolved to useThreads
- The FAB (floating add button) in __root.tsx should be context-aware: on gear tab it opens add item panel, on planning tab it could create a thread (or just hide -- use discretion)
2. **Create `src/client/components/CandidateForm.tsx`:** Form for adding/editing candidates.
- Structurally similar to ItemForm but uses candidate hooks (useCreateCandidate, useUpdateCandidate)
- Same fields: name (required), weight (in grams, displayed as user-friendly input), price (in dollars, converted to cents for API), category (reuse CategoryPicker), notes, product URL, image upload (reuse ImageUpload component)
- mode="add": creates candidate via useCreateCandidate
- mode="edit": loads candidate data, updates via useUpdateCandidate
- On success: closes panel via closeCandidatePanel()
- Dollar-to-cents conversion on submit (same as ItemForm pattern)
3. **Create `src/client/routes/threads/$threadId.tsx`:** Thread detail page.
- File-based route using `createFileRoute("/threads/$threadId")`
- Parse threadId from route params
- Use `useThread(threadId)` to fetch thread with candidates
- Header: thread name, back link to `/?tab=planning`, thread status badge
- If thread is active: "Add Candidate" button that opens candidate add panel
- Candidate grid: same responsive grid as collection (1 col mobile, 2 md, 3 lg) using CandidateCard
- Empty state: "No candidates yet. Add your first candidate to start comparing."
- If thread is resolved: show which candidate won (highlight the winning candidate or show a banner)
- Loading and error states
4. **Update `src/client/routes/__root.tsx`:** Make the root layout handle both item and candidate panels/dialogs.
- Add a second SlideOutPanel instance for candidates (controlled by candidatePanelMode from uiStore). Title: "Add Candidate" or "Edit Candidate".
- Render CandidateForm inside the candidate panel.
- Add a resolution ConfirmDialog: when resolveThreadId is set in uiStore, show "Pick [candidate name] as winner? This will add it to your collection." On confirm, call useResolveThread mutation, on success close dialog and navigate back to `/?tab=planning`. On cancel, close dialog.
- Add a candidate delete ConfirmDialog: when confirmDeleteCandidateId is set, show delete confirmation. On confirm, call useDeleteCandidate.
- Keep existing item panel and delete dialog unchanged.
- The existing FAB should still work on the gear tab. On the threads detail page, the "Add Candidate" button handles adding, so the FAB can remain item-focused or be hidden on non-index routes.
All tests still pass (no regressions)
bun test --bail
</verification>
<success_criteria>
- Tab navigation switches between My Gear and Planning views
- Thread list shows cards with name, candidate count, date, price range
- New threads can be created from the Planning tab
- Thread detail page shows candidate cards in a grid
- Candidates can be added, edited, and deleted via slide-out panel
- Resolution confirmation dialog appears when picking a winner
- After resolution, thread is archived and item appears in collection
- Resolved threads hidden by default, visible with toggle
- All existing Phase 1 UI functionality unaffected
- Build succeeds with no errors
</success_criteria>
<output>
After completion, create `.planning/phases/02-planning-threads/02-02-SUMMARY.md`
</output>