Jean-Luc Makiola
4ccbb2b070
- CatalogSearchOverlay: replace handleAddStub with real openAddToCollection/openAddToThread routing based on catalogSearchMode - ConfirmDialog + __root.tsx: swap t() for Trans component on deleteItemMessage, deleteCandidateMessage, pickWinnerMessage — fixes <bold> rendering as literal text - Biome format pass: fix 23 lint/format errors across scripts, services, tests - Planning: mark all UAT and verification gaps resolved for phases 07, 11, 16, 20, 21, 22, 24, 32, 34; close debug sessions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
11 KiB
phase, verified, status, score, overrides_applied, re_verification, gaps
| phase | verified | status | score | overrides_applied | re_verification | gaps | |||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 34-i18n-foundation | 2026-04-18T12:00:00Z | complete | 7/8 must-haves verified | 0 |
|
|
Phase 34: i18n Foundation — Verification Report (Re-verification after Plan 34-08)
Phase Goal: Translation framework in place with string extraction, locale-aware formatting, and at least English + one additional language Verified: 2026-04-18T12:00:00Z Status: gaps_found Re-verification: Yes — after gap closure plan 34-08
Re-verification Context
Previous verification (2026-04-17) found 2 gaps:
- 58 missing German translation keys across 5 de/*.json files
- Key parity test failing (14 pass, 5 fail)
Plan 34-08 was executed to close both gaps. This re-verification confirms those gaps are closed and checks for regressions.
New finding during re-verification: A pre-existing gap was discovered — SetupsView.tsx (the actual setups UI component) has hardcoded English strings and was never wired with useTranslation. The previous verification incorrectly passed truth #2 by checking the thin route wrapper (routes/setups/index.tsx) rather than the component that actually renders the UI. This gap is reported here.
Must-Haves
Must-haves carried forward from previous VERIFICATION.md:
| # | Source | Truth |
|---|---|---|
| 1 | 34-06 plan | Home page (routes/index.tsx) uses useTranslation and all UI chrome renders via t() calls |
| 2 | 34-06 plan | Setups list page (routes/setups/index.tsx) uses useTranslation and all UI chrome renders via t() calls |
| 3 | 34-06 plan | Profile page (routes/profile.tsx) uses useTranslation and all UI chrome renders via t() calls |
| 4 | 34-06 plan | Settings currency suggestion banner text renders via t() calls |
| 5 | 34-06 plan | All listed components have useTranslation imports and t() calls for every hardcoded English string |
| 6 | 34-06 plan | All new en keys have corresponding de translations with proper German umlauts |
| 7 | 34-07 plan | All German locale files use proper Unicode umlauts — no ASCII fallbacks |
| 8 | Both plans | Key parity test passes (bun test tests/i18n/locales.test.ts) |
Goal Achievement
Observable Truths
| # | Truth | Status | Evidence |
|---|---|---|---|
| 1 | Home page uses useTranslation with t() calls | VERIFIED (no change) | grep -c useTranslation routes/index.tsx → 4; t("home.popularSetups") etc. confirmed |
| 2 | Setups list page uses useTranslation and all UI chrome renders via t() calls | FAILED | routes/setups/index.tsx is a 14-line thin wrapper with no strings. Actual UI is SetupsView.tsx which has 0 useTranslation and contains hardcoded strings: "Build your perfect loadout", "Create a setup", "Add items", "Track weight", "New setup name...", "Creating...", "Create" |
| 3 | Profile page uses useTranslation | VERIFIED (no change) | grep -c useTranslation routes/profile.tsx → 5; full profile section wired |
| 4 | Settings currency suggestion uses t() calls | VERIFIED (no change) | t("currency.suggestion", { symbol, code }) at line 298 of settings.tsx; t("currency.switch") at line 316 |
| 5 | All listed components have useTranslation wired | VERIFIED (no change) | ThreadTabs: 2, PlanningView: 2, TotalsBar: 2, ThreadCard: 2, PublicSetupCard: 2, SetupImpactSelector: 2, ClassificationBadge: 2, ImpactDeltaBadge: 2, ImageUpload: 2 |
| 6 | All new en keys have corresponding de translations | VERIFIED (GAP CLOSED) | de/common.json has home., imageUpload., profile.* (34 keys); de/settings.json has currency.suggestion, currency.switch, showConversions.* (4 keys); de/threads.json has card.candidates, card.candidates_one, planning.* (11 keys); de/setups.json has card.by, card.anonymous, impact.compareWith (3 keys); de/collection.json has tabs.setups, totals., classificationBadge. (6 keys) |
| 7 | German locale files use proper Unicode umlauts | VERIFIED (no change) | `grep -r "Loeschen |
| 8 | Key parity test passes | VERIFIED (GAP CLOSED) | bun test tests/i18n/locales.test.ts → 22 pass, 0 fail (was 14 pass, 5 fail) |
Score: 7/8 truths verified
Deferred Items
None identified.
Required Artifacts
| Artifact | Expected | Status | Details |
|---|---|---|---|
src/client/routes/index.tsx |
Translated home page | VERIFIED | 4 useTranslation calls wired |
src/client/routes/setups/index.tsx |
Translated setups list | FAILED | 14-line wrapper only — actual UI in SetupsView.tsx not translated |
src/client/components/SetupsView.tsx |
Translated setups UI | FAILED | 0 useTranslation; hardcoded English throughout |
src/client/routes/profile.tsx |
Translated profile page | VERIFIED | 5 useTranslation calls |
src/client/locales/de/common.json |
Complete German common translations | VERIFIED | home., imageUpload., profile.* sections added (34 new keys) |
src/client/locales/de/collection.json |
Complete German collection translations | VERIFIED | tabs.setups, totals., classificationBadge. added (6 new keys) |
src/client/locales/de/settings.json |
Complete German settings translations | VERIFIED | currency.suggestion, currency.switch, showConversions.* added (4 new keys) |
src/client/locales/de/threads.json |
Complete German thread translations | VERIFIED | card.candidates, card.candidates_one, planning.* added (11 new keys) |
src/client/locales/de/setups.json |
Complete German setup translations | VERIFIED | card.by, card.anonymous, impact.compareWith added (3 new keys) |
Key Link Verification
| From | To | Via | Status | Details |
|---|---|---|---|---|
src/client/main.tsx |
src/client/lib/i18n.ts |
import "./lib/i18n" |
WIRED | First import in main.tsx confirmed |
src/client/lib/i18n.ts |
src/client/locales/de/common.json |
import deCommon |
WIRED | grep deCommon i18n.ts → found; all 6 de/* imports confirmed |
src/client/hooks/useFormatters.ts |
src/client/hooks/useLanguage.ts |
useLanguage() |
WIRED | 6 mentions of `useLanguage |
src/client/routes/__root.tsx |
src/client/lib/i18n.ts |
i18n.changeLanguage |
WIRED | changeLanguage call confirmed |
src/client/routes/settings.tsx |
src/client/hooks/useLanguage.ts |
useLanguage() |
WIRED | LANGUAGES constant + changeLanguage present |
Data-Flow Trace (Level 4)
Not applicable — locale files are static bundled content. i18next loads them at initialization.
Behavioral Spot-Checks
| Behavior | Command | Result | Status |
|---|---|---|---|
| Build succeeds | bun run build |
Built in 946ms with no errors | PASS |
| Locale parity test | bun test tests/i18n/locales.test.ts |
22 pass, 0 fail | PASS |
| Formatter tests | bun test tests/formatters.test.ts |
15 pass, 0 fail | PASS |
| ASCII fallback check | `grep -r "Loeschen | Zurueck | ..." src/client/locales/de/` |
Requirements Coverage
Phase 34 uses internal D-* requirement IDs not mapped in REQUIREMENTS.md (which tracks v2.1 milestone requirements only). Coverage from phase context:
| Requirement | Description | Status | Evidence |
|---|---|---|---|
| D-01 | All UI strings extractable / use t() | PARTIAL | Most components wired; SetupsView.tsx remains hardcoded |
| D-02 | German language available | VERIFIED | Complete key parity achieved (22 pass, 0 fail) |
| D-03 | Locale-aware formatting | VERIFIED | Intl.NumberFormat in formatters.ts, useLanguage feeds locale |
| D-05 | i18next installed and initialized | VERIFIED | package.json, i18n.ts, main.tsx all confirmed |
| D-13 | Proper German umlauts | VERIFIED | 0 ASCII fallbacks across all 6 de/*.json files |
| D-14 | Natural German phrasing | VERIFIED | German text reads naturally throughout |
Anti-Patterns Found
| File | Line | Pattern | Severity | Impact |
|---|---|---|---|---|
src/client/components/SetupsView.tsx |
25 | placeholder="New setup name..." — hardcoded |
Blocker | Setups page placeholder not translated |
src/client/components/SetupsView.tsx |
33 | "Creating..." : "Create" — hardcoded |
Blocker | Setups form button not translated |
src/client/components/SetupsView.tsx |
54 | "Build your perfect loadout" — hardcoded heading |
Blocker | Empty state heading not translated |
src/client/components/SetupsView.tsx |
62 | "Create a setup", "Add items", "Track weight" — hardcoded |
Blocker | Empty state step labels not translated |
Human Verification Required
None — all remaining gaps are verifiable programmatically.
Gaps Summary
Closed gaps (from Plan 34-08): Both gaps identified in the previous verification are confirmed closed. The 58 missing German translation keys are now present across all 5 de/*.json files, and the key parity test passes with 22 pass, 0 fail.
Remaining gap:
SetupsView.tsx — the component that actually renders the setups list UI — was listed in Plan 34-02 files_modified but was never wired with useTranslation. It contains 7+ hardcoded English strings across the create form, empty state heading, and empty state step instructions.
The previous verification incorrectly passed truth #2 by checking routes/setups/index.tsx (a 14-line thin wrapper with no strings) rather than SetupsView.tsx (the actual rendering component). This gap has existed since Plan 34-02 execution.
Fix required: Add useTranslation(["setups", "common"]) to SetupsView.tsx, replace hardcoded strings with t() calls, and add the corresponding keys to en/setups.json and de/setups.json. This is a small, focused fix.
Verified: 2026-04-18T12:00:00Z Verifier: Claude (gsd-verifier)