9.7 KiB
phase, plan, type, wave, depends_on, files_modified, autonomous, requirements, must_haves
| phase | plan | type | wave | depends_on | files_modified | autonomous | requirements | must_haves | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 07-task-sorting | 02 | execute | 2 |
|
|
true |
|
|
Purpose: Gives users visible access to the sort controls. The data layer from Plan 01 already sorts reactively; this plan adds the UI trigger.
Output: SortDropdown reusable widget, updated HomeScreen with AppBar, updated TaskListScreen with dropdown in existing AppBar, updated tests.
<execution_context> @/home/jlmak/.claude/get-shit-done/workflows/execute-plan.md @/home/jlmak/.claude/get-shit-done/templates/summary.md </execution_context>
@.planning/PROJECT.md @.planning/ROADMAP.md @.planning/STATE.md @.planning/phases/07-task-sorting/07-CONTEXT.md @.planning/phases/07-task-sorting/07-01-SUMMARY.mdFrom lib/features/tasks/domain/task_sort_option.dart (created in 07-01):
enum TaskSortOption { alphabetical, interval, effort }
From lib/features/tasks/presentation/sort_preference_notifier.dart (created in 07-01):
@riverpod
class SortPreferenceNotifier extends _$SortPreferenceNotifier {
TaskSortOption build(); // returns alphabetical by default
Future<void> setSortOption(TaskSortOption option);
}
// Generated as: sortPreferenceProvider
From lib/l10n/app_de.arb (strings added in 07-01):
sortAlphabetical: "A-Z"
sortInterval: "Intervall"
sortEffort: "Aufwand"
sortLabel: "Sortierung"
From lib/features/home/presentation/home_screen.dart:
class HomeScreen extends ConsumerStatefulWidget {
// Currently: Stack with CalendarStrip + CalendarDayList + floating Today FAB
// No AppBar — body sits directly inside AppShell's Scaffold
}
From lib/features/tasks/presentation/task_list_screen.dart:
class TaskListScreen extends ConsumerWidget {
// Has its own Scaffold with AppBar containing edit + delete IconButtons
// AppBar actions: [edit, delete]
}
From lib/features/home/presentation/calendar_strip.dart:
class CalendarStrip extends StatefulWidget {
const CalendarStrip({super.key, required this.controller, this.onTodayVisibilityChanged});
final CalendarStripController controller;
final ValueChanged<bool>? onTodayVisibilityChanged;
}
2. Edit `lib/features/home/presentation/home_screen.dart`:
- HomeScreen currently returns a `Stack` with `Column(CalendarStrip, Expanded(CalendarDayList))` + optional floating Today button
- Wrap the entire current Stack in a `Scaffold` with an `AppBar`:
- `AppBar(title: Text(l10n.tabHome), actions: [const SortDropdown()])`
- The `tabHome` l10n string already exists ("Ubersicht") — reuse it as the AppBar title for the home screen
- body: the existing Stack content
- Keep CalendarStrip, CalendarDayList, and floating Today FAB exactly as they are
- Import `sort_dropdown.dart`
- Note: HomeScreen is inside AppShell's Scaffold body. Adding a nested Scaffold is fine and standard for per-tab AppBars in StatefulShellRoute.indexedStack. The AppShell Scaffold provides the bottom nav; the inner Scaffold provides the AppBar.
3. Edit `lib/features/tasks/presentation/task_list_screen.dart`:
- In the existing `AppBar.actions` list, add `const SortDropdown()` BEFORE the edit and delete IconButtons. Order: [SortDropdown, edit, delete].
- Import `sort_dropdown.dart`
- No other changes to TaskListScreen
cd /home/jlmak/Projects/jlmak/HouseHoldKeaper && flutter analyze --no-fatal-infos
SortDropdown widget exists showing current sort label with sort icon. HomeScreen has AppBar with title "Ubersicht" and SortDropdown. TaskListScreen AppBar has SortDropdown before edit/delete buttons. dart analyze clean.
Task 2: Update tests for HomeScreen AppBar and sort dropdown
test/features/home/presentation/home_screen_test.dart
1. Edit `test/features/home/presentation/home_screen_test.dart`:
- Add import for `sort_preference_notifier.dart` and `task_sort_option.dart`
- In the `_buildApp` helper, add a provider override for `sortPreferenceProvider`:
```dart
sortPreferenceProvider.overrideWith(SortPreferenceNotifier.new),
```
This will use the real notifier with mock SharedPreferences (already set up in setUp).
- Add a new test group `'HomeScreen sort dropdown'`:
- Test: "shows sort dropdown in AppBar" — pump the app with tasks, verify `find.byType(PopupMenuButton)` findsOneWidget
- Test: "shows AppBar with title" — verify `find.text('Ubersicht')` findsOneWidget (the tabHome l10n string)
- Verify all existing tests still pass. The addition of an AppBar wrapping the existing content should not break existing assertions since they look for specific widgets/text within the tree.
2. Run full test suite to confirm no regressions.
cd /home/jlmak/Projects/jlmak/HouseHoldKeaper && flutter test && flutter analyze --no-fatal-infos
Home screen tests verify AppBar with sort dropdown is present. All 108+ tests pass (106 existing + 2+ new). dart analyze clean.
- `flutter test` — all tests pass including new sort dropdown tests
- `flutter analyze --no-fatal-infos` — zero issues
- HomeScreen has AppBar with SortDropdown visible
- TaskListScreen has SortDropdown in AppBar actions
- Tapping dropdown shows 3 options with check mark on current selection
- Selecting a different sort option reorders the task list reactively
<success_criteria>
- SortDropdown widget is reusable and shows current sort with icon
- HomeScreen has AppBar titled "Ubersicht" with SortDropdown in trailing actions
- TaskListScreen has SortDropdown before edit/delete buttons in AppBar
- Sort selection updates task list order immediately (reactive via provider)
- Sort preference persists (set in one screen, visible in another after navigation)
- All tests pass, analyze clean </success_criteria>