13 KiB
13 KiB
phase, plan, type, wave, depends_on, files_modified, autonomous, requirements, must_haves
| phase | plan | type | wave | depends_on | files_modified | autonomous | requirements | must_haves | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 07-task-sorting | 01 | execute | 1 |
|
true |
|
|
Purpose: Establishes the data layer and sort logic so that task lists react to sort preference changes. The UI plan (07-02) will add the dropdown widget that writes to this provider.
Output: TaskSortOption enum, SortPreferenceNotifier, updated calendarDayProvider and tasksInRoomProvider with in-memory sorting, German localization strings for sort labels.
<execution_context> @/home/jlmak/.claude/get-shit-done/workflows/execute-plan.md @/home/jlmak/.claude/get-shit-done/templates/summary.md </execution_context>
@.planning/PROJECT.md @.planning/ROADMAP.md @.planning/STATE.md @.planning/phases/07-task-sorting/07-CONTEXT.mdFrom lib/features/tasks/domain/effort_level.dart:
enum EffortLevel {
low, // 0
medium, // 1
high, // 2
}
From lib/features/tasks/domain/frequency.dart:
enum IntervalType {
daily, // 0
everyNDays, // 1
weekly, // 2
biweekly, // 3
monthly, // 4
everyNMonths, // 5
quarterly, // 6
yearly, // 7
}
From lib/features/home/domain/daily_plan_models.dart:
class TaskWithRoom {
final Task task;
final String roomName;
final int roomId;
}
From lib/features/home/domain/calendar_models.dart:
class CalendarDayState {
final DateTime selectedDate;
final List<TaskWithRoom> dayTasks;
final List<TaskWithRoom> overdueTasks;
final int totalTaskCount;
}
From lib/core/theme/theme_provider.dart (pattern to follow for SharedPreferences notifier):
@riverpod
class ThemeNotifier extends _$ThemeNotifier {
@override
ThemeMode build() {
_loadPersistedThemeMode();
return ThemeMode.system; // sync default, async load overrides
}
Future<void> _loadPersistedThemeMode() async { ... }
Future<void> setThemeMode(ThemeMode mode) async {
state = mode;
final prefs = await SharedPreferences.getInstance();
await prefs.setString(_themeModeKey, _themeModeToString(mode));
}
}
From lib/features/home/presentation/calendar_providers.dart:
final calendarDayProvider = StreamProvider.autoDispose<CalendarDayState>((ref) {
final db = ref.watch(appDatabaseProvider);
final selectedDate = ref.watch(selectedDateProvider);
// ... fetches dayTasks, overdueTasks, totalTaskCount
// dayTasks come from watchTasksForDate which sorts alphabetically in SQL
});
From lib/features/tasks/presentation/task_providers.dart:
final tasksInRoomProvider = StreamProvider.family.autoDispose<List<Task>, int>((ref, roomId) {
final db = ref.watch(appDatabaseProvider);
return db.tasksDao.watchTasksInRoom(roomId);
// watchTasksInRoom sorts by nextDueDate in SQL
});
From lib/core/database/database.dart (Task table columns relevant to sorting):
class Tasks extends Table {
TextColumn get name => text().withLength(min: 1, max: 200)();
IntColumn get intervalType => intEnum<IntervalType>()();
IntColumn get intervalDays => integer().withDefault(const Constant(1))();
IntColumn get effortLevel => intEnum<EffortLevel>()();
}
2. Create `lib/features/tasks/presentation/sort_preference_notifier.dart`:
- Follow the exact ThemeNotifier pattern from `lib/core/theme/theme_provider.dart`
- `@riverpod class SortPreferenceNotifier extends _$SortPreferenceNotifier`
- `build()` returns `TaskSortOption.alphabetical` synchronously (default = alphabetical per user decision for continuity with current A-Z sort in CalendarDayList), then calls `_loadPersisted()` async
- `_loadPersisted()` reads `SharedPreferences.getString('task_sort_option')` and maps to enum
- `setSortOption(TaskSortOption option)` sets state immediately then persists string to SharedPreferences
- Static helpers `_fromString` / `_toString` for serialization (use enum .name property)
- The generated provider will be named `sortPreferenceProvider` (Riverpod 3 naming convention, consistent with themeProvider)
3. Run `dart run build_runner build --delete-conflicting-outputs` to generate `.g.dart`
4. Add localization strings to `lib/l10n/app_de.arb`:
- `"sortAlphabetical": "A\u2013Z"` (A-Z with en-dash, concise label per user decision)
- `"sortInterval": "Intervall"` (German for interval/frequency)
- `"sortEffort": "Aufwand"` (German for effort, matches existing taskFormEffortLabel context)
- `"sortLabel": "Sortierung"` (label for accessibility/semantics on the dropdown)
5. Run `flutter gen-l10n` to regenerate localization files
6. Write tests in `test/features/tasks/presentation/sort_preference_notifier_test.dart`:
- Follow the pattern from notification_settings test: `makeContainer()` helper that creates ProviderContainer, awaits `Future.delayed(Duration.zero)` for async load
- `SharedPreferences.setMockInitialValues({})` in setUp
- Test: default is alphabetical
- Test: setSortOption updates state
- Test: persisted value is loaded on restart (set mock initial values with key, verify state after load)
2. Edit `lib/features/tasks/presentation/task_providers.dart`:
- Add import for `sort_preference_notifier.dart` and `task_sort_option.dart`
- In `tasksInRoomProvider`, add `final sortOption = ref.watch(sortPreferenceProvider);`
- Map the stream to apply in-memory sorting: `return db.tasksDao.watchTasksInRoom(roomId).map((tasks) => _sortTasksRaw(tasks, sortOption));`
- Create a top-level helper `List<Task> _sortTasksRaw(List<Task> tasks, TaskSortOption sortOption)` that sorts raw Task objects (not TaskWithRoom):
- `alphabetical`: sort by `task.name.toLowerCase()`
- `interval`: sort by `task.intervalType.index`, then `task.intervalDays`
- `effort`: sort by `task.effortLevel.index`
- Returns a new sorted list (do not mutate the original)
3. Verify both providers react to sort preference changes by running existing tests (they should still pass since default sort is alphabetical and current data is already alphabetically sorted or test data is single-item).
<success_criteria>
- TaskSortOption enum exists with alphabetical, interval, effort values
- SortPreferenceNotifier persists sort preference to SharedPreferences
- Default sort is alphabetical (continuity with existing A-Z sort)
- calendarDayProvider sorts dayTasks by active sort (overdue section unsorted)
- tasksInRoomProvider sorts tasks by active sort
- All tests pass, analyze clean </success_criteria>