fix(03): revise plans based on checker feedback
This commit is contained in:
@@ -3,7 +3,7 @@ phase: 03-interaction-quality-and-completeness
|
||||
plan: 03
|
||||
type: execute
|
||||
wave: 2
|
||||
depends_on: ["03-01"]
|
||||
depends_on: ["03-01", "03-00"]
|
||||
files_modified:
|
||||
- frontend/src/components/BillsTracker.tsx
|
||||
- frontend/src/components/VariableExpenses.tsx
|
||||
@@ -171,7 +171,7 @@ From frontend/src/components/ui/skeleton.tsx:
|
||||
**Do NOT modify** the totals row or the CardHeader — only add flash state and wire callbacks.
|
||||
</action>
|
||||
<verify>
|
||||
<automated>cd /home/jean-luc-makiola/Development/projects/SimpleFinanceDash/frontend && bun run build</automated>
|
||||
<automated>cd /home/jean-luc-makiola/Development/projects/SimpleFinanceDash/frontend && bun vitest run src/components/BillsTracker.test.tsx && bun run build</automated>
|
||||
</verify>
|
||||
<done>All three tracker components have flash state, triggerFlash helper, inline style on data rows, and onSaveSuccess/onSaveError wired to InlineEditCell. Build passes.</done>
|
||||
</task>
|
||||
@@ -234,7 +234,7 @@ From frontend/src/components/ui/skeleton.tsx:
|
||||
**Note:** These skeletons show when a budget exists but has no items of that type — they serve as visual placeholders indicating the section exists. This is distinct from the DashboardPage loading skeleton (which shows before any data loads).
|
||||
</action>
|
||||
<verify>
|
||||
<automated>cd /home/jean-luc-makiola/Development/projects/SimpleFinanceDash/frontend && bun vitest run && bun run build</automated>
|
||||
<automated>cd /home/jean-luc-makiola/Development/projects/SimpleFinanceDash/frontend && bun vitest run src/components/BillsTracker.test.tsx src/pages/DashboardPage.test.tsx && bun run build</automated>
|
||||
</verify>
|
||||
<done>Dashboard loading skeleton uses palette-tinted backgrounds per section. Each tracker shows tinted skeletons when no items of its type exist. All tests pass, build succeeds.</done>
|
||||
</task>
|
||||
|
||||
Reference in New Issue
Block a user