From 00670afe4ed21270547970700aef4c980c935b46 Mon Sep 17 00:00:00 2001 From: Jean-Luc Makiola Date: Mon, 20 Apr 2026 17:16:29 +0200 Subject: [PATCH 1/2] feat(05-03): remove rounded-* and upgrade spacing on all 9 pages - DashboardPage: space-y-6->space-y-8, gap-6->gap-8 in chart grid - BudgetListPage: remove rounded-md from template toggle row - BudgetDetailPage: remove rounded-sm/md from skeleton and group headings, rounded-md from summary box, rounded-full from category dot - TemplatePage: remove rounded-sm/full/md from skeleton and group headings and category dot; gap-6->gap-8, space-y-6->space-y-8 - CategoriesPage: remove rounded-sm/full/md from skeleton and group headings; space-y-6->space-y-8 - QuickAddPage: remove rounded-full/md from skeleton items - SettingsPage: space-y-4->space-y-6 in CardContent (skeleton and live) --- src/pages/BudgetDetailPage.tsx | 10 +++++----- src/pages/BudgetListPage.tsx | 2 +- src/pages/CategoriesPage.tsx | 12 ++++++------ src/pages/DashboardPage.tsx | 4 ++-- src/pages/QuickAddPage.tsx | 4 ++-- src/pages/SettingsPage.tsx | 4 ++-- src/pages/TemplatePage.tsx | 18 +++++++++--------- 7 files changed, 27 insertions(+), 27 deletions(-) diff --git a/src/pages/BudgetDetailPage.tsx b/src/pages/BudgetDetailPage.tsx index 30f8ca2..4cc9e52 100644 --- a/src/pages/BudgetDetailPage.tsx +++ b/src/pages/BudgetDetailPage.tsx @@ -287,7 +287,7 @@ export default function BudgetDetailPage() { {[1, 2, 3].map((i) => (
-
+
{[1, 2].map((j) => ( @@ -300,7 +300,7 @@ export default function BudgetDetailPage() { ))}
))} - +
) @@ -350,7 +350,7 @@ export default function BudgetDetailPage() {
{/* Group heading */}
{t(`categories.types.${type}`)} @@ -436,7 +436,7 @@ export default function BudgetDetailPage() { })} {/* Overall totals */} -
+

{t("budgets.budgeted")}

@@ -494,7 +494,7 @@ export default function BudgetDetailPage() {
{t(`categories.types.${type}`)} diff --git a/src/pages/BudgetListPage.tsx b/src/pages/BudgetListPage.tsx index b49d635..c182b2d 100644 --- a/src/pages/BudgetListPage.tsx +++ b/src/pages/BudgetListPage.tsx @@ -240,7 +240,7 @@ export default function BudgetListPage() {
{/* Template toggle */} -
+
-
+
{[1, 2, 3].map((i) => (
-
+
{[1, 2].map((j) => (
- - + +
))}
@@ -127,11 +127,11 @@ export default function CategoriesPage() { {categories.length === 0 ? (

{t("categories.empty")}

) : ( -
+
{grouped.map(({ type, items }) => (
{t(`categories.types.${type}`)} diff --git a/src/pages/DashboardPage.tsx b/src/pages/DashboardPage.tsx index 8b350aa..db83759 100644 --- a/src/pages/DashboardPage.tsx +++ b/src/pages/DashboardPage.tsx @@ -183,7 +183,7 @@ function DashboardContent({ budgetId }: { budgetId: string }) { const carryoverIsNegative = carryover < 0 return ( -
+
{/* Summary cards */} {/* 3-column chart grid */} -
+
{t("dashboard.expenseDonut")} diff --git a/src/pages/QuickAddPage.tsx b/src/pages/QuickAddPage.tsx index 5dc9b2b..1b8ffcf 100644 --- a/src/pages/QuickAddPage.tsx +++ b/src/pages/QuickAddPage.tsx @@ -95,9 +95,9 @@ export default function QuickAddPage() {
{[1, 2, 3, 4, 5].map((i) => (
- + - +
))}
diff --git a/src/pages/SettingsPage.tsx b/src/pages/SettingsPage.tsx index 7531d07..72a8fce 100644 --- a/src/pages/SettingsPage.tsx +++ b/src/pages/SettingsPage.tsx @@ -66,7 +66,7 @@ export default function SettingsPage() {
- + {[1, 2, 3].map((i) => (
@@ -84,7 +84,7 @@ export default function SettingsPage() {
- +
+
-
+
{[1, 2].map((i) => (
-
+
{[1, 2, 3].map((j) => (
- + - +
))}
@@ -265,7 +265,7 @@ export default function TemplatePage() { ) return ( -
+
{/* Header — mirrors PageShell's flex items-start justify-between gap-4 layout */}
{t("template.empty")}

) : ( -
+
{grouped.map(({ type, items: groupItems }) => (
{/* Group heading */}
{t(`categories.types.${type}`)} @@ -382,7 +382,7 @@ export default function TemplatePage() {
{t(`categories.types.${type}`)} From c3b50c70a8b16a38b3e1b1c3d38b65bba96e1c3d Mon Sep 17 00:00:00 2001 From: Jean-Luc Makiola Date: Mon, 20 Apr 2026 17:17:05 +0200 Subject: [PATCH 2/2] docs(05-03): complete page rounding sweep and spacing upgrade plan --- .../05-03-SUMMARY.md | 110 ++++++++++++++++++ 1 file changed, 110 insertions(+) create mode 100644 .planning/phases/05-design-system-token-rework/05-03-SUMMARY.md diff --git a/.planning/phases/05-design-system-token-rework/05-03-SUMMARY.md b/.planning/phases/05-design-system-token-rework/05-03-SUMMARY.md new file mode 100644 index 0000000..252a5be --- /dev/null +++ b/.planning/phases/05-design-system-token-rework/05-03-SUMMARY.md @@ -0,0 +1,110 @@ +--- +phase: 05-design-system-token-rework +plan: "03" +subsystem: frontend/pages +tags: [design-system, pages, spacing, rounding, tailwind] +dependency_graph: + requires: [05-01, 05-02] + provides: [clean-pages-no-rounding, upgraded-page-spacing] + affects: [all-9-pages] +tech_stack: + added: [] + patterns: [tailwind-utility-sweep, rounding-removal, spacing-upgrade] +key_files: + modified: + - src/pages/DashboardPage.tsx + - src/pages/BudgetListPage.tsx + - src/pages/BudgetDetailPage.tsx + - src/pages/TemplatePage.tsx + - src/pages/CategoriesPage.tsx + - src/pages/QuickAddPage.tsx + - src/pages/SettingsPage.tsx +decisions: + - "LoginPage and RegisterPage required no changes: no rounded-* classes present and CardContent already uses shadcn px-6 default padding" +metrics: + duration: "129s" + completed: "2026-04-20T15:16:38Z" + tasks_completed: 2 + files_modified: 7 +--- + +# Phase 05 Plan 03: Page Rounding Sweep and Spacing Upgrade Summary + +Removed all hardcoded `rounded-*` Tailwind classes from 7 of 9 pages (2 required no changes) and upgraded section spacing throughout. Build passes cleanly with zero rounded-* remaining in src/pages/. + +## Tasks Completed + +| Task | Name | Commit | Files | +|------|------|--------|-------| +| 1 | Remove rounded-* and upgrade spacing on all 9 pages | 00670af | DashboardPage, BudgetListPage, BudgetDetailPage, TemplatePage, CategoriesPage, QuickAddPage, SettingsPage | +| 2 | Visual verification (checkpoint) | auto-approved | — | + +## Changes Per File + +**DashboardPage.tsx** +- `space-y-6` -> `space-y-8` on main content wrapper +- `gap-6` -> `gap-8` on 3-column chart grid + +**BudgetListPage.tsx** +- Removed `rounded-md` from template toggle checkbox row (`flex items-center gap-3 border p-3`) + +**BudgetDetailPage.tsx** +- Skeleton group heading: removed `rounded-sm` +- Skeleton summary box: removed `rounded-md` +- Live group heading: removed `rounded-sm` +- Overall totals summary box: removed `rounded-md` +- SelectLabel category dot: removed `rounded-full` + +**TemplatePage.tsx** +- Skeleton outer wrapper: `gap-6` -> `gap-8` +- Skeleton group heading: removed `rounded-sm` +- Skeleton badge placeholder: removed `rounded-full` +- Skeleton icon button placeholder: removed `rounded-md` +- Live outer wrapper: `gap-6` -> `gap-8` +- Live grouped items section: `space-y-6` -> `space-y-8` +- Live group heading: removed `rounded-sm` +- SelectLabel category dot: removed `rounded-full` + +**CategoriesPage.tsx** +- Skeleton group heading: removed `rounded-sm` +- Skeleton badge placeholder: removed `rounded-full` +- Skeleton icon button placeholder: removed `rounded-md` +- Skeleton section container: `space-y-6` -> `space-y-8` +- Live grouped items section: `space-y-6` -> `space-y-8` +- Live group heading: removed `rounded-sm` + +**QuickAddPage.tsx** +- Skeleton icon badge placeholder: removed `rounded-full` +- Skeleton action button placeholder: removed `rounded-md` + +**SettingsPage.tsx** +- Both `CardContent` instances (skeleton + live): `space-y-4` -> `space-y-6` + +**LoginPage.tsx / RegisterPage.tsx** +- No changes required: no `rounded-*` classes; Card rounding controlled by `--radius: 0` token cascade from 05-01 + +## Deviations from Plan + +None - plan executed exactly as written. Line number references in PATTERNS.md were accurate. + +## Checkpoint: Task 2 + +**Type:** human-verify +**Auto-approved:** Yes (autonomous wave execution) +**What was verified:** All 9 pages swept for rounded-* removal and spacing upgrade. Build passes. grep confirms zero rounded-full/sm/md/lg in src/pages/. + +## Known Stubs + +None. + +## Threat Flags + +None — pure CSS class changes in JSX, no new network surface. + +## Self-Check: PASSED + +- 7 files modified and committed at 00670af +- `bun run build` exits 0 +- `grep -rn "rounded-full\|rounded-sm\|rounded-md\|rounded-lg" src/pages/` returns no matches +- DashboardPage.tsx contains `space-y-8` and `gap-8` (verified) +- SettingsPage.tsx contains `space-y-6` in CardContent (verified, both instances)