fix(#147, #325): review round 3 - a failed moved occurrence stays at its old time, declined occurrences not copied, unlinked rows kept

This commit is contained in:
makiolaj committed 2026-11-14 01:41:31 +01:00
1 parent 0a36a6d287
commit 10208a332e
14 files changed
+98 -48

No files matched your search

+5 -5
View File
@@ -507,10 +507,10 @@ times. Its UID is derived from the series UID and the occurrence, so it is the
same in every backup, and it carries the series UID as `X-CALENDULA-OVERRIDE-OF`.
`importEvents` skips such an occurrence wherever its series already is — that
series there has the override itself — so restoring into the calendar a backup
came from adds nothing twice, while a restore into an empty one gets both. If
the standalone occurrence fails to insert, its series is held back too (counted
as not added), since inserted with the occurrence excluded it would make every
re-run skip the occurrence for good.
came from adds nothing twice, while a restore into an empty one gets both. The
standalone event also names its occurrence (`X-CALENDULA-OVERRIDE-AT`); if it
fails to insert, the series is inserted without that exclusion, so the
occurrence stays at its original time rather than vanishing for good.
Exceptions whose series isn't among the rows are left out, a cancelled
series' moved occurrences stay cancelled, and sync ids link only within their
own calendar. A file can't carry `RDATE`, so a backup treats a series that
@@ -522,7 +522,7 @@ flattened rows straight into `importEvents`, so the UID dedup makes a re-run ski
what landed before. It skips the `.ics` text: the writer pins a timed one-off to
UTC and carries no colour, visibility or `RDATE`; the direct mapping keeps them.
Attendees and organizer are never read, and cancelled events and declined
invitations are left out (an insert can't be cancelled; it would arrive live). A re-run is idempotent per
invitations are left out (a declined occurrence counts as deleted) (an insert can't be cancelled; it would arrive live). A re-run is idempotent per
snapshot: a series already in the target keeps its overrides, so an occurrence
changed since keeps its earlier copy rather than gaining a second one.