From 114db7939c07ba48a83f23f376592dab4261ad43 Mon Sep 17 00:00:00 2001 From: Jean-Luc Makiola Date: Mon, 13 Jul 2026 16:27:10 +0200 Subject: [PATCH] ci(translations): run on every PR so the required check always reports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The release/* branch protection requires the "Translations / check" status, but the workflow was path-filtered to translation resources. A code-only PR targeting a release branch never touches those, so the workflow never ran, never posted its status, and the required check stayed pending forever — permanently blocking the merge (only PRs that happened to change strings could satisfy it). Drop the path filter so it runs on every PR, mirroring the always-on `ci` job. The parity check is SDK-free and passes when the committed translations are consistent, so running it on unrelated PRs is effectively free. Co-Authored-By: Claude Opus 4.8 --- .gitea/workflows/translations.yaml | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/.gitea/workflows/translations.yaml b/.gitea/workflows/translations.yaml index 0d2e8f8..c621258 100644 --- a/.gitea/workflows/translations.yaml +++ b/.gitea/workflows/translations.yaml @@ -3,13 +3,15 @@ name: Translations # Fast, SDK-free parity check for translation resources, so Weblate PRs (which # only touch values-*/strings.xml) get quick feedback without the full Android # build. The deeper checks still run in CI via lintDebug (ExtraTranslation). +# +# Runs on every PR (no path filter) so the required "Translations / check" +# status is always reported — like the `ci` job. A path-filtered workflow is +# skipped on unrelated PRs and never posts its status, which leaves that +# required check pending forever and blocks the merge of any code-only PR into a +# release/* branch. The check itself is cheap and simply passes when the +# committed translations are consistent, so always running it costs nothing. on: pull_request: - paths: - - 'app/src/main/res/values*/strings.xml' - - 'app/src/main/res/xml/locales_config.xml' - - 'scripts/check_translations.py' - - '.gitea/workflows/translations.yaml' concurrency: group: translations-${{ github.ref }}