makiolaj/calendula
1
0
Fork 1
Code Actions Releases 35 Activity

Let the location field grow with its address (#273) (#278)

Browse Source 
The location on the edit screen was a single line, so a full postal address or a
long meeting link scrolled sideways out of view while you typed it. It now wraps
and the card grows to fit.

- The field is multi-line and animates its height; `setLocation` joins line
  breaks with `", "` rather than deleting them, so a pasted address reads as
  `12 Main St, 10115 Berlin` — the same shape `readContactAddress` has always
  produced for a contact picked from the picker — instead of running together.
- The pin and the contacts button are positioned off the resolved `titleMedium`
  line height instead of a hardcoded 32dp/4dp, so they stay level with the first
  line at large font scales too. `EditCard`'s `iconAtTop` branch was changed with
  it; otherwise the button would have scaled while the icon beside it did not.
  The values are identical to the old ones at font scale 1.0.
- The field passes `ImeAction.Done`. Without it, a multi-line field with no IME
  action turns Enter into a newline key whose every newline is then folded away —
  a dead key that only nudged the caret.

The last two points are beyond the issue itself; they came out of a review of the
first, since making the field multi-line is what put a fixed-height button next to
text that grows.

Closes #273

Co-authored-by: Jean-Luc Makiola <business@jeanlucmakiola.de>
Reviewed-on: https://codeberg.org/jlmakiola/calendula/pulls/278
This commit is contained in:
Jean-Luc Makiola
2026-09-07 17:32:27 +02:00
co-authored by makiolaj
parent 80bf96b7dc
commit 60f05a5c65
3 changed files with 87 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+10
View File
@@ -26,6 +26,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
mid-word at large font sizes. The view switcher, the title and the agenda's
range bar also line up with the grid underneath them ([#165]).
### Fixed
- **A long location no longer runs off the edge of its field.** The location on
the edit screen sat on one line, so a full postal address or a long meeting
link scrolled sideways out of sight as you typed it. It now wraps and the card
grows to fit, with the pin and the contacts button staying level with the first
line at any font size. A multi-line address you paste in is joined with commas
— the way one picked from your contacts always has been — instead of running
together into a single word ([#273]).
## [2.19.4] — 2026-09-01
### Fixed
@@ -1593,3 +1602,4 @@ automatically, with zero telemetry and no internet permission.
[#219]: https://codeberg.org/jlmakiola/calendula/issues/219
[#248]: https://codeberg.org/jlmakiola/calendula/issues/248
[#253]: https://codeberg.org/jlmakiola/calendula/issues/253
[#273]: https://codeberg.org/jlmakiola/calendula/issues/273