feat(filter,settings): calendar filter in drawer + settings (v0.5.0)

M3 — calendar filter: the navigation drawer now hosts the calendar list
inline (grouped by account, colour swatch + checkbox per calendar). Hidden
calendars are persisted app-side and filtered centrally in the repository,
so month/week/day re-filter live the moment a checkbox flips. Drawer trimmed
to Today, the calendar filter, and Settings, with leading icons and a clear
title/section type scale; the stubbed jump-to-date entry (M2) was removed.

M4 — settings: full-screen destination with appearance (theme System/Light/
Dark, Material You dynamic colour auto-disabled < API 31, week start Auto/Mon/
Sun), language (per-app locales via AppCompat, persisted to API 29), and an
about section (version, licence, source link). Theme is driven by one
activity-scoped settings source so changes apply app-wide at once. Week start
now drives the month grid and week view; Auto follows the locale.

Also:
- default view switched from month to week
- Settings screen handles system back (was closing the app)
- fix pre-existing NonObservableLocale/LocalContextConfigurationRead lint
  errors in EventDetailScreen so CI lint is green again
- versionName/versionCode bumped to 0.5.0 / 5

Tests: repository hidden-filter (incl. live re-emit), SettingsPrefs round-trip
+ week-start resolution, filter grouping. lint + unit tests + assembleDebug green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

app/src/test/java/de/jeanlucmakiola/calendula/data/calendar/CalendarRepositoryImplTest.kt

@@ -1,7 +1,11 @@
 package de.jeanlucmakiola.calendula.data.calendar
 
+import androidx.datastore.core.DataStore
+import androidx.datastore.preferences.core.PreferenceDataStoreFactory
+import androidx.datastore.preferences.core.Preferences
 import app.cash.turbine.test
 import com.google.common.truth.Truth.assertThat
+import de.jeanlucmakiola.calendula.data.prefs.CalendarPrefs
 import de.jeanlucmakiola.calendula.domain.CalendarSource
 import de.jeanlucmakiola.calendula.domain.EventInstance
 import kotlinx.coroutines.Dispatchers
@@ -10,15 +14,29 @@ import kotlinx.coroutines.test.UnconfinedTestDispatcher
 import kotlinx.coroutines.test.runTest
 import kotlin.time.Instant
 import org.junit.jupiter.api.Test
+import org.junit.jupiter.api.io.TempDir
+import java.nio.file.Path
 
 @OptIn(ExperimentalCoroutinesApi::class)
 class CalendarRepositoryImplTest {
 
+    private fun newPrefs(tempDir: Path): CalendarPrefs =
+        CalendarPrefs(newDataStore(tempDir))
+
+    private fun newDataStore(tempDir: Path): DataStore<Preferences> =
+        PreferenceDataStoreFactory.create(
+            produceFile = { tempDir.resolve("repo_test_prefs.preferences_pb").toFile() },
+        )
+
     private fun makeCal(id: Long, name: String = "Cal $id"): CalendarSource =
         CalendarSource(id, name, "x@y", "LOCAL", 0xFF112233.toInt(), true)
 
-    private fun makeEvent(id: Long, title: String = "E $id"): EventInstance = EventInstance(
-        instanceId = id, eventId = id, calendarId = 1L,
+    private fun makeEvent(
+        id: Long,
+        title: String = "E $id",
+        calendarId: Long = 1L,
+    ): EventInstance = EventInstance(
+        instanceId = id, eventId = id, calendarId = calendarId,
         title = title,
         start = Instant.fromEpochMilliseconds(1_000_000_000L),
         end = Instant.fromEpochMilliseconds(1_000_003_600L),
@@ -26,11 +44,11 @@ class CalendarRepositoryImplTest {
     )
 
     @Test
-    fun `calendars emits initial query result on subscribe`() = runTest {
+    fun `calendars emits initial query result on subscribe`(@TempDir tempDir: Path) = runTest {
         val fake = FakeCalendarDataSource().apply {
             calendarsResult = listOf(makeCal(1L), makeCal(2L))
         }
-        val repo = CalendarRepositoryImpl(fake, UnconfinedTestDispatcher(testScheduler))
+        val repo = CalendarRepositoryImpl(fake, newPrefs(tempDir), UnconfinedTestDispatcher(testScheduler))
 
         repo.calendars().test {
             val first = awaitItem()
@@ -40,11 +58,11 @@ class CalendarRepositoryImplTest {
     }
 
     @Test
-    fun `calendars re-emits after change listener tick`() = runTest {
+    fun `calendars re-emits after change listener tick`(@TempDir tempDir: Path) = runTest {
         val fake = FakeCalendarDataSource().apply {
             calendarsResult = listOf(makeCal(1L))
         }
-        val repo = CalendarRepositoryImpl(fake, UnconfinedTestDispatcher(testScheduler))
+        val repo = CalendarRepositoryImpl(fake, newPrefs(tempDir), UnconfinedTestDispatcher(testScheduler))
 
         repo.calendars().test {
             assertThat(awaitItem().map { it.id }).containsExactly(1L)
@@ -58,7 +76,7 @@ class CalendarRepositoryImplTest {
     }
 
     @Test
-    fun `instances forwards epoch-millis bounds to data source`() = runTest {
+    fun `instances forwards epoch-millis bounds to data source`(@TempDir tempDir: Path) = runTest {
         var observedBegin: Long? = null
         var observedEnd: Long? = null
         val fake = FakeCalendarDataSource().apply {
@@ -68,7 +86,7 @@ class CalendarRepositoryImplTest {
                 listOf(makeEvent(10L))
             }
         }
-        val repo = CalendarRepositoryImpl(fake, UnconfinedTestDispatcher(testScheduler))
+        val repo = CalendarRepositoryImpl(fake, newPrefs(tempDir), UnconfinedTestDispatcher(testScheduler))
 
         val range = Instant.fromEpochMilliseconds(1_000L)..Instant.fromEpochMilliseconds(2_000L)
         repo.instances(range).test {
@@ -80,11 +98,11 @@ class CalendarRepositoryImplTest {
     }
 
     @Test
-    fun `instances passes-through whatever the data source returns`() = runTest {
+    fun `instances passes-through whatever the data source returns`(@TempDir tempDir: Path) = runTest {
         val fake = FakeCalendarDataSource().apply {
             instancesResult = {_, _ -> listOf(makeEvent(10L, "Good")) }
         }
-        val repo = CalendarRepositoryImpl(fake, UnconfinedTestDispatcher(testScheduler))
+        val repo = CalendarRepositoryImpl(fake, newPrefs(tempDir), UnconfinedTestDispatcher(testScheduler))
 
         val range = Instant.fromEpochMilliseconds(0)..Instant.fromEpochMilliseconds(10_000L)
         repo.instances(range).test {
@@ -95,11 +113,56 @@ class CalendarRepositoryImplTest {
     }
 
     @Test
-    fun `eventDetail throws NoSuchEventException when data source returns null`() = runTest {
+    fun `instances drops events whose calendar the user hid`(@TempDir tempDir: Path) = runTest {
+        val prefs = newPrefs(tempDir)
+        prefs.setHiddenCalendarIds(setOf(2L))
+        val fake = FakeCalendarDataSource().apply {
+            instancesResult = { _, _ ->
+                listOf(
+                    makeEvent(10L, "Visible", calendarId = 1L),
+                    makeEvent(11L, "Hidden", calendarId = 2L),
+                )
+            }
+        }
+        val repo = CalendarRepositoryImpl(fake, prefs, UnconfinedTestDispatcher(testScheduler))
+
+        val range = Instant.fromEpochMilliseconds(0)..Instant.fromEpochMilliseconds(10_000L)
+        repo.instances(range).test {
+            assertThat(awaitItem().map { it.title }).containsExactly("Visible")
+            cancelAndIgnoreRemainingEvents()
+        }
+    }
+
+    @Test
+    fun `instances re-emits when the hidden set changes`(@TempDir tempDir: Path) = runTest {
+        val prefs = newPrefs(tempDir)
+        val fake = FakeCalendarDataSource().apply {
+            instancesResult = { _, _ ->
+                listOf(
+                    makeEvent(10L, "A", calendarId = 1L),
+                    makeEvent(11L, "B", calendarId = 2L),
+                )
+            }
+        }
+        val repo = CalendarRepositoryImpl(fake, prefs, UnconfinedTestDispatcher(testScheduler))
+
+        val range = Instant.fromEpochMilliseconds(0)..Instant.fromEpochMilliseconds(10_000L)
+        repo.instances(range).test {
+            assertThat(awaitItem().map { it.title }).containsExactly("A", "B").inOrder()
+
+            prefs.setHiddenCalendarIds(setOf(2L))
+
+            assertThat(awaitItem().map { it.title }).containsExactly("A")
+            cancelAndIgnoreRemainingEvents()
+        }
+    }
+
+    @Test
+    fun `eventDetail throws NoSuchEventException when data source returns null`(@TempDir tempDir: Path) = runTest {
         val fake = FakeCalendarDataSource().apply {
             eventDetailResult = { null }
         }
-        val repo = CalendarRepositoryImpl(fake, Dispatchers.Unconfined)
+        val repo = CalendarRepositoryImpl(fake, newPrefs(tempDir), Dispatchers.Unconfined)
 
         try {
             repo.eventDetail(eventId = 999L)

app/src/test/java/de/jeanlucmakiola/calendula/data/prefs/SettingsPrefsTest.kt

@@ -0,0 +1,74 @@
+package de.jeanlucmakiola.calendula.data.prefs
+
+import androidx.datastore.core.DataStore
+import androidx.datastore.preferences.core.PreferenceDataStoreFactory
+import androidx.datastore.preferences.core.Preferences
+import com.google.common.truth.Truth.assertThat
+import kotlinx.coroutines.flow.first
+import kotlinx.coroutines.test.runTest
+import kotlinx.datetime.DayOfWeek
+import org.junit.jupiter.api.Test
+import org.junit.jupiter.api.io.TempDir
+import java.nio.file.Path
+import java.util.Locale
+
+class SettingsPrefsTest {
+
+    private fun newDataStore(tempDir: Path): DataStore<Preferences> =
+        PreferenceDataStoreFactory.create(
+            produceFile = { tempDir.resolve("settings_test.preferences_pb").toFile() },
+        )
+
+    @Test
+    fun `defaults are system theme, dynamic colour on, auto week start`(@TempDir tempDir: Path) = runTest {
+        val prefs = SettingsPrefs(newDataStore(tempDir))
+        assertThat(prefs.themeMode.first()).isEqualTo(ThemeMode.SYSTEM)
+        assertThat(prefs.dynamicColor.first()).isTrue()
+        assertThat(prefs.weekStart.first()).isEqualTo(WeekStartPref.AUTO)
+    }
+
+    @Test
+    fun `theme mode round-trips`(@TempDir tempDir: Path) = runTest {
+        val prefs = SettingsPrefs(newDataStore(tempDir))
+        prefs.setThemeMode(ThemeMode.DARK)
+        assertThat(prefs.themeMode.first()).isEqualTo(ThemeMode.DARK)
+    }
+
+    @Test
+    fun `dynamic colour round-trips`(@TempDir tempDir: Path) = runTest {
+        val prefs = SettingsPrefs(newDataStore(tempDir))
+        prefs.setDynamicColor(false)
+        assertThat(prefs.dynamicColor.first()).isFalse()
+    }
+
+    @Test
+    fun `week start round-trips`(@TempDir tempDir: Path) = runTest {
+        val prefs = SettingsPrefs(newDataStore(tempDir))
+        prefs.setWeekStart(WeekStartPref.SUNDAY)
+        assertThat(prefs.weekStart.first()).isEqualTo(WeekStartPref.SUNDAY)
+    }
+
+    @Test
+    fun `garbage stored enum falls back to default`(@TempDir tempDir: Path) = runTest {
+        val store = newDataStore(tempDir)
+        val prefs = SettingsPrefs(store)
+        store.updateData { p ->
+            val m = p.toMutablePreferences()
+            m[SettingsPrefs.THEME_MODE_KEY] = "PLAID"
+            m
+        }
+        assertThat(prefs.themeMode.first()).isEqualTo(ThemeMode.SYSTEM)
+    }
+
+    @Test
+    fun `explicit week-start prefs resolve regardless of locale`() {
+        assertThat(WeekStartPref.MONDAY.resolveFirstDay(Locale.US)).isEqualTo(DayOfWeek.MONDAY)
+        assertThat(WeekStartPref.SUNDAY.resolveFirstDay(Locale.GERMANY)).isEqualTo(DayOfWeek.SUNDAY)
+    }
+
+    @Test
+    fun `auto week start follows the locale convention`() {
+        assertThat(WeekStartPref.AUTO.resolveFirstDay(Locale.GERMANY)).isEqualTo(DayOfWeek.MONDAY)
+        assertThat(WeekStartPref.AUTO.resolveFirstDay(Locale.US)).isEqualTo(DayOfWeek.SUNDAY)
+    }
+}

app/src/test/java/de/jeanlucmakiola/calendula/ui/filter/FilterGroupingTest.kt

@@ -0,0 +1,61 @@
+package de.jeanlucmakiola.calendula.ui.filter
+
+import com.google.common.truth.Truth.assertThat
+import de.jeanlucmakiola.calendula.domain.CalendarSource
+import org.junit.jupiter.api.Test
+
+class FilterGroupingTest {
+
+    private fun cal(
+        id: Long,
+        name: String,
+        account: String,
+        type: String = "com.example",
+    ) = CalendarSource(
+        id = id,
+        displayName = name,
+        accountName = account,
+        accountType = type,
+        color = 0xFF336699.toInt(),
+        isVisibleInSystem = true,
+    )
+
+    @Test
+    fun `groups calendars under their account, preserving order`() {
+        val calendars = listOf(
+            cal(1, "Personal", "alice@dav"),
+            cal(2, "Work", "alice@dav"),
+            cal(3, "Shared", "team@dav"),
+        )
+
+        val groups = groupByAccount(calendars, hidden = emptySet())
+
+        assertThat(groups.map { it.account }).containsExactly("alice@dav", "team@dav").inOrder()
+        assertThat(groups[0].calendars.map { it.displayName })
+            .containsExactly("Personal", "Work").inOrder()
+        assertThat(groups[1].calendars.map { it.id }).containsExactly(3L)
+    }
+
+    @Test
+    fun `hidden ids mark calendars not visible`() {
+        val calendars = listOf(
+            cal(1, "Personal", "alice@dav"),
+            cal(2, "Work", "alice@dav"),
+        )
+
+        val groups = groupByAccount(calendars, hidden = setOf(2L))
+        val rows = groups.single().calendars.associateBy { it.id }
+
+        assertThat(rows.getValue(1L).visible).isTrue()
+        assertThat(rows.getValue(2L).visible).isFalse()
+    }
+
+    @Test
+    fun `blank account name falls back to type`() {
+        val groups = groupByAccount(
+            listOf(cal(1, "Birthdays", account = "", type = "LOCAL")),
+            hidden = emptySet(),
+        )
+        assertThat(groups.single().account).isEqualTo("LOCAL")
+    }
+}