From e5a5c10dea1ccc034917b80261e63e103d654783 Mon Sep 17 00:00:00 2001 From: Jean-Luc Makiola Date: Mon, 16 Nov 2026 20:43:43 +0100 Subject: [PATCH] fix(#464): an Open link button for reminders whose location is a web link --- app/src/main/AndroidManifest.xml | 11 ++++++++ .../data/reminders/ReminderNotifier.kt | 25 ++++++++++++++++++- .../domain/reminders/ReminderMapQuery.kt | 4 +++ .../res/drawable/ic_notification_link.xml | 12 +++++++++ app/src/main/res/values/strings.xml | 2 ++ .../domain/reminders/ReminderMapQueryTest.kt | 14 +++++++++++ 6 files changed, 67 insertions(+), 1 deletion(-) create mode 100644 app/src/main/res/drawable/ic_notification_link.xml diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index b272d8e9..75f7c79b 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -56,6 +56,17 @@ + + + + + + + + + + + ') } diff --git a/app/src/main/res/drawable/ic_notification_link.xml b/app/src/main/res/drawable/ic_notification_link.xml new file mode 100644 index 00000000..19b21a7b --- /dev/null +++ b/app/src/main/res/drawable/ic_notification_link.xml @@ -0,0 +1,12 @@ + + + + + diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 278cc7ca..a0d32bb2 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -231,6 +231,8 @@ Title Location Open in maps + + Open link No app can open this link Description Attendees diff --git a/app/src/test/java/de/jeanlucmakiola/calendula/domain/reminders/ReminderMapQueryTest.kt b/app/src/test/java/de/jeanlucmakiola/calendula/domain/reminders/ReminderMapQueryTest.kt index 378148e7..7368969c 100644 --- a/app/src/test/java/de/jeanlucmakiola/calendula/domain/reminders/ReminderMapQueryTest.kt +++ b/app/src/test/java/de/jeanlucmakiola/calendula/domain/reminders/ReminderMapQueryTest.kt @@ -34,4 +34,18 @@ class ReminderMapQueryTest { fun `a place with a link beside it is still looked up`() { assertThat(reminderMapQuery("Room 4, https://example.com/map")).isEqualTo("Room 4, https://example.com/map") } + + @Test + fun `the first web link is the reminder's link`() { + assertThat(reminderLink("https://meet.google.com/abc-defg-hij")).isEqualTo("https://meet.google.com/abc-defg-hij") + assertThat(reminderLink("")).isEqualTo("https://teams.microsoft.com/l/meetup-join/x") + assertThat(reminderLink("Room 4, https://example.com/map.")).isEqualTo("https://example.com/map") + assertThat(reminderLink("https://a.example\nhttps://b.example")).isEqualTo("https://a.example") + } + + @Test + fun `no link without one`() { + assertThat(reminderLink(null)).isNull() + assertThat(reminderLink("Hauptstr. 12/3, Wien")).isNull() + } }