Compare commits
2 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| bdedf47972 | |||
| a69be3da43 |
@@ -63,6 +63,7 @@ guide here, not a contract — scope per slice is decided as we go.
|
|||||||
|---|---|---|
|
|---|---|---|
|
||||||
| v1.1 | Write foundation — `WRITE_CALENDAR`, read-only-calendar detection, delete (series + single occurrence) | complete (shipped 2026-06-11) |
|
| v1.1 | Write foundation — `WRITE_CALENDAR`, read-only-calendar detection, delete (series + single occurrence) | complete (shipped 2026-06-11) |
|
||||||
| v1.2 | Create event — form, FAB, last-used-calendar preselect | complete (shipped 2026-06-11) |
|
| v1.2 | Create event — form, FAB, last-used-calendar preselect | complete (shipped 2026-06-11) |
|
||||||
|
| v1.2.1 | Form polish after on-device review — card design system, optional fields + settings defaults, OptionCard dialogs, expressive motion | complete (shipped 2026-06-11) |
|
||||||
| v1.3 | Edit event — shared form, series edit, reminders, simple recurrence picker | planned |
|
| v1.3 | Edit event — shared form, series edit, reminders, simple recurrence picker | planned |
|
||||||
| v2.0 | Quick-add, occurrence edit, conflict dialog, polish, release | planned |
|
| v2.0 | Quick-add, occurrence edit, conflict dialog, polish, release | planned |
|
||||||
|
|
||||||
|
|||||||
@@ -5,10 +5,11 @@
|
|||||||
## Status
|
## Status
|
||||||
|
|
||||||
**Milestone:** v2.0 — Write support (milestone 2, in progress)
|
**Milestone:** v2.0 — Write support (milestone 2, in progress)
|
||||||
**Phase:** v1.2.0 shipped 2026-06-11 (create event), after v1.1.0 the same
|
**Phase:** v1.2.1 shipped 2026-06-11 — the create-form polish pass after
|
||||||
day (write foundation + delete). Milestone 2 runs in four slices
|
Jean-Luc's on-device review (v1.2.0 and v1.1.0 shipped the same day).
|
||||||
|
Milestone 2 runs in four slices
|
||||||
(`docs/superpowers/plans/2026-06-11-03-write-support.md`); next up is v1.3
|
(`docs/superpowers/plans/2026-06-11-03-write-support.md`); next up is v1.3
|
||||||
(edit event).
|
(edit event). Note: UI slices now hold release until his explicit approval.
|
||||||
|
|
||||||
## Progress
|
## Progress
|
||||||
|
|
||||||
|
|||||||
34
CHANGELOG.md
34
CHANGELOG.md
@@ -7,6 +7,40 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
|||||||
|
|
||||||
## [Unreleased]
|
## [Unreleased]
|
||||||
|
|
||||||
|
## [1.2.1] — 2026-06-11
|
||||||
|
|
||||||
|
### Added
|
||||||
|
- Optional event-form fields with user-controlled defaults: reminders,
|
||||||
|
availability (busy/free), and visibility (default/public/private/
|
||||||
|
confidential) joined location and description as form sections. Settings
|
||||||
|
gained a "New event form" section choosing which show by default; the rest
|
||||||
|
unfold via a "More fields" picker
|
||||||
|
- Reminders editor: stacked rows with right-bound remove, full-width add
|
||||||
|
action; the picker offers one-tap presets and a custom amount + unit
|
||||||
|
(minutes/hours/days/weeks) step
|
||||||
|
- `OptionCard` — the app's standard selection-dialog row (full-width tonal
|
||||||
|
card, optional icon + supporting line, highlighted selection). All dialogs
|
||||||
|
(calendar, visibility, more-fields, reminder presets, recurring-delete)
|
||||||
|
now use it; radio-row dialogs are retired
|
||||||
|
|
||||||
|
### Changed
|
||||||
|
- Event form redesigned onto the detail screen's design system: tonal cards
|
||||||
|
with gutter icons (top-aligned on tall cards), borderless inline text
|
||||||
|
fields, calendar-coloured accent bar under the title, no dividers, no
|
||||||
|
top-bar title; placeholders render clearly fainter than input
|
||||||
|
- M3 Expressive motion: the theme now provides a MotionScheme
|
||||||
|
(`MaterialExpressiveTheme`, standard springs — expressive bounce reviewed
|
||||||
|
as overdone), the FAB stack and "more fields" reveals animate on theme
|
||||||
|
springs
|
||||||
|
- The jump-to-today slide is direction-aware (future → today slides in from
|
||||||
|
the left, past → from the right)
|
||||||
|
- `versionName`/`versionCode` bumped to 1.2.1 / 10
|
||||||
|
|
||||||
|
### Fixed
|
||||||
|
- The keyboard no longer pans the whole event form; the screen stays
|
||||||
|
anchored and the focused field scrolls into view (`adjustResize` +
|
||||||
|
`imePadding`)
|
||||||
|
|
||||||
## [1.2.0] — 2026-06-11
|
## [1.2.0] — 2026-06-11
|
||||||
|
|
||||||
### Added
|
### Added
|
||||||
|
|||||||
@@ -23,8 +23,8 @@ android {
|
|||||||
applicationId = "de.jeanlucmakiola.calendula"
|
applicationId = "de.jeanlucmakiola.calendula"
|
||||||
minSdk = 29
|
minSdk = 29
|
||||||
targetSdk = 36
|
targetSdk = 36
|
||||||
versionCode = 9
|
versionCode = 10
|
||||||
versionName = "1.2.0"
|
versionName = "1.2.1"
|
||||||
|
|
||||||
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
|
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -18,7 +18,8 @@
|
|||||||
tools:targetApi="35">
|
tools:targetApi="35">
|
||||||
<activity
|
<activity
|
||||||
android:name=".MainActivity"
|
android:name=".MainActivity"
|
||||||
android:exported="true">
|
android:exported="true"
|
||||||
|
android:windowSoftInputMode="adjustResize">
|
||||||
<intent-filter>
|
<intent-filter>
|
||||||
<action android:name="android.intent.action.MAIN" />
|
<action android:name="android.intent.action.MAIN" />
|
||||||
<category android:name="android.intent.category.LAUNCHER" />
|
<category android:name="android.intent.category.LAUNCHER" />
|
||||||
|
|||||||
@@ -9,6 +9,7 @@ import android.database.Cursor
|
|||||||
import android.os.Handler
|
import android.os.Handler
|
||||||
import android.os.Looper
|
import android.os.Looper
|
||||||
import android.provider.CalendarContract
|
import android.provider.CalendarContract
|
||||||
|
import android.util.Log
|
||||||
import dagger.hilt.android.qualifiers.ApplicationContext
|
import dagger.hilt.android.qualifiers.ApplicationContext
|
||||||
import de.jeanlucmakiola.calendula.domain.Attendee
|
import de.jeanlucmakiola.calendula.domain.Attendee
|
||||||
import de.jeanlucmakiola.calendula.domain.CalendarSource
|
import de.jeanlucmakiola.calendula.domain.CalendarSource
|
||||||
@@ -102,6 +103,8 @@ class AndroidCalendarDataSource @Inject constructor(
|
|||||||
put(CalendarContract.Events.DTSTART, times.dtStartMillis)
|
put(CalendarContract.Events.DTSTART, times.dtStartMillis)
|
||||||
put(CalendarContract.Events.DTEND, times.dtEndMillis)
|
put(CalendarContract.Events.DTEND, times.dtEndMillis)
|
||||||
put(CalendarContract.Events.EVENT_TIMEZONE, times.timezone)
|
put(CalendarContract.Events.EVENT_TIMEZONE, times.timezone)
|
||||||
|
put(CalendarContract.Events.AVAILABILITY, form.availability.toProviderValue())
|
||||||
|
put(CalendarContract.Events.ACCESS_LEVEL, form.accessLevel.toProviderValue())
|
||||||
form.location.trim().takeIf { it.isNotEmpty() }
|
form.location.trim().takeIf { it.isNotEmpty() }
|
||||||
?.let { put(CalendarContract.Events.EVENT_LOCATION, it) }
|
?.let { put(CalendarContract.Events.EVENT_LOCATION, it) }
|
||||||
form.description.trim().takeIf { it.isNotEmpty() }
|
form.description.trim().takeIf { it.isNotEmpty() }
|
||||||
@@ -109,7 +112,20 @@ class AndroidCalendarDataSource @Inject constructor(
|
|||||||
}
|
}
|
||||||
val uri = resolver.insert(CalendarContract.Events.CONTENT_URI, values)
|
val uri = resolver.insert(CalendarContract.Events.CONTENT_URI, values)
|
||||||
?: throw WriteFailedException("insert event into calendar id=${form.calendarId}")
|
?: throw WriteFailedException("insert event into calendar id=${form.calendarId}")
|
||||||
return ContentUris.parseId(uri)
|
val eventId = ContentUris.parseId(uri)
|
||||||
|
// Best effort (spec §8): the event exists at this point — a reminder
|
||||||
|
// that fails to attach is logged, not surfaced as a failed create.
|
||||||
|
form.reminders.distinct().forEach { minutes ->
|
||||||
|
val reminder = ContentValues().apply {
|
||||||
|
put(CalendarContract.Reminders.EVENT_ID, eventId)
|
||||||
|
put(CalendarContract.Reminders.MINUTES, minutes)
|
||||||
|
put(CalendarContract.Reminders.METHOD, CalendarContract.Reminders.METHOD_ALERT)
|
||||||
|
}
|
||||||
|
if (resolver.insert(CalendarContract.Reminders.CONTENT_URI, reminder) == null) {
|
||||||
|
Log.w(TAG, "Failed to attach reminder ($minutes min) to event $eventId")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return eventId
|
||||||
}
|
}
|
||||||
|
|
||||||
override fun deleteEvent(eventId: Long) {
|
override fun deleteEvent(eventId: Long) {
|
||||||
@@ -179,4 +195,8 @@ class AndroidCalendarDataSource @Inject constructor(
|
|||||||
private inline fun <T : Any> Cursor.mapAllNotNull(mapper: (Cursor) -> T?): List<T> = buildList {
|
private inline fun <T : Any> Cursor.mapAllNotNull(mapper: (Cursor) -> T?): List<T> = buildList {
|
||||||
while (moveToNext()) mapper(this@mapAllNotNull)?.let(::add)
|
while (moveToNext()) mapper(this@mapAllNotNull)?.let(::add)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private companion object {
|
||||||
|
const val TAG = "CalendarDataSource"
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,5 +1,8 @@
|
|||||||
package de.jeanlucmakiola.calendula.data.calendar
|
package de.jeanlucmakiola.calendula.data.calendar
|
||||||
|
|
||||||
|
import android.provider.CalendarContract
|
||||||
|
import de.jeanlucmakiola.calendula.domain.AccessLevel
|
||||||
|
import de.jeanlucmakiola.calendula.domain.Availability
|
||||||
import de.jeanlucmakiola.calendula.domain.EventForm
|
import de.jeanlucmakiola.calendula.domain.EventForm
|
||||||
import kotlinx.datetime.toJavaLocalDate
|
import kotlinx.datetime.toJavaLocalDate
|
||||||
import kotlinx.datetime.toJavaLocalDateTime
|
import kotlinx.datetime.toJavaLocalDateTime
|
||||||
@@ -33,3 +36,16 @@ internal fun EventForm.toWriteTimes(zone: ZoneId): EventWriteTimes = if (isAllDa
|
|||||||
timezone = zone.id,
|
timezone = zone.id,
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
internal fun Availability.toProviderValue(): Int = when (this) {
|
||||||
|
Availability.Busy -> CalendarContract.Events.AVAILABILITY_BUSY
|
||||||
|
Availability.Free -> CalendarContract.Events.AVAILABILITY_FREE
|
||||||
|
Availability.Tentative -> CalendarContract.Events.AVAILABILITY_TENTATIVE
|
||||||
|
}
|
||||||
|
|
||||||
|
internal fun AccessLevel.toProviderValue(): Int = when (this) {
|
||||||
|
AccessLevel.Default -> CalendarContract.Events.ACCESS_DEFAULT
|
||||||
|
AccessLevel.Confidential -> CalendarContract.Events.ACCESS_CONFIDENTIAL
|
||||||
|
AccessLevel.Private -> CalendarContract.Events.ACCESS_PRIVATE
|
||||||
|
AccessLevel.Public -> CalendarContract.Events.ACCESS_PUBLIC
|
||||||
|
}
|
||||||
|
|||||||
@@ -5,6 +5,7 @@ import androidx.datastore.preferences.core.Preferences
|
|||||||
import androidx.datastore.preferences.core.booleanPreferencesKey
|
import androidx.datastore.preferences.core.booleanPreferencesKey
|
||||||
import androidx.datastore.preferences.core.edit
|
import androidx.datastore.preferences.core.edit
|
||||||
import androidx.datastore.preferences.core.stringPreferencesKey
|
import androidx.datastore.preferences.core.stringPreferencesKey
|
||||||
|
import de.jeanlucmakiola.calendula.domain.EventFormField
|
||||||
import kotlinx.coroutines.flow.Flow
|
import kotlinx.coroutines.flow.Flow
|
||||||
import kotlinx.coroutines.flow.map
|
import kotlinx.coroutines.flow.map
|
||||||
import kotlinx.datetime.DayOfWeek
|
import kotlinx.datetime.DayOfWeek
|
||||||
@@ -67,10 +68,38 @@ class SettingsPrefs @Inject constructor(
|
|||||||
store.edit { it[WEEK_START_KEY] = pref.name }
|
store.edit { it[WEEK_START_KEY] = pref.name }
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Optional event-form fields shown by default (the rest hide behind
|
||||||
|
* "more fields"). Stored comma-joined by enum name: an absent key means
|
||||||
|
* the factory default, an empty string means "none". Unknown names are
|
||||||
|
* dropped defensively, like the other enum prefs.
|
||||||
|
*/
|
||||||
|
val defaultFormFields: Flow<Set<EventFormField>> = store.data.map { prefs ->
|
||||||
|
parseFormFields(prefs[FORM_FIELDS_KEY])
|
||||||
|
}
|
||||||
|
|
||||||
|
suspend fun setFormFieldDefault(field: EventFormField, enabled: Boolean) {
|
||||||
|
store.edit { prefs ->
|
||||||
|
val current = parseFormFields(prefs[FORM_FIELDS_KEY])
|
||||||
|
val updated = if (enabled) current + field else current - field
|
||||||
|
prefs[FORM_FIELDS_KEY] = updated.joinToString(",") { it.name }
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
private fun parseFormFields(stored: String?): Set<EventFormField> = when (stored) {
|
||||||
|
null -> DEFAULT_FORM_FIELDS
|
||||||
|
else -> stored.split(',')
|
||||||
|
.mapNotNull { name -> EventFormField.entries.firstOrNull { it.name == name.trim() } }
|
||||||
|
.toSet()
|
||||||
|
}
|
||||||
|
|
||||||
companion object {
|
companion object {
|
||||||
internal val THEME_MODE_KEY = stringPreferencesKey("theme_mode")
|
internal val THEME_MODE_KEY = stringPreferencesKey("theme_mode")
|
||||||
internal val DYNAMIC_COLOR_KEY = booleanPreferencesKey("dynamic_color")
|
internal val DYNAMIC_COLOR_KEY = booleanPreferencesKey("dynamic_color")
|
||||||
internal val WEEK_START_KEY = stringPreferencesKey("week_start")
|
internal val WEEK_START_KEY = stringPreferencesKey("week_start")
|
||||||
|
internal val FORM_FIELDS_KEY = stringPreferencesKey("event_form_default_fields")
|
||||||
|
internal val DEFAULT_FORM_FIELDS =
|
||||||
|
setOf(EventFormField.Location, EventFormField.Description)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -15,8 +15,24 @@ data class EventForm(
|
|||||||
val end: LocalDateTime,
|
val end: LocalDateTime,
|
||||||
val location: String = "",
|
val location: String = "",
|
||||||
val description: String = "",
|
val description: String = "",
|
||||||
|
/** Reminder lead times in minutes before the start, deduplicated. */
|
||||||
|
val reminders: List<Int> = emptyList(),
|
||||||
|
val availability: Availability = Availability.Busy,
|
||||||
|
val accessLevel: AccessLevel = AccessLevel.Default,
|
||||||
)
|
)
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The form's optional sections. Which ones show by default is a user setting;
|
||||||
|
* the rest unfold behind a "more fields" button.
|
||||||
|
*/
|
||||||
|
enum class EventFormField {
|
||||||
|
Location,
|
||||||
|
Description,
|
||||||
|
Reminders,
|
||||||
|
Availability,
|
||||||
|
Visibility,
|
||||||
|
}
|
||||||
|
|
||||||
enum class EventFormProblem {
|
enum class EventFormProblem {
|
||||||
/** No target calendar — none picked and no writable calendar exists. */
|
/** No target calendar — none picked and no writable calendar exists. */
|
||||||
NoCalendar,
|
NoCalendar,
|
||||||
|
|||||||
@@ -8,9 +8,11 @@ import androidx.compose.foundation.layout.Column
|
|||||||
import androidx.compose.material.icons.Icons
|
import androidx.compose.material.icons.Icons
|
||||||
import androidx.compose.material.icons.filled.Add
|
import androidx.compose.material.icons.filled.Add
|
||||||
import androidx.compose.material.icons.filled.Refresh
|
import androidx.compose.material.icons.filled.Refresh
|
||||||
|
import androidx.compose.material3.ExperimentalMaterial3ExpressiveApi
|
||||||
import androidx.compose.material3.ExtendedFloatingActionButton
|
import androidx.compose.material3.ExtendedFloatingActionButton
|
||||||
import androidx.compose.material3.FloatingActionButton
|
import androidx.compose.material3.FloatingActionButton
|
||||||
import androidx.compose.material3.Icon
|
import androidx.compose.material3.Icon
|
||||||
|
import androidx.compose.material3.MaterialTheme
|
||||||
import androidx.compose.material3.Text
|
import androidx.compose.material3.Text
|
||||||
import androidx.compose.runtime.Composable
|
import androidx.compose.runtime.Composable
|
||||||
import androidx.compose.ui.Alignment
|
import androidx.compose.ui.Alignment
|
||||||
@@ -23,6 +25,7 @@ import de.jeanlucmakiola.calendula.R
|
|||||||
* create an event, with the jump-to-today pill appearing above it whenever
|
* create an event, with the jump-to-today pill appearing above it whenever
|
||||||
* the view isn't anchored on today.
|
* the view isn't anchored on today.
|
||||||
*/
|
*/
|
||||||
|
@OptIn(ExperimentalMaterial3ExpressiveApi::class)
|
||||||
@Composable
|
@Composable
|
||||||
fun CalendarFabColumn(
|
fun CalendarFabColumn(
|
||||||
todayVisible: Boolean,
|
todayVisible: Boolean,
|
||||||
@@ -36,8 +39,8 @@ fun CalendarFabColumn(
|
|||||||
) {
|
) {
|
||||||
AnimatedVisibility(
|
AnimatedVisibility(
|
||||||
visible = todayVisible,
|
visible = todayVisible,
|
||||||
enter = scaleIn(),
|
enter = scaleIn(MaterialTheme.motionScheme.fastSpatialSpec()),
|
||||||
exit = scaleOut(),
|
exit = scaleOut(MaterialTheme.motionScheme.fastSpatialSpec()),
|
||||||
) {
|
) {
|
||||||
ExtendedFloatingActionButton(
|
ExtendedFloatingActionButton(
|
||||||
onClick = onToday,
|
onClick = onToday,
|
||||||
|
|||||||
@@ -0,0 +1,94 @@
|
|||||||
|
package de.jeanlucmakiola.calendula.ui.common
|
||||||
|
|
||||||
|
import androidx.compose.foundation.layout.Column
|
||||||
|
import androidx.compose.foundation.layout.Row
|
||||||
|
import androidx.compose.foundation.layout.Spacer
|
||||||
|
import androidx.compose.foundation.layout.fillMaxWidth
|
||||||
|
import androidx.compose.foundation.layout.padding
|
||||||
|
import androidx.compose.foundation.layout.size
|
||||||
|
import androidx.compose.foundation.layout.width
|
||||||
|
import androidx.compose.foundation.shape.RoundedCornerShape
|
||||||
|
import androidx.compose.material3.Icon
|
||||||
|
import androidx.compose.material3.MaterialTheme
|
||||||
|
import androidx.compose.material3.Surface
|
||||||
|
import androidx.compose.material3.Text
|
||||||
|
import androidx.compose.runtime.Composable
|
||||||
|
import androidx.compose.ui.Alignment
|
||||||
|
import androidx.compose.ui.Modifier
|
||||||
|
import androidx.compose.ui.graphics.Color
|
||||||
|
import androidx.compose.ui.graphics.isSpecified
|
||||||
|
import androidx.compose.ui.graphics.vector.ImageVector
|
||||||
|
import androidx.compose.ui.unit.dp
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The app's standard pick in a selection dialog: a full-width tonal card,
|
||||||
|
* optionally with a leading icon and a supporting line; the selected option
|
||||||
|
* is highlighted. Stack with 8dp gaps inside an AlertDialog — this is the
|
||||||
|
* only sanctioned selection-modal style (no radio rows, no bare text lists).
|
||||||
|
*/
|
||||||
|
@Composable
|
||||||
|
fun OptionCard(
|
||||||
|
label: String,
|
||||||
|
onClick: () -> Unit,
|
||||||
|
modifier: Modifier = Modifier,
|
||||||
|
icon: ImageVector? = null,
|
||||||
|
/** Icon tint override, e.g. a calendar colour; unspecified follows selection. */
|
||||||
|
iconTint: Color = Color.Unspecified,
|
||||||
|
supportingText: String? = null,
|
||||||
|
selected: Boolean = false,
|
||||||
|
/** Label colour override, e.g. primary for an emphasised "Custom" entry. */
|
||||||
|
labelColor: Color = Color.Unspecified,
|
||||||
|
) {
|
||||||
|
val contentColor = if (selected) {
|
||||||
|
MaterialTheme.colorScheme.onSecondaryContainer
|
||||||
|
} else {
|
||||||
|
MaterialTheme.colorScheme.onSurface
|
||||||
|
}
|
||||||
|
Surface(
|
||||||
|
onClick = onClick,
|
||||||
|
color = if (selected) {
|
||||||
|
MaterialTheme.colorScheme.secondaryContainer
|
||||||
|
} else {
|
||||||
|
MaterialTheme.colorScheme.surfaceContainerHighest
|
||||||
|
},
|
||||||
|
shape = RoundedCornerShape(12.dp),
|
||||||
|
modifier = modifier.fillMaxWidth(),
|
||||||
|
) {
|
||||||
|
Row(
|
||||||
|
verticalAlignment = Alignment.CenterVertically,
|
||||||
|
modifier = Modifier.padding(horizontal = 16.dp, vertical = 14.dp),
|
||||||
|
) {
|
||||||
|
if (icon != null) {
|
||||||
|
Icon(
|
||||||
|
imageVector = icon,
|
||||||
|
contentDescription = null,
|
||||||
|
tint = when {
|
||||||
|
iconTint.isSpecified -> iconTint
|
||||||
|
selected -> MaterialTheme.colorScheme.onSecondaryContainer
|
||||||
|
else -> MaterialTheme.colorScheme.onSurfaceVariant
|
||||||
|
},
|
||||||
|
modifier = Modifier.size(20.dp),
|
||||||
|
)
|
||||||
|
Spacer(Modifier.width(12.dp))
|
||||||
|
}
|
||||||
|
Column {
|
||||||
|
Text(
|
||||||
|
text = label,
|
||||||
|
style = MaterialTheme.typography.titleMedium,
|
||||||
|
color = if (labelColor.isSpecified) labelColor else contentColor,
|
||||||
|
)
|
||||||
|
if (supportingText != null) {
|
||||||
|
Text(
|
||||||
|
text = supportingText,
|
||||||
|
style = MaterialTheme.typography.bodySmall,
|
||||||
|
color = if (selected) {
|
||||||
|
MaterialTheme.colorScheme.onSecondaryContainer.copy(alpha = 0.8f)
|
||||||
|
} else {
|
||||||
|
MaterialTheme.colorScheme.onSurfaceVariant
|
||||||
|
},
|
||||||
|
)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -141,7 +141,15 @@ fun DayScreen(
|
|||||||
var slideDir by remember { mutableIntStateOf(0) }
|
var slideDir by remember { mutableIntStateOf(0) }
|
||||||
val goNext = { slideDir = 1; viewModel.goToNext() }
|
val goNext = { slideDir = 1; viewModel.goToNext() }
|
||||||
val goPrev = { slideDir = -1; viewModel.goToPrev() }
|
val goPrev = { slideDir = -1; viewModel.goToPrev() }
|
||||||
val jumpToToday = { slideDir = 0; viewModel.goToToday() }
|
// Slide toward today: viewing the future → today comes in from the left
|
||||||
|
// (back), viewing the past → from the right (forward).
|
||||||
|
val jumpToToday = {
|
||||||
|
slideDir = when (val s = state) {
|
||||||
|
is DayUiState.Success -> if (s.today < s.date) -1 else 1
|
||||||
|
else -> 0
|
||||||
|
}
|
||||||
|
viewModel.goToToday()
|
||||||
|
}
|
||||||
|
|
||||||
ModalNavigationDrawer(
|
ModalNavigationDrawer(
|
||||||
drawerState = drawerState,
|
drawerState = drawerState,
|
||||||
|
|||||||
@@ -28,7 +28,6 @@ import androidx.compose.foundation.layout.padding
|
|||||||
import androidx.compose.foundation.layout.size
|
import androidx.compose.foundation.layout.size
|
||||||
import androidx.compose.foundation.layout.width
|
import androidx.compose.foundation.layout.width
|
||||||
import androidx.compose.foundation.rememberScrollState
|
import androidx.compose.foundation.rememberScrollState
|
||||||
import androidx.compose.foundation.selection.selectable
|
|
||||||
import androidx.compose.foundation.shape.RoundedCornerShape
|
import androidx.compose.foundation.shape.RoundedCornerShape
|
||||||
import androidx.compose.foundation.verticalScroll
|
import androidx.compose.foundation.verticalScroll
|
||||||
import androidx.compose.material.icons.Icons
|
import androidx.compose.material.icons.Icons
|
||||||
@@ -47,7 +46,6 @@ import androidx.compose.material3.ExperimentalMaterial3Api
|
|||||||
import androidx.compose.material3.Icon
|
import androidx.compose.material3.Icon
|
||||||
import androidx.compose.material3.IconButton
|
import androidx.compose.material3.IconButton
|
||||||
import androidx.compose.material3.MaterialTheme
|
import androidx.compose.material3.MaterialTheme
|
||||||
import androidx.compose.material3.RadioButton
|
|
||||||
import androidx.compose.material3.Scaffold
|
import androidx.compose.material3.Scaffold
|
||||||
import androidx.compose.material3.SnackbarHost
|
import androidx.compose.material3.SnackbarHost
|
||||||
import androidx.compose.material3.SnackbarHostState
|
import androidx.compose.material3.SnackbarHostState
|
||||||
@@ -68,7 +66,6 @@ import androidx.compose.ui.Modifier
|
|||||||
import androidx.compose.ui.graphics.Color
|
import androidx.compose.ui.graphics.Color
|
||||||
import androidx.compose.ui.graphics.vector.ImageVector
|
import androidx.compose.ui.graphics.vector.ImageVector
|
||||||
import androidx.compose.ui.platform.LocalContext
|
import androidx.compose.ui.platform.LocalContext
|
||||||
import androidx.compose.ui.semantics.Role
|
|
||||||
import androidx.core.content.ContextCompat
|
import androidx.core.content.ContextCompat
|
||||||
import androidx.compose.ui.res.pluralStringResource
|
import androidx.compose.ui.res.pluralStringResource
|
||||||
import androidx.compose.ui.res.stringResource
|
import androidx.compose.ui.res.stringResource
|
||||||
@@ -95,6 +92,7 @@ import de.jeanlucmakiola.calendula.domain.EventInstance
|
|||||||
import de.jeanlucmakiola.calendula.domain.EventStatus
|
import de.jeanlucmakiola.calendula.domain.EventStatus
|
||||||
import de.jeanlucmakiola.calendula.domain.Reminder
|
import de.jeanlucmakiola.calendula.domain.Reminder
|
||||||
import de.jeanlucmakiola.calendula.ui.common.CalendarFailure
|
import de.jeanlucmakiola.calendula.ui.common.CalendarFailure
|
||||||
|
import de.jeanlucmakiola.calendula.ui.common.OptionCard
|
||||||
import de.jeanlucmakiola.calendula.ui.common.currentLocale
|
import de.jeanlucmakiola.calendula.ui.common.currentLocale
|
||||||
import de.jeanlucmakiola.calendula.ui.common.pastelize
|
import de.jeanlucmakiola.calendula.ui.common.pastelize
|
||||||
import kotlinx.datetime.TimeZone
|
import kotlinx.datetime.TimeZone
|
||||||
@@ -257,16 +255,16 @@ private fun DeleteEventDialog(
|
|||||||
},
|
},
|
||||||
text = {
|
text = {
|
||||||
if (isRecurring) {
|
if (isRecurring) {
|
||||||
Column {
|
Column(verticalArrangement = Arrangement.spacedBy(8.dp)) {
|
||||||
DeleteChoiceRow(
|
OptionCard(
|
||||||
selected = !wholeSeries,
|
|
||||||
label = stringResource(R.string.event_delete_option_occurrence),
|
label = stringResource(R.string.event_delete_option_occurrence),
|
||||||
onSelect = { wholeSeries = false },
|
onClick = { wholeSeries = false },
|
||||||
|
selected = !wholeSeries,
|
||||||
)
|
)
|
||||||
DeleteChoiceRow(
|
OptionCard(
|
||||||
selected = wholeSeries,
|
|
||||||
label = stringResource(R.string.event_delete_option_series),
|
label = stringResource(R.string.event_delete_option_series),
|
||||||
onSelect = { wholeSeries = true },
|
onClick = { wholeSeries = true },
|
||||||
|
selected = wholeSeries,
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
@@ -289,20 +287,6 @@ private fun DeleteEventDialog(
|
|||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
@Composable
|
|
||||||
private fun DeleteChoiceRow(selected: Boolean, label: String, onSelect: () -> Unit) {
|
|
||||||
Row(
|
|
||||||
modifier = Modifier
|
|
||||||
.fillMaxWidth()
|
|
||||||
.selectable(selected = selected, role = Role.RadioButton, onClick = onSelect)
|
|
||||||
.padding(vertical = 8.dp),
|
|
||||||
verticalAlignment = Alignment.CenterVertically,
|
|
||||||
) {
|
|
||||||
RadioButton(selected = selected, onClick = null)
|
|
||||||
Spacer(Modifier.width(8.dp))
|
|
||||||
Text(label, style = MaterialTheme.typography.bodyLarge)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
@Composable
|
@Composable
|
||||||
private fun EventDetailContent(state: EventDetailUiState.Success, modifier: Modifier = Modifier) {
|
private fun EventDetailContent(state: EventDetailUiState.Success, modifier: Modifier = Modifier) {
|
||||||
|
|||||||
File diff suppressed because it is too large
Load Diff
@@ -2,6 +2,7 @@ package de.jeanlucmakiola.calendula.ui.edit
|
|||||||
|
|
||||||
import de.jeanlucmakiola.calendula.domain.CalendarSource
|
import de.jeanlucmakiola.calendula.domain.CalendarSource
|
||||||
import de.jeanlucmakiola.calendula.domain.EventForm
|
import de.jeanlucmakiola.calendula.domain.EventForm
|
||||||
|
import de.jeanlucmakiola.calendula.domain.EventFormField
|
||||||
import de.jeanlucmakiola.calendula.domain.EventFormProblem
|
import de.jeanlucmakiola.calendula.domain.EventFormProblem
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -16,6 +17,10 @@ data class EventEditUiState(
|
|||||||
/** Validation problems; empty until a save was attempted. */
|
/** Validation problems; empty until a save was attempted. */
|
||||||
val problems: Set<EventFormProblem>,
|
val problems: Set<EventFormProblem>,
|
||||||
val saveState: SaveUiState,
|
val saveState: SaveUiState,
|
||||||
|
/** Optional sections currently rendered (settings defaults ∪ revealed). */
|
||||||
|
val visibleFields: Set<EventFormField> = emptySet(),
|
||||||
|
/** True while at least one optional section hides behind "more fields". */
|
||||||
|
val hasHiddenFields: Boolean = false,
|
||||||
)
|
)
|
||||||
|
|
||||||
/** One-shot state of a save request, mirroring DeleteUiState on the detail screen. */
|
/** One-shot state of a save request, mirroring DeleteUiState on the detail screen. */
|
||||||
|
|||||||
@@ -6,7 +6,12 @@ import dagger.hilt.android.lifecycle.HiltViewModel
|
|||||||
import de.jeanlucmakiola.calendula.data.calendar.CalendarRepository
|
import de.jeanlucmakiola.calendula.data.calendar.CalendarRepository
|
||||||
import de.jeanlucmakiola.calendula.data.di.IoDispatcher
|
import de.jeanlucmakiola.calendula.data.di.IoDispatcher
|
||||||
import de.jeanlucmakiola.calendula.data.prefs.CalendarPrefs
|
import de.jeanlucmakiola.calendula.data.prefs.CalendarPrefs
|
||||||
|
import de.jeanlucmakiola.calendula.data.prefs.SettingsPrefs
|
||||||
|
import de.jeanlucmakiola.calendula.domain.AccessLevel
|
||||||
|
import de.jeanlucmakiola.calendula.domain.Availability
|
||||||
|
import de.jeanlucmakiola.calendula.domain.CalendarSource
|
||||||
import de.jeanlucmakiola.calendula.domain.EventForm
|
import de.jeanlucmakiola.calendula.domain.EventForm
|
||||||
|
import de.jeanlucmakiola.calendula.domain.EventFormField
|
||||||
import de.jeanlucmakiola.calendula.domain.problems
|
import de.jeanlucmakiola.calendula.domain.problems
|
||||||
import kotlinx.coroutines.CoroutineDispatcher
|
import kotlinx.coroutines.CoroutineDispatcher
|
||||||
import kotlinx.coroutines.flow.MutableStateFlow
|
import kotlinx.coroutines.flow.MutableStateFlow
|
||||||
@@ -39,6 +44,7 @@ import javax.inject.Inject
|
|||||||
class EventEditViewModel @Inject constructor(
|
class EventEditViewModel @Inject constructor(
|
||||||
private val repository: CalendarRepository,
|
private val repository: CalendarRepository,
|
||||||
private val prefs: CalendarPrefs,
|
private val prefs: CalendarPrefs,
|
||||||
|
private val settingsPrefs: SettingsPrefs,
|
||||||
@IoDispatcher private val io: CoroutineDispatcher,
|
@IoDispatcher private val io: CoroutineDispatcher,
|
||||||
) : ViewModel() {
|
) : ViewModel() {
|
||||||
|
|
||||||
@@ -47,26 +53,46 @@ class EventEditViewModel @Inject constructor(
|
|||||||
// Problems stay hidden until the first save attempt, so a half-filled
|
// Problems stay hidden until the first save attempt, so a half-filled
|
||||||
// form isn't already shouting errors.
|
// form isn't already shouting errors.
|
||||||
private val _showProblems = MutableStateFlow(false)
|
private val _showProblems = MutableStateFlow(false)
|
||||||
|
// Fields added through the "more fields" picker; folds back on reset().
|
||||||
|
private val _revealed = MutableStateFlow<Set<EventFormField>>(emptySet())
|
||||||
|
|
||||||
|
private data class LocalInputs(
|
||||||
|
val form: EventForm?,
|
||||||
|
val saveState: SaveUiState,
|
||||||
|
val showProblems: Boolean,
|
||||||
|
val revealed: Set<EventFormField>,
|
||||||
|
)
|
||||||
|
|
||||||
|
private data class ExternalInputs(
|
||||||
|
val writable: List<CalendarSource>,
|
||||||
|
val lastUsed: Long?,
|
||||||
|
val defaultFields: Set<EventFormField>,
|
||||||
|
)
|
||||||
|
|
||||||
val state: StateFlow<EventEditUiState?> = combine(
|
val state: StateFlow<EventEditUiState?> = combine(
|
||||||
_form,
|
combine(_form, _saveState, _showProblems, _revealed, ::LocalInputs),
|
||||||
|
combine(
|
||||||
repository.calendars()
|
repository.calendars()
|
||||||
.map { calendars -> calendars.filter { it.canModifyContents } }
|
.map { calendars -> calendars.filter { it.canModifyContents } }
|
||||||
.catch { emit(emptyList()) },
|
.catch { emit(emptyList()) },
|
||||||
prefs.lastUsedCalendarId,
|
prefs.lastUsedCalendarId,
|
||||||
_saveState,
|
settingsPrefs.defaultFormFields,
|
||||||
_showProblems,
|
::ExternalInputs,
|
||||||
) { form, writable, lastUsed, saveState, showProblems ->
|
),
|
||||||
if (form == null) return@combine null
|
) { local, external ->
|
||||||
|
val form = local.form ?: return@combine null
|
||||||
val resolvedId = form.calendarId
|
val resolvedId = form.calendarId
|
||||||
?: lastUsed?.takeIf { id -> writable.any { it.id == id } }
|
?: external.lastUsed?.takeIf { id -> external.writable.any { it.id == id } }
|
||||||
?: writable.firstOrNull()?.id
|
?: external.writable.firstOrNull()?.id
|
||||||
val resolved = form.copy(calendarId = resolvedId)
|
val resolved = form.copy(calendarId = resolvedId)
|
||||||
|
val visibleFields = external.defaultFields + local.revealed
|
||||||
EventEditUiState(
|
EventEditUiState(
|
||||||
form = resolved,
|
form = resolved,
|
||||||
calendars = writable,
|
calendars = external.writable,
|
||||||
problems = if (showProblems) resolved.problems() else emptySet(),
|
problems = if (local.showProblems) resolved.problems() else emptySet(),
|
||||||
saveState = saveState,
|
saveState = local.saveState,
|
||||||
|
visibleFields = visibleFields,
|
||||||
|
hasHiddenFields = visibleFields.size < EventFormField.entries.size,
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
.flowOn(io)
|
.flowOn(io)
|
||||||
@@ -102,6 +128,12 @@ class EventEditViewModel @Inject constructor(
|
|||||||
_form.value = null
|
_form.value = null
|
||||||
_saveState.value = SaveUiState.Idle
|
_saveState.value = SaveUiState.Idle
|
||||||
_showProblems.value = false
|
_showProblems.value = false
|
||||||
|
_revealed.value = emptySet()
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Unfold one optional field, picked in the "more fields" dialog. */
|
||||||
|
fun revealField(field: EventFormField) {
|
||||||
|
_revealed.value = _revealed.value + field
|
||||||
}
|
}
|
||||||
|
|
||||||
fun setTitle(value: String) = update { it.copy(title = value) }
|
fun setTitle(value: String) = update { it.copy(title = value) }
|
||||||
@@ -109,6 +141,16 @@ class EventEditViewModel @Inject constructor(
|
|||||||
fun setDescription(value: String) = update { it.copy(description = value) }
|
fun setDescription(value: String) = update { it.copy(description = value) }
|
||||||
fun setAllDay(value: Boolean) = update { it.copy(isAllDay = value) }
|
fun setAllDay(value: Boolean) = update { it.copy(isAllDay = value) }
|
||||||
fun setCalendar(id: Long) = update { it.copy(calendarId = id) }
|
fun setCalendar(id: Long) = update { it.copy(calendarId = id) }
|
||||||
|
fun setAvailability(value: Availability) = update { it.copy(availability = value) }
|
||||||
|
fun setAccessLevel(value: AccessLevel) = update { it.copy(accessLevel = value) }
|
||||||
|
|
||||||
|
fun addReminder(minutes: Int) = update {
|
||||||
|
it.copy(reminders = (it.reminders + minutes).distinct().sorted())
|
||||||
|
}
|
||||||
|
|
||||||
|
fun removeReminder(minutes: Int) = update {
|
||||||
|
it.copy(reminders = it.reminders - minutes)
|
||||||
|
}
|
||||||
|
|
||||||
/** Moving the start drags the end along, preserving the duration. */
|
/** Moving the start drags the end along, preserving the duration. */
|
||||||
fun setStartDate(date: LocalDate) = moveStart { LocalDateTime(date, it.time) }
|
fun setStartDate(date: LocalDate) = moveStart { LocalDateTime(date, it.time) }
|
||||||
|
|||||||
@@ -113,8 +113,14 @@ fun MonthScreen(
|
|||||||
slideDir = -1
|
slideDir = -1
|
||||||
viewModel.goToPrev()
|
viewModel.goToPrev()
|
||||||
}
|
}
|
||||||
|
// Slide toward today: viewing the future → today comes in from the left
|
||||||
|
// (back), viewing the past → from the right (forward).
|
||||||
val jumpToToday = {
|
val jumpToToday = {
|
||||||
slideDir = 0
|
slideDir = when (val s = state) {
|
||||||
|
is MonthUiState.Success ->
|
||||||
|
if (YearMonth(s.today.year, s.today.month) < s.month) -1 else 1
|
||||||
|
else -> 0
|
||||||
|
}
|
||||||
viewModel.goToToday()
|
viewModel.goToToday()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -47,6 +47,7 @@ import androidx.lifecycle.compose.collectAsStateWithLifecycle
|
|||||||
import de.jeanlucmakiola.calendula.R
|
import de.jeanlucmakiola.calendula.R
|
||||||
import de.jeanlucmakiola.calendula.data.prefs.ThemeMode
|
import de.jeanlucmakiola.calendula.data.prefs.ThemeMode
|
||||||
import de.jeanlucmakiola.calendula.data.prefs.WeekStartPref
|
import de.jeanlucmakiola.calendula.data.prefs.WeekStartPref
|
||||||
|
import de.jeanlucmakiola.calendula.domain.EventFormField
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Settings (M4) — appearance (theme, dynamic colour, week start), language,
|
* Settings (M4) — appearance (theme, dynamic colour, week start), language,
|
||||||
@@ -111,6 +112,22 @@ fun SettingsScreen(
|
|||||||
onSelect = viewModel::setWeekStart,
|
onSelect = viewModel::setWeekStart,
|
||||||
)
|
)
|
||||||
|
|
||||||
|
HorizontalDivider(Modifier.padding(vertical = 8.dp))
|
||||||
|
SectionHeader(stringResource(R.string.settings_section_event_form))
|
||||||
|
Text(
|
||||||
|
text = stringResource(R.string.settings_form_fields_hint),
|
||||||
|
style = MaterialTheme.typography.bodySmall,
|
||||||
|
color = MaterialTheme.colorScheme.onSurfaceVariant,
|
||||||
|
modifier = Modifier.padding(horizontal = 24.dp),
|
||||||
|
)
|
||||||
|
EventFormField.entries.forEach { field ->
|
||||||
|
FormFieldRow(
|
||||||
|
title = stringResource(formFieldLabel(field)),
|
||||||
|
checked = field in state.defaultFormFields,
|
||||||
|
onCheckedChange = { viewModel.setFormFieldDefault(field, it) },
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
HorizontalDivider(Modifier.padding(vertical = 8.dp))
|
HorizontalDivider(Modifier.padding(vertical = 8.dp))
|
||||||
SectionHeader(stringResource(R.string.settings_section_language))
|
SectionHeader(stringResource(R.string.settings_section_language))
|
||||||
LanguageRow()
|
LanguageRow()
|
||||||
@@ -298,6 +315,35 @@ private fun AboutRow(title: String, value: String) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Composable
|
||||||
|
private fun FormFieldRow(
|
||||||
|
title: String,
|
||||||
|
checked: Boolean,
|
||||||
|
onCheckedChange: (Boolean) -> Unit,
|
||||||
|
) {
|
||||||
|
Row(
|
||||||
|
modifier = Modifier
|
||||||
|
.fillMaxWidth()
|
||||||
|
.padding(horizontal = 24.dp, vertical = 8.dp),
|
||||||
|
verticalAlignment = Alignment.CenterVertically,
|
||||||
|
) {
|
||||||
|
Text(
|
||||||
|
text = title,
|
||||||
|
style = MaterialTheme.typography.bodyLarge,
|
||||||
|
modifier = Modifier.weight(1f),
|
||||||
|
)
|
||||||
|
Switch(checked = checked, onCheckedChange = onCheckedChange)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
private fun formFieldLabel(field: EventFormField): Int = when (field) {
|
||||||
|
EventFormField.Location -> R.string.event_detail_location
|
||||||
|
EventFormField.Description -> R.string.event_detail_description
|
||||||
|
EventFormField.Reminders -> R.string.event_detail_reminders
|
||||||
|
EventFormField.Availability -> R.string.event_edit_availability
|
||||||
|
EventFormField.Visibility -> R.string.event_edit_visibility
|
||||||
|
}
|
||||||
|
|
||||||
@Composable
|
@Composable
|
||||||
private fun themeLabel(mode: ThemeMode): String = stringResource(
|
private fun themeLabel(mode: ThemeMode): String = stringResource(
|
||||||
when (mode) {
|
when (mode) {
|
||||||
|
|||||||
@@ -1,7 +1,9 @@
|
|||||||
package de.jeanlucmakiola.calendula.ui.settings
|
package de.jeanlucmakiola.calendula.ui.settings
|
||||||
|
|
||||||
|
import de.jeanlucmakiola.calendula.data.prefs.SettingsPrefs
|
||||||
import de.jeanlucmakiola.calendula.data.prefs.ThemeMode
|
import de.jeanlucmakiola.calendula.data.prefs.ThemeMode
|
||||||
import de.jeanlucmakiola.calendula.data.prefs.WeekStartPref
|
import de.jeanlucmakiola.calendula.data.prefs.WeekStartPref
|
||||||
|
import de.jeanlucmakiola.calendula.domain.EventFormField
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Settings screen state (M4). Persisted preferences are instant to read, so
|
* Settings screen state (M4). Persisted preferences are instant to read, so
|
||||||
@@ -14,4 +16,6 @@ data class SettingsUiState(
|
|||||||
val dynamicColor: Boolean = true,
|
val dynamicColor: Boolean = true,
|
||||||
val dynamicColorAvailable: Boolean = true,
|
val dynamicColorAvailable: Boolean = true,
|
||||||
val weekStart: WeekStartPref = WeekStartPref.AUTO,
|
val weekStart: WeekStartPref = WeekStartPref.AUTO,
|
||||||
|
/** Optional event-form fields shown by default (rest behind "more fields"). */
|
||||||
|
val defaultFormFields: Set<EventFormField> = SettingsPrefs.DEFAULT_FORM_FIELDS,
|
||||||
)
|
)
|
||||||
|
|||||||
@@ -7,6 +7,7 @@ import dagger.hilt.android.lifecycle.HiltViewModel
|
|||||||
import de.jeanlucmakiola.calendula.data.prefs.SettingsPrefs
|
import de.jeanlucmakiola.calendula.data.prefs.SettingsPrefs
|
||||||
import de.jeanlucmakiola.calendula.data.prefs.ThemeMode
|
import de.jeanlucmakiola.calendula.data.prefs.ThemeMode
|
||||||
import de.jeanlucmakiola.calendula.data.prefs.WeekStartPref
|
import de.jeanlucmakiola.calendula.data.prefs.WeekStartPref
|
||||||
|
import de.jeanlucmakiola.calendula.domain.EventFormField
|
||||||
import kotlinx.coroutines.flow.SharingStarted
|
import kotlinx.coroutines.flow.SharingStarted
|
||||||
import kotlinx.coroutines.flow.StateFlow
|
import kotlinx.coroutines.flow.StateFlow
|
||||||
import kotlinx.coroutines.flow.combine
|
import kotlinx.coroutines.flow.combine
|
||||||
@@ -26,12 +27,14 @@ class SettingsViewModel @Inject constructor(
|
|||||||
prefs.themeMode,
|
prefs.themeMode,
|
||||||
prefs.dynamicColor,
|
prefs.dynamicColor,
|
||||||
prefs.weekStart,
|
prefs.weekStart,
|
||||||
) { theme, dynamic, weekStart ->
|
prefs.defaultFormFields,
|
||||||
|
) { theme, dynamic, weekStart, formFields ->
|
||||||
SettingsUiState(
|
SettingsUiState(
|
||||||
themeMode = theme,
|
themeMode = theme,
|
||||||
dynamicColor = dynamic && dynamicColorAvailable,
|
dynamicColor = dynamic && dynamicColorAvailable,
|
||||||
dynamicColorAvailable = dynamicColorAvailable,
|
dynamicColorAvailable = dynamicColorAvailable,
|
||||||
weekStart = weekStart,
|
weekStart = weekStart,
|
||||||
|
defaultFormFields = formFields,
|
||||||
)
|
)
|
||||||
}.stateIn(
|
}.stateIn(
|
||||||
scope = viewModelScope,
|
scope = viewModelScope,
|
||||||
@@ -50,4 +53,8 @@ class SettingsViewModel @Inject constructor(
|
|||||||
fun setWeekStart(pref: WeekStartPref) {
|
fun setWeekStart(pref: WeekStartPref) {
|
||||||
viewModelScope.launch { prefs.setWeekStart(pref) }
|
viewModelScope.launch { prefs.setWeekStart(pref) }
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fun setFormFieldDefault(field: EventFormField, enabled: Boolean) {
|
||||||
|
viewModelScope.launch { prefs.setFormFieldDefault(field, enabled) }
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -2,7 +2,9 @@ package de.jeanlucmakiola.calendula.ui.theme
|
|||||||
|
|
||||||
import android.os.Build
|
import android.os.Build
|
||||||
import androidx.compose.foundation.isSystemInDarkTheme
|
import androidx.compose.foundation.isSystemInDarkTheme
|
||||||
import androidx.compose.material3.MaterialTheme
|
import androidx.compose.material3.ExperimentalMaterial3ExpressiveApi
|
||||||
|
import androidx.compose.material3.MaterialExpressiveTheme
|
||||||
|
import androidx.compose.material3.MotionScheme
|
||||||
import androidx.compose.material3.dynamicDarkColorScheme
|
import androidx.compose.material3.dynamicDarkColorScheme
|
||||||
import androidx.compose.material3.dynamicLightColorScheme
|
import androidx.compose.material3.dynamicLightColorScheme
|
||||||
import androidx.compose.runtime.Composable
|
import androidx.compose.runtime.Composable
|
||||||
@@ -17,6 +19,7 @@ import androidx.compose.ui.platform.LocalContext
|
|||||||
* The Settings screen (later) can override useDynamicColor and themePreference,
|
* The Settings screen (later) can override useDynamicColor and themePreference,
|
||||||
* but the V1 foundation just follows the system.
|
* but the V1 foundation just follows the system.
|
||||||
*/
|
*/
|
||||||
|
@OptIn(ExperimentalMaterial3ExpressiveApi::class)
|
||||||
@Composable
|
@Composable
|
||||||
fun CalendulaTheme(
|
fun CalendulaTheme(
|
||||||
darkTheme: Boolean = isSystemInDarkTheme(),
|
darkTheme: Boolean = isSystemInDarkTheme(),
|
||||||
@@ -32,9 +35,15 @@ fun CalendulaTheme(
|
|||||||
else -> CalendulaLightFallback
|
else -> CalendulaLightFallback
|
||||||
}
|
}
|
||||||
|
|
||||||
MaterialTheme(
|
// MaterialExpressiveTheme routes all component + custom motion through
|
||||||
|
// MaterialTheme.motionScheme (switches, chips, pickers, calendar slide,
|
||||||
|
// FAB, field reveal). The STANDARD scheme is a deliberate choice over
|
||||||
|
// expressive(): same spring choreography, but without the overshoot —
|
||||||
|
// the bouncy variant felt overdone in review (2026-06-11).
|
||||||
|
MaterialExpressiveTheme(
|
||||||
colorScheme = colorScheme,
|
colorScheme = colorScheme,
|
||||||
typography = CalendulaTypography,
|
typography = CalendulaTypography,
|
||||||
|
motionScheme = MotionScheme.standard(),
|
||||||
content = content,
|
content = content,
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -146,7 +146,15 @@ fun WeekScreen(
|
|||||||
var slideDir by remember { mutableIntStateOf(0) }
|
var slideDir by remember { mutableIntStateOf(0) }
|
||||||
val goNext = { slideDir = 1; viewModel.goToNext() }
|
val goNext = { slideDir = 1; viewModel.goToNext() }
|
||||||
val goPrev = { slideDir = -1; viewModel.goToPrev() }
|
val goPrev = { slideDir = -1; viewModel.goToPrev() }
|
||||||
val jumpToToday = { slideDir = 0; viewModel.goToToday() }
|
// Slide toward today: viewing the future → today comes in from the left
|
||||||
|
// (back), viewing the past → from the right (forward).
|
||||||
|
val jumpToToday = {
|
||||||
|
slideDir = when (val s = state) {
|
||||||
|
is WeekUiState.Success -> if (s.today < s.weekStart) -1 else 1
|
||||||
|
else -> 0
|
||||||
|
}
|
||||||
|
viewModel.goToToday()
|
||||||
|
}
|
||||||
|
|
||||||
ModalNavigationDrawer(
|
ModalNavigationDrawer(
|
||||||
drawerState = drawerState,
|
drawerState = drawerState,
|
||||||
|
|||||||
@@ -67,6 +67,20 @@
|
|||||||
<string name="event_edit_error_no_calendar">Kein beschreibbarer Kalender verfügbar</string>
|
<string name="event_edit_error_no_calendar">Kein beschreibbarer Kalender verfügbar</string>
|
||||||
<string name="event_edit_save_failed">Termin konnte nicht gespeichert werden</string>
|
<string name="event_edit_save_failed">Termin konnte nicht gespeichert werden</string>
|
||||||
<string name="event_edit_write_denied">Calendula braucht Schreibzugriff, um Termine zu erstellen</string>
|
<string name="event_edit_write_denied">Calendula braucht Schreibzugriff, um Termine zu erstellen</string>
|
||||||
|
<string name="event_edit_more_fields">Weitere Felder</string>
|
||||||
|
<string name="event_edit_add">Hinzufügen</string>
|
||||||
|
<string name="event_edit_add_reminder">Erinnerung hinzufügen</string>
|
||||||
|
<string name="event_edit_remove_reminder">Erinnerung entfernen</string>
|
||||||
|
<string name="event_edit_reminder_custom">Benutzerdefiniert</string>
|
||||||
|
<string name="reminder_unit_minutes">Minuten</string>
|
||||||
|
<string name="reminder_unit_hours">Stunden</string>
|
||||||
|
<string name="reminder_unit_days">Tage</string>
|
||||||
|
<string name="reminder_unit_weeks">Wochen</string>
|
||||||
|
<string name="event_edit_availability">Verfügbarkeit</string>
|
||||||
|
<string name="event_edit_visibility">Sichtbarkeit</string>
|
||||||
|
<string name="event_availability_busy">Beschäftigt</string>
|
||||||
|
<string name="event_access_default">Standard</string>
|
||||||
|
<string name="event_access_public">Öffentlich</string>
|
||||||
<string name="event_detail_all_day">Ganztägig</string>
|
<string name="event_detail_all_day">Ganztägig</string>
|
||||||
<string name="event_detail_calendar">Kalender</string>
|
<string name="event_detail_calendar">Kalender</string>
|
||||||
<string name="event_detail_calendar_unknown">Unbekannter Kalender</string>
|
<string name="event_detail_calendar_unknown">Unbekannter Kalender</string>
|
||||||
@@ -149,6 +163,8 @@
|
|||||||
<string name="settings_week_start_auto">Automatisch</string>
|
<string name="settings_week_start_auto">Automatisch</string>
|
||||||
<string name="settings_week_start_monday">Montag</string>
|
<string name="settings_week_start_monday">Montag</string>
|
||||||
<string name="settings_week_start_sunday">Sonntag</string>
|
<string name="settings_week_start_sunday">Sonntag</string>
|
||||||
|
<string name="settings_section_event_form">Termin-Formular</string>
|
||||||
|
<string name="settings_form_fields_hint">Standardmäßig angezeigte Felder — alles Weitere liegt hinter \"Weitere Felder\"</string>
|
||||||
<string name="settings_section_language">Sprache</string>
|
<string name="settings_section_language">Sprache</string>
|
||||||
<string name="settings_language">App-Sprache</string>
|
<string name="settings_language">App-Sprache</string>
|
||||||
<string name="settings_language_auto">Systemstandard</string>
|
<string name="settings_language_auto">Systemstandard</string>
|
||||||
|
|||||||
@@ -68,6 +68,20 @@
|
|||||||
<string name="event_edit_error_no_calendar">No writable calendar available</string>
|
<string name="event_edit_error_no_calendar">No writable calendar available</string>
|
||||||
<string name="event_edit_save_failed">Couldn\'t save the event</string>
|
<string name="event_edit_save_failed">Couldn\'t save the event</string>
|
||||||
<string name="event_edit_write_denied">Calendula needs write access to create events</string>
|
<string name="event_edit_write_denied">Calendula needs write access to create events</string>
|
||||||
|
<string name="event_edit_more_fields">More fields</string>
|
||||||
|
<string name="event_edit_add">Add</string>
|
||||||
|
<string name="event_edit_add_reminder">Add reminder</string>
|
||||||
|
<string name="event_edit_remove_reminder">Remove reminder</string>
|
||||||
|
<string name="event_edit_reminder_custom">Custom</string>
|
||||||
|
<string name="reminder_unit_minutes">minutes</string>
|
||||||
|
<string name="reminder_unit_hours">hours</string>
|
||||||
|
<string name="reminder_unit_days">days</string>
|
||||||
|
<string name="reminder_unit_weeks">weeks</string>
|
||||||
|
<string name="event_edit_availability">Availability</string>
|
||||||
|
<string name="event_edit_visibility">Visibility</string>
|
||||||
|
<string name="event_availability_busy">Busy</string>
|
||||||
|
<string name="event_access_default">Default</string>
|
||||||
|
<string name="event_access_public">Public</string>
|
||||||
<string name="event_detail_all_day">All day</string>
|
<string name="event_detail_all_day">All day</string>
|
||||||
<string name="event_detail_calendar">Calendar</string>
|
<string name="event_detail_calendar">Calendar</string>
|
||||||
<string name="event_detail_calendar_unknown">Unknown calendar</string>
|
<string name="event_detail_calendar_unknown">Unknown calendar</string>
|
||||||
@@ -150,6 +164,8 @@
|
|||||||
<string name="settings_week_start_auto">Automatic</string>
|
<string name="settings_week_start_auto">Automatic</string>
|
||||||
<string name="settings_week_start_monday">Monday</string>
|
<string name="settings_week_start_monday">Monday</string>
|
||||||
<string name="settings_week_start_sunday">Sunday</string>
|
<string name="settings_week_start_sunday">Sunday</string>
|
||||||
|
<string name="settings_section_event_form">New event form</string>
|
||||||
|
<string name="settings_form_fields_hint">Fields shown by default — everything else sits behind \"More fields\"</string>
|
||||||
<string name="settings_section_language">Language</string>
|
<string name="settings_section_language">Language</string>
|
||||||
<string name="settings_language">App language</string>
|
<string name="settings_language">App language</string>
|
||||||
<string name="settings_language_auto">System default</string>
|
<string name="settings_language_auto">System default</string>
|
||||||
|
|||||||
@@ -1,6 +1,9 @@
|
|||||||
package de.jeanlucmakiola.calendula.data.calendar
|
package de.jeanlucmakiola.calendula.data.calendar
|
||||||
|
|
||||||
|
import android.provider.CalendarContract
|
||||||
import com.google.common.truth.Truth.assertThat
|
import com.google.common.truth.Truth.assertThat
|
||||||
|
import de.jeanlucmakiola.calendula.domain.AccessLevel
|
||||||
|
import de.jeanlucmakiola.calendula.domain.Availability
|
||||||
import de.jeanlucmakiola.calendula.domain.EventForm
|
import de.jeanlucmakiola.calendula.domain.EventForm
|
||||||
import kotlinx.datetime.LocalDate
|
import kotlinx.datetime.LocalDate
|
||||||
import kotlinx.datetime.LocalDateTime
|
import kotlinx.datetime.LocalDateTime
|
||||||
@@ -36,6 +39,28 @@ class EventWriteMapperTest {
|
|||||||
assertThat(times.dtEndMillis - times.dtStartMillis).isEqualTo(86_400_000L)
|
assertThat(times.dtEndMillis - times.dtStartMillis).isEqualTo(86_400_000L)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
fun `availability maps to the provider constants`() {
|
||||||
|
assertThat(Availability.Busy.toProviderValue())
|
||||||
|
.isEqualTo(CalendarContract.Events.AVAILABILITY_BUSY)
|
||||||
|
assertThat(Availability.Free.toProviderValue())
|
||||||
|
.isEqualTo(CalendarContract.Events.AVAILABILITY_FREE)
|
||||||
|
assertThat(Availability.Tentative.toProviderValue())
|
||||||
|
.isEqualTo(CalendarContract.Events.AVAILABILITY_TENTATIVE)
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
fun `access level maps to the provider constants`() {
|
||||||
|
assertThat(AccessLevel.Default.toProviderValue())
|
||||||
|
.isEqualTo(CalendarContract.Events.ACCESS_DEFAULT)
|
||||||
|
assertThat(AccessLevel.Private.toProviderValue())
|
||||||
|
.isEqualTo(CalendarContract.Events.ACCESS_PRIVATE)
|
||||||
|
assertThat(AccessLevel.Confidential.toProviderValue())
|
||||||
|
.isEqualTo(CalendarContract.Events.ACCESS_CONFIDENTIAL)
|
||||||
|
assertThat(AccessLevel.Public.toProviderValue())
|
||||||
|
.isEqualTo(CalendarContract.Events.ACCESS_PUBLIC)
|
||||||
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
fun `multi-day all-day event spans every covered day`() {
|
fun `multi-day all-day event spans every covered day`() {
|
||||||
val times = form(
|
val times = form(
|
||||||
|
|||||||
@@ -4,6 +4,7 @@ import androidx.datastore.core.DataStore
|
|||||||
import androidx.datastore.preferences.core.PreferenceDataStoreFactory
|
import androidx.datastore.preferences.core.PreferenceDataStoreFactory
|
||||||
import androidx.datastore.preferences.core.Preferences
|
import androidx.datastore.preferences.core.Preferences
|
||||||
import com.google.common.truth.Truth.assertThat
|
import com.google.common.truth.Truth.assertThat
|
||||||
|
import de.jeanlucmakiola.calendula.domain.EventFormField
|
||||||
import kotlinx.coroutines.flow.first
|
import kotlinx.coroutines.flow.first
|
||||||
import kotlinx.coroutines.test.runTest
|
import kotlinx.coroutines.test.runTest
|
||||||
import kotlinx.datetime.DayOfWeek
|
import kotlinx.datetime.DayOfWeek
|
||||||
@@ -60,6 +61,45 @@ class SettingsPrefsTest {
|
|||||||
assertThat(prefs.themeMode.first()).isEqualTo(ThemeMode.SYSTEM)
|
assertThat(prefs.themeMode.first()).isEqualTo(ThemeMode.SYSTEM)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
fun `form fields default to location and description`(@TempDir tempDir: Path) = runTest {
|
||||||
|
val prefs = SettingsPrefs(newDataStore(tempDir))
|
||||||
|
assertThat(prefs.defaultFormFields.first()).containsExactly(
|
||||||
|
EventFormField.Location,
|
||||||
|
EventFormField.Description,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
fun `form field toggle round-trips`(@TempDir tempDir: Path) = runTest {
|
||||||
|
val prefs = SettingsPrefs(newDataStore(tempDir))
|
||||||
|
prefs.setFormFieldDefault(EventFormField.Reminders, enabled = true)
|
||||||
|
prefs.setFormFieldDefault(EventFormField.Location, enabled = false)
|
||||||
|
assertThat(prefs.defaultFormFields.first()).containsExactly(
|
||||||
|
EventFormField.Description,
|
||||||
|
EventFormField.Reminders,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
fun `disabling every form field persists as none, not factory default`(@TempDir tempDir: Path) = runTest {
|
||||||
|
val prefs = SettingsPrefs(newDataStore(tempDir))
|
||||||
|
EventFormField.entries.forEach { prefs.setFormFieldDefault(it, enabled = false) }
|
||||||
|
assertThat(prefs.defaultFormFields.first()).isEmpty()
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
fun `unknown stored form-field names are dropped`(@TempDir tempDir: Path) = runTest {
|
||||||
|
val store = newDataStore(tempDir)
|
||||||
|
val prefs = SettingsPrefs(store)
|
||||||
|
store.updateData { p ->
|
||||||
|
val m = p.toMutablePreferences()
|
||||||
|
m[SettingsPrefs.FORM_FIELDS_KEY] = "Location,Hologram"
|
||||||
|
m
|
||||||
|
}
|
||||||
|
assertThat(prefs.defaultFormFields.first()).containsExactly(EventFormField.Location)
|
||||||
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
fun `explicit week-start prefs resolve regardless of locale`() {
|
fun `explicit week-start prefs resolve regardless of locale`() {
|
||||||
assertThat(WeekStartPref.MONDAY.resolveFirstDay(Locale.US)).isEqualTo(DayOfWeek.MONDAY)
|
assertThat(WeekStartPref.MONDAY.resolveFirstDay(Locale.US)).isEqualTo(DayOfWeek.MONDAY)
|
||||||
|
|||||||
Reference in New Issue
Block a user