Jean-Luc Makiolaandmakiolaj
0f75d2638b
On the day the clocks change, the day, 3-day and week views placed events by the time elapsed since midnight, so every event after the change sat an hour off. A 14:45 event on 25 October showed at 15:45. Blocks are now placed by wall clock. When the clocks go back, 02:00 to 03:00 happens twice, and a wall-clock time alone can't say which of the two it means. This branch keeps track of it: - The event form holds each time as a `FormTime`, the wall clock plus its UTC offset when that time is in the repeated hour. Validation and saving read the real instants from it, so a span ending in the repeated hour is valid and switching between the two passes is saved. - A time picked in the form or dragged with a resize handle goes back to the event's original pass when it's set back to its original time. Otherwise it moves in the direction it was moved, stays after the start, and takes a pass the grid can draw where it was dropped. - A drop onto a repeated time lands on the first pass, unless the event was already on the second. - A block that runs into the repeated hour from before it is drawn to 03:00, and its label shows its real end. - The editor, the event details and the pinned zone's "local time" line add the zone abbreviation (CEST or CET) to a time in the repeated hour. - A recurring series that starts in the repeated hour keeps its pass when it's edited. Also in this PR: - `ZoneSource`, provided through Hilt, gives the timeline, the event form and reschedules the device zone. The timeline lays its pages out again when the zone changes. - A drafted block (#153) opens the form at its exact start and end. - A day move onto the spring-forward day keeps its wall-clock start, so moving a weekly series there is still offered for all events. ## Testing The 1,258 unit tests pass. The instrumented suite has the same two failures as `release/v2.23.0` (`CalendarRepositorySmokeTest` and `PermissionScreenTest`), so nothing new. I also checked it by hand on an emulator in Europe/Berlin, with the clock moved to each DST day: - 25 October: the event from the issue (14:45, Europe/Brussels) is drawn at 14:45. A run from 02:10 CEST to 02:20 CET is drawn to 03:00 and labelled with its real end. - Pulling the end of a 02:30 to 03:30 CET event up to 02:45 saves 02:45 CET, after its start. - Pulling the end of a 01:00 CEST to 04:00 CET event up to 02:15 saves 02:15 CEST, and the block stays where it was dropped. - 29 March: a 01:00 to 04:00 run and a 14:00 event both sit at their own times. Picking times in the form and moving a series in the month view are covered by unit tests only. Closes #387 Co-authored-by: Jean-Luc Makiola <business@jeanlucmakiola.de> Reviewed-on: https://codeberg.org/jlmakiola/calendula/pulls/393