+1
5bd01484ed
5bd01484ed
<!-- Thanks for contributing to Calendula! Please skim CONTRIBUTING.md if you haven't: https://codeberg.org/jlmakiola/calendula/src/branch/main/CONTRIBUTING.md Two things it's easy to get wrong: • Features need a discussed issue first. An undiscussed feature PR may be closed unmerged even when the code is good. • Target the release branch for your issue's milestone (milestone 2.18.0 → release/v2.18.0), not main. If you targeted main, just say so below and it will be retargeted. --> Targeted main, issue has no milestone No entry needed in CHANGELOG.md (?) ### What this changes This fixes the tapping animation for week numbers, day cells in month split view and the handle bar to expand the split view week numbers: Because Compose draws the click ripple indication at the level clickable is placed in the modifier chain, the ripple: 1. Extended into the cell padding area (making it larger than the rounded box). 2. Was unclipped, resulting in sharp square corners instead of rounded corners. day cells: The tap/selection ripple animation on day cells in the split month view is now constrained to CELL_SHAPE. handle bar: Tapping on the handle bar will now trigger the expand/collapse action cleanly without showing a tap ripple effect across the bar. ### Why Closes #413 <!-- Closes #123: link the issue this implements or fixes. --> ### How it was tested ./gradlew lint test assembleDebug <!-- Which of these ran green, and anything you exercised by hand. On-device notes are especially useful for UI changes. ./gradlew lint test assembleDebug python3 scripts/check_translations.py --> ### Checklist - [x] There's an issue for this, and (for a feature) it got a go-ahead - [x] Targeting the release branch for that issue's milestone (or `main`, noted above) - [x] `./gradlew lint test assembleDebug` passes locally - [x] No `values-*/strings.xml` touched (Weblate owns those; new English strings in `values/` are fine) - [x] `CHANGELOG.md` updated under `## [Unreleased]`, if the change is user-visible - [x] No planning or design documents committed Co-authored-by: Jean-Luc Makiola <jlmakiola@noreply.codeberg.org> Co-authored-by: Weblate <noreply-mt-weblate@weblate.org> Co-authored-by: Sup99999 <alelmnour1o234@proton.me> Co-authored-by: VinCap <vcapaldo@ik.me> Co-authored-by: N Donkersloot <n@donkerslootjes.nl> Co-authored-by: MaxrregMustermann <MaxrregMustermann@airmail.cc> Co-authored-by: Dmitri Gabinski <dkgabi@gmail.com> Co-authored-by: James Trivette <trivette@atlas.cz> Co-authored-by: Admin <business@jeanlucmakiola.de> Co-authored-by: mirai yamada <weblate@197911mi.anonaddy.com> Reviewed-on: https://codeberg.org/jlmakiola/calendula/pulls/414