fix(alarms): no fire for an occurrence already accounted for
A natural fire whose instant equals the skip or the handled-occurrence watermark is ignored, so a dismissal racing a reschedule cannot ring. Dismissing a repeating alarm persists its resolution before arming the skip, so an unspent old skip cannot absorb it. The deferred notice sync runs even if starting the ring throws, the swipe record is one synchronised read-modify-write, and it stays out of backups. Fixes #16
This commit is contained in:
1 parent
dedcbd5dfd
commit
1253c0fc55
8 files changed
+95
-25
No files matched your search
@@ -1250,8 +1250,12 @@ the alarm's row for whoever opens the app instead.
|
||||
round its challenge. When it matches, it takes `dismissUpcoming`'s own
|
||||
branches: a repeating alarm skips that occurrence, a one-shot is switched off
|
||||
(or deleted, if transient). A fire broadcast already in flight when a skip
|
||||
was armed is `Ignored` by `onFire`, which checks the skip watermark against
|
||||
the instant it carries.
|
||||
was armed is `Ignored` by `onFire`: a natural fire whose instant *equals*
|
||||
the skip or the handled-occurrence watermark is already accounted for.
|
||||
Equality, not order, so a watermark left ahead of a clock moved backwards
|
||||
never silences an earlier occurrence. A repeating alarm's resolution is
|
||||
persisted before the skip is armed, so an old skip that has gone by but was
|
||||
never spent cannot absorb the new one.
|
||||
- **No dismiss challenge before the ring**, as in Google Clock. The challenge
|
||||
proves you are awake while an alarm sounds; before it, skipping is already one
|
||||
unchallenged switch away in the editor. The notification's Dismiss does ask
|
||||
|
||||
Reference in new issue
Block a user