fix(worldclock): keep the seconds option from costing reorder and catch-up
Rows that tick every second re-seeded the reorderable column mid-drag, so it is handed ids now. A zone or clock change no longer waits for the next minute: TIME_SET, TIMEZONE_CHANGED and TIME_TICK are merged into the tick through a new ClockChanges seam. With seconds on, the row's time drops a size so the city name keeps its room. The truncation unit and the tick come from one place, and stale 200 ms comments are gone.
This commit is contained in:
1 parent
785adf715b
commit
a4cec23e5c
16 files changed
+153
-37
No files matched your search
+12
-6
@@ -1427,7 +1427,9 @@ nothing but `delay`, which makes it testable under `runTest`'s virtual clock.
|
||||
after the immediate emission it waits `WallBoundaries.untilNext(now, unit)`,
|
||||
re-measured against `WallClock` after every wake, so it fires on the second or
|
||||
minute boundary itself and a long `delay` or a set clock does not accumulate.
|
||||
The world clock is its one caller (§16, "The cadence").
|
||||
The world clock is its one caller (§16, "The cadence"), and it merges in
|
||||
`ClockChanges`, the system's own word that the clock or zone moved, so a long
|
||||
cadence never means a long wait for those.
|
||||
|
||||
### The dismiss challenge, and why it cannot strand anyone
|
||||
|
||||
@@ -2453,11 +2455,15 @@ the flow stays `distinctUntilChanged`, which now only absorbs the odd early
|
||||
wake. The setting is read with the stored list and the home zone, so flipping
|
||||
it switches the cadence at once through the same `flatMapLatest`.
|
||||
|
||||
`TIME_SET` and `TIMEZONE_CHANGED` still self-heal within one tick, which with
|
||||
seconds off is now up to a minute. That is only reachable by changing the
|
||||
clock in system settings and returning within the five-second
|
||||
`WhileSubscribed` grace; any longer and the flow restarts and reads the new
|
||||
time at once.
|
||||
A minute is too long to wait for `TIME_SET` or `TIMEZONE_CHANGED`, which can
|
||||
arrive with the tab on screen (a network zone change on landing, split
|
||||
screen). So `ClockChanges` (`AndroidClockChanges`, a receiver registered only
|
||||
while the tab collects) is merged into the tick: those two, plus `TIME_TICK`,
|
||||
make the state re-read the clock and the zone at once. `TIME_TICK` also
|
||||
covers the one gap an aligned `delay` has, a deep sleep inside the
|
||||
five-second `WhileSubscribed` grace, which stretches the wait because the
|
||||
main looper's clock stops while the device sleeps. Every one of these is
|
||||
an extra `build`, and `distinctUntilChanged` drops it if nothing moved.
|
||||
|
||||
### Twenty-four cities, and a reorder a screen reader can reach
|
||||
|
||||
|
||||
Reference in new issue
Block a user