fix: review round 2 - TonePlayer only behind RingAudioPlayer, floret-kit ring fixes (calendula#171)

This commit is contained in:
makiolaj committed 2026-11-13 17:43:35 +01:00
1 parent 3a36b26686
commit a83fe5b4bc
2 files changed
+12 -2

No files matched your search

@@ -221,13 +221,23 @@ class ArchitectureRulesTest {
*/
@Test
fun `MediaPlayer lives only in the ring path and the ringtone catalog`() {
val offenders = kotlinSources.containing("MediaPlayer", "TonePlayer").filterNot { path ->
val offenders = kotlinSources.containing("MediaPlayer").filterNot { path ->
path.contains("/ring/") || path.contains("de/jeanlucmakiola/clockula/data/ringtones/")
}
assertThat(offenders).isEmpty()
}
/** floret-kit's `TonePlayer` is that wrapper now, so only `RingAudioPlayer` may hold one. */
@Test
fun `TonePlayer lives only behind RingAudioPlayer`() {
val offenders = kotlinSources.containing("TonePlayer").filterNot {
it.endsWith("de/jeanlucmakiola/clockula/ring/RingAudioPlayer.kt")
}
assertThat(offenders).isEmpty()
}
/**
* M7 D19: the stopwatch is silent. It never opens audio, never vibrates and
* never takes a wake lock — which is the one thing a future "make the lap