Compare commits
7 Commits
v0.2.1
...
feat/picke
| Author | SHA1 | Date | |
|---|---|---|---|
| ed1d3ca5e8 | |||
| 38e508b259 | |||
| bb3ff1f316 | |||
| b4d3ead8f0 | |||
| 9bbef911c0 | |||
| 75b90d1b3b | |||
| b4954713ff |
@@ -39,6 +39,8 @@ dependencies {
|
||||
// core-locale backs the language-picker recipe (AppLanguage).
|
||||
implementation(project(":core-locale"))
|
||||
|
||||
implementation(libs.androidx.core.ktx)
|
||||
|
||||
implementation(platform(libs.androidx.compose.bom))
|
||||
implementation(libs.androidx.ui)
|
||||
implementation(libs.androidx.foundation)
|
||||
|
||||
@@ -37,6 +37,16 @@ fun positionOf(index: Int, count: Int): Position = when {
|
||||
else -> Position.Middle
|
||||
}
|
||||
|
||||
/**
|
||||
* The inset a grouped list keeps from the screen edge.
|
||||
*
|
||||
* Exported because it is a *shared* line, not a private detail of [GroupedRow]:
|
||||
* everything that sits outside the cards but belongs to them — section headers,
|
||||
* hints, picker descriptions — has to start on the same edge, or the page reads
|
||||
* as two ragged columns. Take this value rather than writing 16.dp again.
|
||||
*/
|
||||
val GroupedListInset = 16.dp
|
||||
|
||||
/** Corner radii for a grouped segment: full at the group's outer edges, small between. */
|
||||
fun groupedShape(position: Position, full: Dp, small: Dp): Shape = when (position) {
|
||||
Position.Alone -> RoundedCornerShape(full)
|
||||
@@ -140,7 +150,7 @@ fun GroupedRow(
|
||||
}
|
||||
GroupedSurface(
|
||||
position = position,
|
||||
modifier = modifier.padding(horizontal = 16.dp),
|
||||
modifier = modifier.padding(horizontal = GroupedListInset),
|
||||
onClick = onClick,
|
||||
color = containerColor,
|
||||
gapBelow = gapBelow,
|
||||
|
||||
@@ -13,6 +13,8 @@ import androidx.compose.ui.platform.LocalView
|
||||
import androidx.compose.ui.window.Dialog
|
||||
import androidx.compose.ui.window.DialogProperties
|
||||
import androidx.compose.ui.window.DialogWindowProvider
|
||||
import androidx.core.view.WindowCompat
|
||||
import de.jeanlucmakiola.floret.identity.LocalFloretDarkTheme
|
||||
|
||||
/**
|
||||
* Full-screen scaffold for selection pickers: a full-bleed [Dialog] that reuses
|
||||
@@ -24,6 +26,20 @@ import androidx.compose.ui.window.DialogWindowProvider
|
||||
* [scrollable] forwards to [CollapsingScaffold]: leave it on unless [content]
|
||||
* scrolls itself, which a picker only needs for an option list long enough to
|
||||
* warrant a lazy container.
|
||||
*
|
||||
* **Picker richness.** Three shapes, in ascending order — take the cheapest one
|
||||
* that makes the choice obvious:
|
||||
* 1. plain option rows, when the label *is* the meaning ("English", "Dark");
|
||||
* 2. rows plus a per-option summary of the concrete effect, when the meaning is
|
||||
* a date, a time or a number the label only names ("Next 7 days" →
|
||||
* "30 Jul – 5 Aug"). [OptionPicker]'s `summary` covers this;
|
||||
* 3. a live preview above the rows, when the effect is *visual* and no words
|
||||
* carry it (month grid style, dimmed past events, week start).
|
||||
*
|
||||
* A picker of the third kind **must not close when an option is tapped** — it
|
||||
* applies immediately and stays open, because closing would hide the very thing
|
||||
* the screen exists to show. The user leaves via back. The first two kinds close
|
||||
* on tap as usual.
|
||||
*/
|
||||
@Composable
|
||||
fun FullScreenPicker(
|
||||
@@ -41,14 +57,28 @@ fun FullScreenPicker(
|
||||
decorFitsSystemWindows = false,
|
||||
),
|
||||
) {
|
||||
// The dialog window pans by default when the keyboard opens, which —
|
||||
// A Compose Dialog owns a separate android.view.Window whose bar-icon
|
||||
// appearance is seeded from the XML theme, not from the activity window's
|
||||
// runtime edge-to-edge state — so with decorFitsSystemWindows = false it
|
||||
// draws edge-to-edge under bars whose icons don't match the active theme
|
||||
// (dark icons on a dark picker). Drive the appearance from the runtime
|
||||
// [LocalFloretDarkTheme] so it tracks the in-app light/dark choice even
|
||||
// when that diverges from the system night qualifier.
|
||||
//
|
||||
// Same window also pans by default when the keyboard opens, which —
|
||||
// combined with the content's own imePadding — leaves a fixed black gap
|
||||
// above the keyboard. Switch it to ADJUST_NOTHING so the window stays
|
||||
// full-screen and imePadding alone lifts the focused field.
|
||||
val view = LocalView.current
|
||||
val darkTheme = LocalFloretDarkTheme.current
|
||||
SideEffect {
|
||||
(view.parent as? DialogWindowProvider)?.window
|
||||
?.setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_ADJUST_NOTHING)
|
||||
(view.parent as? DialogWindowProvider)?.window?.let { window ->
|
||||
window.setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_ADJUST_NOTHING)
|
||||
WindowCompat.getInsetsController(window, view).apply {
|
||||
isAppearanceLightStatusBars = !darkTheme
|
||||
isAppearanceLightNavigationBars = !darkTheme
|
||||
}
|
||||
}
|
||||
}
|
||||
CollapsingScaffold(
|
||||
title = title,
|
||||
@@ -66,6 +96,15 @@ fun FullScreenPicker(
|
||||
* General single-select picker, full-screen: each option is a connected grouped
|
||||
* row and the current one carries a check. The drop-in for the family's option
|
||||
* dialogs (theme, default list, reminder offset, …).
|
||||
*
|
||||
* [summary] adds a second line per option — reserve it for the option's
|
||||
* *concrete effect*, the thing its label names but doesn't spell out: the dates
|
||||
* a range resolves to, the time a format renders as, what "follow the system"
|
||||
* currently means. Returning null leaves that row single-line, so one option
|
||||
* (typically the automatic one) can carry a note the others don't need. It is
|
||||
* the cheap middle rung of the richness ladder described on [FullScreenPicker]:
|
||||
* every option shows its effect at once and stays comparable, without the cost
|
||||
* of a live preview.
|
||||
*/
|
||||
@Composable
|
||||
fun <T> OptionPicker(
|
||||
@@ -75,6 +114,7 @@ fun <T> OptionPicker(
|
||||
label: @Composable (T) -> String,
|
||||
onSelect: (T) -> Unit,
|
||||
onDismiss: () -> Unit,
|
||||
summary: (@Composable (T) -> String?)? = null,
|
||||
leading: (@Composable (T) -> Unit)? = null,
|
||||
header: (@Composable ColumnScope.() -> Unit)? = null,
|
||||
predictiveBack: Boolean = false,
|
||||
@@ -85,6 +125,7 @@ fun <T> OptionPicker(
|
||||
val isSelected = option == selected
|
||||
GroupedRow(
|
||||
title = label(option),
|
||||
summary = summary?.invoke(option),
|
||||
position = positionOf(index, options.size),
|
||||
selected = isSelected,
|
||||
leading = leading?.let { { it(option) } },
|
||||
@@ -102,8 +143,18 @@ fun <T> OptionPicker(
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* The trailing check that marks the chosen row in a full-screen picker — the
|
||||
* family's single selection affordance, so every picker (option, reminder,
|
||||
* agenda range, timezone, calendar, recurrence) marks its selection the same
|
||||
* way. Pair it with `GroupedRow(selected = true)`: the tonal highlight carries
|
||||
* the state at a glance, the check confirms it unambiguously.
|
||||
*
|
||||
* Purely decorative — the row itself owns the semantics, so it takes no
|
||||
* content description.
|
||||
*/
|
||||
@Composable
|
||||
private fun SelectedCheck() {
|
||||
fun SelectedCheck() {
|
||||
Icon(
|
||||
imageVector = Icons.Rounded.Check,
|
||||
contentDescription = null,
|
||||
|
||||
@@ -13,12 +13,10 @@ import androidx.compose.foundation.layout.height
|
||||
import androidx.compose.foundation.layout.padding
|
||||
import androidx.compose.foundation.layout.size
|
||||
import androidx.compose.foundation.layout.width
|
||||
import androidx.compose.foundation.shape.RoundedCornerShape
|
||||
import androidx.compose.material3.FilledTonalButton
|
||||
import androidx.compose.material3.Icon
|
||||
import androidx.compose.material3.MaterialTheme
|
||||
import androidx.compose.material3.OutlinedButton
|
||||
import androidx.compose.material3.Surface
|
||||
import androidx.compose.material3.Text
|
||||
import androidx.compose.runtime.Composable
|
||||
import androidx.compose.runtime.getValue
|
||||
@@ -41,6 +39,12 @@ data class AboutLink(val icon: ImageVector, val label: String, val url: String)
|
||||
* outlined buttons (e.g. source, licence) and an optional full-width
|
||||
* [highlightLink] tonal button (e.g. donate). Each link opens its URL in the
|
||||
* browser. The app supplies its own logo, strings and links.
|
||||
*
|
||||
* [position] lets the card join a grouped list instead of standing alone: with
|
||||
* [Position.Top] it takes the group's top corners and the 2dp gap below, so a
|
||||
* [GroupedRow] underneath continues the same container. Use that when the card's
|
||||
* call to action reads better as a row of its own than as a button inside the
|
||||
* card — the two then form one block rather than a card with a lid on it.
|
||||
*/
|
||||
@Composable
|
||||
fun AboutCard(
|
||||
@@ -49,15 +53,16 @@ fun AboutCard(
|
||||
author: String,
|
||||
primaryLinks: List<AboutLink>,
|
||||
highlightLink: AboutLink? = null,
|
||||
position: Position = Position.Alone,
|
||||
) {
|
||||
val context = LocalContext.current
|
||||
val open = { url: String ->
|
||||
runCatching { context.startActivity(Intent(Intent.ACTION_VIEW, Uri.parse(url))) }
|
||||
Unit
|
||||
}
|
||||
Surface(
|
||||
GroupedSurface(
|
||||
position = position,
|
||||
color = MaterialTheme.colorScheme.surfaceContainerHigh,
|
||||
shape = RoundedCornerShape(24.dp),
|
||||
modifier = Modifier.fillMaxWidth(),
|
||||
) {
|
||||
Column(Modifier.fillMaxWidth().padding(16.dp)) {
|
||||
|
||||
@@ -10,8 +10,19 @@ import androidx.compose.material3.Typography
|
||||
import androidx.compose.material3.dynamicDarkColorScheme
|
||||
import androidx.compose.material3.dynamicLightColorScheme
|
||||
import androidx.compose.runtime.Composable
|
||||
import androidx.compose.runtime.CompositionLocalProvider
|
||||
import androidx.compose.runtime.staticCompositionLocalOf
|
||||
import androidx.compose.ui.platform.LocalContext
|
||||
|
||||
/**
|
||||
* The resolved light/dark decision the current [FloretExpressiveTheme] is running
|
||||
* with, carried down the tree so components can align window chrome (e.g. status-
|
||||
* and navigation-bar icon appearance) with the *runtime* theme rather than the
|
||||
* system night resource qualifier — the two diverge whenever an app overrides
|
||||
* light/dark from settings. Defaults to `false` (light) outside a Floret theme.
|
||||
*/
|
||||
val LocalFloretDarkTheme = staticCompositionLocalOf { false }
|
||||
|
||||
/**
|
||||
* The family's Material 3 Expressive theme factory. Honours system light/dark
|
||||
* and Material You dynamic colour (API 31+), falling back to the app-supplied
|
||||
@@ -43,6 +54,7 @@ fun FloretExpressiveTheme(
|
||||
else -> lightScheme
|
||||
}
|
||||
|
||||
CompositionLocalProvider(LocalFloretDarkTheme provides darkTheme) {
|
||||
MaterialExpressiveTheme(
|
||||
colorScheme = colorScheme,
|
||||
typography = typography,
|
||||
@@ -50,3 +62,4 @@ fun FloretExpressiveTheme(
|
||||
content = content,
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user