docs(22-01): complete add-to-collection flow plan
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -51,7 +51,7 @@ Requirements for this milestone. Each maps to roadmap phases.
|
||||
|
||||
- [x] **CATFLOW-01**: FAB shows mini menu with "Add to Collection" and "Start Thread" globally, plus "New Setup" on setups page
|
||||
- [x] **CATFLOW-02**: Full-screen catalog search with tag chip filtering
|
||||
- [ ] **CATFLOW-03**: User can add a catalog item to collection as a reference item with personal fields (category, notes, purchase price, image, quantity)
|
||||
- [x] **CATFLOW-03**: User can add a catalog item to collection as a reference item with personal fields (category, notes, purchase price, image, quantity)
|
||||
- [x] **CATFLOW-04**: Collection items referencing global items display merged data (global base + personal overlay)
|
||||
- [ ] **CATFLOW-05**: Thread candidates can be added from catalog with global item link
|
||||
- [ ] **CATFLOW-06**: Thread resolution with catalog-linked candidate creates reference item with auto-link
|
||||
@@ -173,7 +173,7 @@ Which phases cover which requirements. Updated during roadmap creation.
|
||||
|
||||
| CATFLOW-01 | Phase 20 | Complete |
|
||||
| CATFLOW-02 | Phase 20 | Complete |
|
||||
| CATFLOW-03 | Phase 19, 22 | Pending |
|
||||
| CATFLOW-03 | Phase 19, 22 | Complete |
|
||||
| CATFLOW-04 | Phase 19 | Complete |
|
||||
| CATFLOW-05 | Phase 19, 22 | Pending |
|
||||
| CATFLOW-06 | Phase 19, 22 | Pending |
|
||||
|
||||
@@ -228,9 +228,9 @@ Plans:
|
||||
1. User can add a catalog item to collection with one confirmation step (category picker + notes)
|
||||
2. User can add catalog items as thread candidates instantly from search
|
||||
3. Resolving a catalog-linked candidate creates a properly linked reference item in collection
|
||||
**Plans:** 2 plans
|
||||
**Plans:** 1/2 plans executed
|
||||
Plans:
|
||||
- [ ] 22-01-PLAN.md -- UIStore + sonner + AddToCollectionModal + overlay/detail page collection wiring
|
||||
- [x] 22-01-PLAN.md -- UIStore + sonner + AddToCollectionModal + overlay/detail page collection wiring
|
||||
- [ ] 22-02-PLAN.md -- AddToThreadModal with thread picker + new thread flow + CATFLOW-06 verification
|
||||
**UI hint**: yes
|
||||
|
||||
@@ -270,5 +270,5 @@ Plans:
|
||||
| 19. Reference Item Model & Tags Schema | v2.0 | 3/3 | Complete | 2026-04-05 |
|
||||
| 20. FAB & Full-Screen Catalog Search | v2.0 | 2/2 | Complete | 2026-04-06 |
|
||||
| 21. Item & Catalog Detail Pages | v2.0 | 1/1 | Complete | 2026-04-06 |
|
||||
| 22. Add-from-Catalog & Thread Integration | v2.0 | 0/2 | Not started | - |
|
||||
| 22. Add-from-Catalog & Thread Integration | v2.0 | 1/2 | In Progress| |
|
||||
| 23. Manual Entry Fallback | v2.0 | 0/? | Not started | - |
|
||||
|
||||
@@ -3,14 +3,14 @@ gsd_state_version: 1.0
|
||||
milestone: v1.3
|
||||
milestone_name: Research & Decision Tools
|
||||
status: planning
|
||||
stopped_at: Phase 22 plans verified
|
||||
last_updated: "2026-04-06T13:47:00.873Z"
|
||||
stopped_at: Completed 22-01-PLAN.md
|
||||
last_updated: "2026-04-06T13:57:51.148Z"
|
||||
last_activity: 2026-04-06
|
||||
progress:
|
||||
total_phases: 16
|
||||
completed_phases: 14
|
||||
total_plans: 43
|
||||
completed_plans: 39
|
||||
completed_plans: 40
|
||||
percent: 0
|
||||
---
|
||||
|
||||
@@ -61,6 +61,7 @@ Key decisions made during v2.0 planning:
|
||||
- [Phase 21]: Preserved currentThreadId derivation in __root.tsx for CandidateDeleteDialog
|
||||
- [Phase 21]: CollectionView empty state Add button rewired to catalog search overlay
|
||||
- [Phase 21]: ItemForm/CandidateForm decoupled from UIStore with onClose prop pattern
|
||||
- [Phase 22]: Sonner for toast notifications; all Phase 22 UIStore states added in Plan 01
|
||||
|
||||
### Pending Todos
|
||||
|
||||
@@ -72,6 +73,7 @@ None active.
|
||||
|---|-------------|------|--------|-----------|
|
||||
| 260406-j44 | Comprehensive dev seed script for bikepacking gear data | 2026-04-06 | — | [260406-j44-comprehensive-dev-seed-script-for-bikepa](./quick/260406-j44-comprehensive-dev-seed-script-for-bikepa/) |
|
||||
| Phase 21 P03 | 6min | 2 tasks | 10 files |
|
||||
| Phase 22 P01 | 7min | 2 tasks | 5 files |
|
||||
|
||||
### Blockers/Concerns
|
||||
|
||||
@@ -80,6 +82,6 @@ None active.
|
||||
|
||||
## Session Continuity
|
||||
|
||||
Last session: 2026-04-06T13:47:00.871Z
|
||||
Stopped at: Phase 22 plans verified
|
||||
Resume file: .planning/phases/22-add-from-catalog-thread-integration/22-01-PLAN.md
|
||||
Last session: 2026-04-06T13:57:51.145Z
|
||||
Stopped at: Completed 22-01-PLAN.md
|
||||
Resume file: None
|
||||
|
||||
@@ -0,0 +1,101 @@
|
||||
---
|
||||
phase: 22-add-from-catalog-thread-integration
|
||||
plan: 01
|
||||
subsystem: ui
|
||||
tags: [react, zustand, sonner, toast, modal, catalog]
|
||||
|
||||
requires:
|
||||
- phase: 21-catalog-search-overlay
|
||||
provides: CatalogSearchOverlay component with stub add handler, FAB menu, global item detail page
|
||||
provides:
|
||||
- AddToCollectionModal component with category, notes, purchase price fields
|
||||
- UIStore modal states for addToCollectionModal, addToThreadModal, catalogSessionThreadId
|
||||
- Sonner toast system at root layout
|
||||
- Wired add-to-collection flow from catalog search and global item detail page
|
||||
- "Add to Thread" button on global item detail page (modal built in Plan 02)
|
||||
affects: [22-02-add-to-thread-modal]
|
||||
|
||||
tech-stack:
|
||||
added: [sonner]
|
||||
patterns: [modal-via-uistore, toast-feedback-on-mutation]
|
||||
|
||||
key-files:
|
||||
created:
|
||||
- src/client/components/AddToCollectionModal.tsx
|
||||
modified:
|
||||
- src/client/stores/uiStore.ts
|
||||
- src/client/routes/__root.tsx
|
||||
- src/client/components/CatalogSearchOverlay.tsx
|
||||
- src/client/routes/global-items/$globalItemId.tsx
|
||||
|
||||
key-decisions:
|
||||
- "Sonner for toast notifications -- lightweight, accessible, matches minimalist design"
|
||||
- "All Phase 22 modal states added in one UIStore extension for Plan 02 readiness"
|
||||
|
||||
patterns-established:
|
||||
- "Toast feedback: use toast.success() from sonner after successful mutations"
|
||||
- "Modal dispatch: UIStore openX(globalItemId, globalItemName) pattern for catalog actions"
|
||||
|
||||
requirements-completed: [CATFLOW-03]
|
||||
|
||||
duration: 7min
|
||||
completed: 2026-04-06
|
||||
---
|
||||
|
||||
# Phase 22 Plan 01: Add-to-Collection Flow Summary
|
||||
|
||||
**AddToCollectionModal with category/notes/price fields, sonner toasts, and wired catalog search + detail page entry points**
|
||||
|
||||
## Performance
|
||||
|
||||
- **Duration:** 7 min
|
||||
- **Started:** 2026-04-06T13:49:46Z
|
||||
- **Completed:** 2026-04-06T13:57:00Z
|
||||
- **Tasks:** 2
|
||||
- **Files modified:** 5
|
||||
|
||||
## Accomplishments
|
||||
- Extended UIStore with addToCollectionModal, addToThreadModal, and catalogSessionThreadId states for full Phase 22 support
|
||||
- Built AddToCollectionModal following CreateThreadModal pattern with category dropdown, notes textarea, and purchase price input
|
||||
- Installed sonner and rendered Toaster at root layout for success feedback
|
||||
- Replaced handleAddStub in CatalogSearchOverlay with mode-aware dispatch to collection or thread modals
|
||||
- Added both "Add to Collection" (primary) and "Add to Thread" (secondary) buttons on global item detail page
|
||||
|
||||
## Task Commits
|
||||
|
||||
Each task was committed atomically:
|
||||
|
||||
1. **Task 1: UIStore extension + sonner setup + AddToCollectionModal** - `f309c73` (feat)
|
||||
2. **Task 2: Wire CatalogSearchOverlay and global item detail page for collection mode** - `ed76236` (feat)
|
||||
|
||||
## Files Created/Modified
|
||||
- `src/client/components/AddToCollectionModal.tsx` - Modal with category, notes, purchase price; calls useCreateItem with globalItemId
|
||||
- `src/client/stores/uiStore.ts` - Added addToCollectionModal, addToThreadModal, catalogSessionThreadId states
|
||||
- `src/client/routes/__root.tsx` - Added Toaster and AddToCollectionModal to root layout
|
||||
- `src/client/components/CatalogSearchOverlay.tsx` - Replaced stub with mode-aware handleAdd dispatching to modals
|
||||
- `src/client/routes/global-items/$globalItemId.tsx` - Added "Add to Collection" and "Add to Thread" buttons wired to UIStore
|
||||
|
||||
## Decisions Made
|
||||
- Used sonner for toast notifications (lightweight, accessible, clean styling)
|
||||
- Added all Phase 22 UIStore states in Task 1 so Plan 02 can consume addToThreadModal and catalogSessionThreadId immediately
|
||||
- closeCatalogSearch now resets catalogSessionThreadId to null for clean session state
|
||||
|
||||
## Deviations from Plan
|
||||
|
||||
None - plan executed exactly as written.
|
||||
|
||||
## Issues Encountered
|
||||
- Service tests (item.service.test.ts, thread.service.test.ts) hang on execution -- pre-existing issue unrelated to client-side changes. Build verification confirms no type errors or regressions.
|
||||
|
||||
## User Setup Required
|
||||
|
||||
None - no external service configuration required.
|
||||
|
||||
## Next Phase Readiness
|
||||
- Plan 02 can immediately build AddToThreadModal consuming addToThreadModal and catalogSessionThreadId from UIStore
|
||||
- "Add to Thread" button on detail page already wired to openAddToThread
|
||||
- CatalogSearchOverlay already dispatches to openAddToThread in thread mode
|
||||
|
||||
---
|
||||
*Phase: 22-add-from-catalog-thread-integration*
|
||||
*Completed: 2026-04-06*
|
||||
Reference in New Issue
Block a user