v1.4 Collection Tools #9

Merged

makiolaj merged 17 commits from feature/v1.4-collection-tools into Develop 2026-04-03 18:05:24 +00:00

Conversation 0 Commits 17 Files Changed 37 +2099 -55

makiolaj commented 2026-04-03 16:15:51 +00:00

Owner

Copy Link

Summary

• Item quantity tracking (×N badge, totals multiply)
• Setup impact preview (weight/cost delta per candidate)
• Item duplication (copy-and-edit workflow)
• CSV import/export (settings page)

Tests

• 234 unit/integration tests
• 24 Playwright E2E tests

Test plan

• Verify item quantity displays correctly
• Verify impact preview shows deltas on thread page
• Verify duplicate creates copy with (copy) suffix
• Verify CSV export/import round-trips data

## Summary - Item quantity tracking (×N badge, totals multiply) - Setup impact preview (weight/cost delta per candidate) - Item duplication (copy-and-edit workflow) - CSV import/export (settings page) ## Tests - 234 unit/integration tests - 24 Playwright E2E tests ## Test plan - [ ] Verify item quantity displays correctly - [ ] Verify impact preview shows deltas on thread page - [ ] Verify duplicate creates copy with (copy) suffix - [ ] Verify CSV export/import round-trips data

makiolaj added 7 commits 2026-04-03 16:15:52 +00:00

docs: add v1.4 Collection Tools design spec ... 1b492f2ac2

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

feat: add quantity field to items schema ... 923a0f66b0

Add integer quantity column (default 1) to the items table, generate
the corresponding Drizzle migration, and extend createItemSchema /
updateItemSchema with an optional positive-integer quantity field.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: add quantity support to totals, UI, and thread resolution ... 1a5e6a303e

- totals.service: multiply weight/cost sums by quantity in category and global totals
- setup.service: multiply by quantity in getAllSetups SQL subqueries; expose quantity in getSetupWithItems item list
- thread.service: explicitly pass quantity: 1 when inserting resolved item
- ItemForm: add Quantity number input (min=1, default=1) after price field
- ItemCard: show ×N badge next to item name when quantity > 1
- CollectionView: pass quantity prop to ItemCard in both filtered and grouped views
- $setupId.tsx: pass quantity to ItemCard; multiply by quantity in client-side per-setup totals
- WeightSummaryCard: multiply by quantity in all chart and legend weight calculations
- useItems / useSetups: add quantity to ItemWithCategory / SetupItemWithCategory interfaces

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: add impact delta computation with TDD tests ... 818db73432

Implements computeImpactDeltas pure function with 8 TDD tests covering replace/add/none modes and null weight/price handling. Adds useImpactDeltas hook, categoryId to ThreadWithCandidates, and selectedSetupId state to uiStore.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: add item duplication with copy-and-edit workflow ... b9a06dd244

Adds POST /api/items/:id/duplicate endpoint, useDuplicateItem hook, and a
Duplicate button on ItemCard (collection view only) that opens the new item
for editing immediately after creation.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: add setup impact preview UI with delta badges across all views ... 8c1fe47a99

Adds SetupImpactSelector dropdown and ImpactDeltaBadge inline badge, wired into the thread detail page. Delta badges appear on CandidateListItem, CandidateCard, and ComparisonTable (Weight Impact / Price Impact rows) whenever a setup is selected for comparison.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: add CSV import/export for gear collection ... 15f146ee89

Adds export (GET /api/items/export) and import (POST /api/items/import) routes
backed by a pure csv.service with no external deps, plus useExportItems/useImportItems
hooks and an Import/Export section in the Settings page.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

makiolaj added 1 commit 2026-04-03 16:18:16 +00:00

fix: commit missing migration metadata and run CI on all branches ... a8696c2a85

The Drizzle migration journal and snapshot for 0008 (quantity column)
were not committed, causing test failures in CI. Also updates CI to
trigger on all branches, not just Develop.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

makiolaj added 9 commits 2026-04-03 18:02:25 +00:00

fix: skip retries on 404 for single-resource queries ... b993a0a831

Prevents 10-second loading skeleton when navigating to non-existent
threads, setups, or items. Shows error/not-found state immediately.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix: add tab navigation to collection page and skip 404 retries ... 3fc737c872

Adds Gear/Planning/Setups pill tabs to the collection page so users
can switch tabs without going back to the dashboard. Also skips
React Query retries on 404 responses for immediate error display.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix: use onDragEnd on Reorder.Item instead of onPointerUp on Group ... 52751ae9d4

The previous approach used onPointerUp on the Reorder.Group which
fired unreliably — triggering on non-drag clicks and sometimes not
at all after a drag. Moving to onDragEnd on each Reorder.Item gives
clean, predictable drag-to-reorder behavior.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix: stabilize drag-to-reorder with layout animation fixes ... 684cfd3789

- Remove transition-all from list items (fights framer-motion layout)
- Add layout="position" to Reorder.Item for proper sibling tracking
- Replace CSS gap with marginBottom (gap confuses layout engine)
- Add explicit short transition duration for snappy reorder

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix: make entire candidate row draggable instead of handle-only ... 27c36b6b9a

Remove dragControls/dragListener pattern which prevented onReorder
from firing. The whole row is now the drag target with visual feedback
(scale + shadow). Grip icon remains as a visual indicator.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix: prevent snap-back after drag and click-opens-edit during drag ... f8a1a00e0a

Two fixes:
- Remove onSettled clearing tempItems before refetch completes,
  let useEffect clear it when fresh server data arrives
- Track isDragging ref to suppress edit panel click after drag
- Remove layout="position" which interfered with reorder detection

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix: remove scale/shadow whileDrag effect that stuck after release ... 33f735af67

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix: show Add Candidate button in comparison view ... 70e7cd2f0f

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix: include quantity in getAllItems select, createItem values, and updateItem type ... fb925a9dce

Quantity was missing from three places in item.service.ts:
- getAllItems didn't select it (API returned undefined)
- createItem didn't pass it to insert (always used DB default of 1)
- updateItem type didn't include it (silently stripped from updates)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

makiolaj merged commit 3eccbb12fd into Develop 2026-04-03 18:05:24 +00:00

makiolaj referenced this issue from a commit 2026-04-03 18:05:24 +00:00

Merge pull request 'v1.4 Collection Tools' (#9) from feature/v1.4-collection-tools into Develop

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

makiolaj

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: makiolaj/GearBox#9