12 KiB
12 KiB
phase, plan, type, wave, depends_on, files_modified, autonomous, requirements, must_haves
| phase | plan | type | wave | depends_on | files_modified | autonomous | requirements | must_haves | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 13-setup-impact-preview | 01 | tdd | 1 |
|
true |
|
|
Purpose: Establish the data layer and contracts that Plan 02 will consume for rendering delta indicators. TDD ensures the replace/add mode logic and null-weight handling are correct before any UI work. Output: Tested pure function, React hook, updated types, uiStore state.
<execution_context> @/home/jlmak/.claude/get-shit-done/workflows/execute-plan.md @/home/jlmak/.claude/get-shit-done/templates/summary.md </execution_context>
@.planning/PROJECT.md @.planning/ROADMAP.md @.planning/STATE.md @.planning/phases/13-setup-impact-preview/13-RESEARCH.mdFrom src/client/hooks/useSetups.ts:
interface SetupItemWithCategory {
id: number;
name: string;
weightGrams: number | null;
priceCents: number | null;
categoryId: number;
notes: string | null;
productUrl: string | null;
imageFilename: string | null;
createdAt: string;
updatedAt: string;
categoryName: string;
categoryIcon: string;
classification: string;
}
export function useSetup(setupId: number | null) {
return useQuery({
queryKey: ["setups", setupId],
queryFn: () => apiGet<SetupWithItems>(`/api/setups/${setupId}`),
enabled: setupId != null, // CRITICAL: prevents null fetch
});
}
From src/client/hooks/useThreads.ts (BEFORE fix):
interface ThreadWithCandidates {
id: number;
name: string;
status: "active" | "resolved";
resolvedCandidateId: number | null;
createdAt: string;
updatedAt: string;
candidates: CandidateWithCategory[];
// NOTE: categoryId is MISSING — server returns it but type omits it
}
From src/client/stores/uiStore.ts (existing pattern):
candidateViewMode: "list" | "grid" | "compare";
setCandidateViewMode: (mode: "list" | "grid" | "compare") => void;
// Add selectedSetupId + setter using same pattern
From src/client/lib/formatters.ts:
export type WeightUnit = "g" | "oz" | "lb" | "kg";
export function formatWeight(grams: number | null | undefined, unit: WeightUnit = "g"): string;
export type Currency = "USD" | "EUR" | "GBP" | "JPY" | "CAD" | "AUD";
export function formatPrice(cents: number | null | undefined, currency: Currency = "USD"): string;
IMPC-02 (replace mode auto-detection):
- Given setup items where one has categoryId === threadCategoryId, mode is "replace"
- In replace mode, weightDelta = candidate.weightGrams - replacedItem.weightGrams
- In replace mode, priceDelta = candidate.priceCents - replacedItem.priceCents
- replacedItemName is populated with the matched item's name
IMPC-03 (add mode):
- Given setup items where NONE have categoryId === threadCategoryId, mode is "add"
- In add mode, weightDelta = candidate.weightGrams (pure addition)
- In add mode, priceDelta = candidate.priceCents (pure addition)
- replacedItemName is null
IMPC-04 (null weight handling):
- Given candidate.weightGrams is null, weightDelta is null (not 0, not NaN)
- Given candidate.priceCents is null, priceDelta is null
- In replace mode with replacedItem.weightGrams null but candidate has weight, weightDelta = candidate.weightGrams (treat as add for that field)
Edge cases:
- Empty candidates array -> returns { mode based on setup, deltas: {} }
- Multiple setup items in same category as thread -> first match used for replacement
2. Create src/client/hooks/useImpactDeltas.ts wrapping in useMemo
3. Add categoryId to ThreadWithCandidates in useThreads.ts
4. Add selectedSetupId + setSelectedSetupId to uiStore.ts
GREEN: Create src/client/lib/impactDeltas.ts with:
- Export types: CandidateInput, SetupItemInput, DeltaMode, CandidateDelta, ImpactDeltas
- Export function computeImpactDeltas(candidates: CandidateInput[], setupItems: SetupItemInput[] | undefined, threadCategoryId: number): ImpactDeltas
- Logic: if !setupItems return { mode: "none", deltas: {} }
- Find replacedItem = setupItems.find(item => item.categoryId === threadCategoryId) ?? null
- mode = replacedItem ? "replace" : "add"
- For each candidate: null-guard weight/price BEFORE arithmetic. In replace mode with non-null replaced value, delta = candidate - replaced. In replace mode with null replaced value, delta = candidate value (like add). In add mode, delta = candidate value.
- Run tests — all MUST pass.
REFACTOR: None needed for pure function.
2. In src/client/hooks/useThreads.ts, add `categoryId: number;` to the ThreadWithCandidates interface, after the `resolvedCandidateId` field. The server already returns this field — the type was simply missing it.
3. Create src/client/hooks/useImpactDeltas.ts:
- Import useMemo from react
- Import computeImpactDeltas and types from "../lib/impactDeltas"
- Import type { SetupItemWithCategory } from "./useSetups"
- Export function useImpactDeltas(candidates: CandidateInput[], setupItems: SetupItemWithCategory[] | undefined, threadCategoryId: number): ImpactDeltas
- Body: return useMemo(() => computeImpactDeltas(candidates, setupItems, threadCategoryId), [candidates, setupItems, threadCategoryId])
- Re-export CandidateDelta, DeltaMode, ImpactDeltas types for convenience
<success_criteria>
- All IMPC requirement behaviors are tested and passing via pure function unit tests
- Data layer contracts (types, hook, uiStore state) are ready for Plan 02 UI consumption
- Zero regressions in existing test suite </success_criteria>