81 lines
2.9 KiB
Markdown
81 lines
2.9 KiB
Markdown
---
|
|
status: complete
|
|
phase: 29-image-presentation
|
|
source: [29-01-SUMMARY.md, 29-02-SUMMARY.md, 29-03-SUMMARY.md, 29-04-SUMMARY.md]
|
|
started: 2026-04-12T19:10:00Z
|
|
updated: 2026-04-13T12:00:00Z
|
|
---
|
|
|
|
## Current Test
|
|
|
|
[testing complete]
|
|
|
|
## Tests
|
|
|
|
### 1. Images use fit-within instead of crop
|
|
expected: Browse any page with item/catalog cards. Images should fit inside the frame without cropping — full image visible, no parts cut off.
|
|
result: pass
|
|
|
|
### 2. Dominant color background fill
|
|
expected: Where an image doesn't fill the entire frame, the empty space is filled with a color extracted from the image (not white or gray).
|
|
result: pass
|
|
|
|
### 3. Crop editor on item detail
|
|
expected: Open an item that has an image. In edit mode, you should see a crop icon button next to the trash icon, positioned as an overlay on the image. Clicking it opens a crop editor with zoom slider.
|
|
result: issue
|
|
reported: "the button is there the framing just doesn't work i think the framing and the fit within might be fighting over it"
|
|
severity: major
|
|
|
|
### 4. Crop editor on image upload
|
|
expected: Upload a new image to an item. After the upload completes, a crop editor should appear automatically.
|
|
result: issue
|
|
reported: "crop editor opens on upload correctly, but after cropping the cropped image isn't shown in the edit state always — after clicking save it is shown correctly"
|
|
severity: minor
|
|
|
|
### 5. Crop settings persist
|
|
expected: Adjust the crop on an item image, save it. Navigate away and come back — image displays with saved crop settings.
|
|
result: pass
|
|
|
|
### 6. Consistency across surfaces
|
|
expected: All image surfaces use the same fit-within + dominant color treatment.
|
|
result: pass
|
|
|
|
## Summary
|
|
|
|
total: 6
|
|
passed: 4
|
|
issues: 2
|
|
pending: 0
|
|
skipped: 0
|
|
blocked: 0
|
|
|
|
## Gaps
|
|
|
|
- truth: "Crop framing should visibly adjust the image within the fit-within frame"
|
|
status: failed
|
|
reason: "User reported: framing doesn't work — fit-within and crop may be fighting over each other"
|
|
severity: major
|
|
test: 3
|
|
artifacts:
|
|
- path: "src/client/components/GearImage.tsx"
|
|
issue: "fit-within object-contain may override crop transform"
|
|
- path: "src/client/components/ImageCropEditor.tsx"
|
|
issue: "crop output not applied as CSS transform on GearImage"
|
|
missing:
|
|
- Reconcile crop positioning with fit-within rendering — crop should adjust focal point within the contain frame
|
|
root_cause: ""
|
|
debug_session: ""
|
|
|
|
- truth: "Cropped image preview should update in edit state immediately after cropping"
|
|
status: failed
|
|
reason: "User reported: cropped image not shown in edit state after cropping, but renders correctly after save"
|
|
severity: minor
|
|
test: 4
|
|
artifacts:
|
|
- path: "src/client/routes/items/$itemId.tsx"
|
|
issue: "local state not updated with crop values after editor closes"
|
|
missing:
|
|
- Update local image preview state with crop values on editor close (before save)
|
|
root_cause: ""
|
|
debug_session: ""
|