Jean-Luc Makiola
5984aabd40
- Create 27-00-SUMMARY.md with test changes documentation - Update STATE.md: advance plan to 3/4, add decisions, update session - Update ROADMAP.md: reflect 2/4 summaries complete for phase 27
73 lines
2.9 KiB
Markdown
73 lines
2.9 KiB
Markdown
---
|
|
phase: 27-top-nav-restructure-and-search-bar-rethink
|
|
plan: "00"
|
|
subsystem: e2e-tests
|
|
tags: [e2e, wave-0, navigation, testing]
|
|
dependency_graph:
|
|
requires: []
|
|
provides: [27-00-e2e-scaffolding]
|
|
affects: [e2e/dashboard.spec.ts, e2e/collection.spec.ts]
|
|
tech_stack:
|
|
added: []
|
|
patterns: [playwright-test-fixme, wave-0-red-tests]
|
|
key_files:
|
|
created: []
|
|
modified:
|
|
- e2e/dashboard.spec.ts
|
|
- e2e/collection.spec.ts
|
|
decisions:
|
|
- "Wave 0 tests use test.fixme for removed dashboard cards rather than deletion — preserves test intent for future reference"
|
|
- "Old setups tab test replaced with fallback-to-gear assertion matching the Zod .catch('gear') behavior planned in Plans 01-03"
|
|
metrics:
|
|
duration: ~5min
|
|
completed: "2026-04-10T21:44:15Z"
|
|
tasks_completed: 2
|
|
files_modified: 2
|
|
---
|
|
|
|
# Phase 27 Plan 00: Wave 0 E2E Test Scaffolding Summary
|
|
|
|
Wave 0 E2E scaffolding: replaced old dashboard card assertions with TopNav and discovery section tests, removed Setups tab from Collection specs, added standalone /setups route and mobile bottom tab bar tests.
|
|
|
|
## What Was Done
|
|
|
|
### Task 1: Update dashboard E2E tests
|
|
|
|
Updated `e2e/dashboard.spec.ts` to match the post-Phase-27 navigation structure:
|
|
|
|
- Replaced "shows Collection, Planning, and Setups card headings" with "shows discovery section headings" — now asserts `Popular Setups`, `Recently Added`, and `Trending Categories` section headings
|
|
- Replaced "Collection card links to /collection" with "top nav contains Collection link" — now uses `page.locator("nav")` to find the nav link
|
|
- Added "shows top nav with navigation links" — asserts Home, Collection, Setups are present in the nav element
|
|
- Added "shows bottom tab bar on mobile viewport" — sets viewport to 375x667 and asserts Home, Collection, Setups, Search tab labels are visible
|
|
- Marked "shows collection card with item count of 6", "shows active thread count on Planning card", and "shows setup count on Setups card" as `test.fixme` with explanatory comments about the Phase 27 removal
|
|
|
|
The "shows GearBox heading" test remains unchanged — GearBox text is still visible as the nav logo.
|
|
|
|
### Task 2: Update collection E2E tests
|
|
|
|
Updated `e2e/collection.spec.ts` to reflect Setups tab removal from Collection:
|
|
|
|
- Replaced "navigates to setups tab" (which asserted Weekend Overnighter at `/collection?tab=setups`) with "setups tab URL falls back to gear tab" — asserts Zpacks Duplex is visible instead
|
|
- Added new `test.describe("Setups page")` block with "navigates to /setups and shows seeded setup" test
|
|
- All Gear tab tests, planning tab test, and gear-is-default test are unchanged
|
|
|
|
## Commit
|
|
|
|
- `94e2094` — test(27-00): wave 0 E2E scaffolding for Phase 27 nav restructure
|
|
|
|
## Deviations from Plan
|
|
|
|
None — plan executed exactly as written.
|
|
|
|
## Known Stubs
|
|
|
|
None. These are test files only — no UI stubs introduced.
|
|
|
|
## Self-Check
|
|
|
|
Files modified:
|
|
- `e2e/dashboard.spec.ts` — FOUND
|
|
- `e2e/collection.spec.ts` — FOUND
|
|
|
|
Commit 94e2094 — FOUND
|