docs(10-01): complete dead-code-cleanup plan
- Create 10-01-SUMMARY.md: deleted 3 orphaned v1.0 daily plan files, removed DailyPlanState - Update STATE.md: position, decisions, blocker resolved, session info - Update ROADMAP.md: Phase 10 complete, 10-01-PLAN.md checked off - Update REQUIREMENTS.md: CLN-01 marked complete
This commit is contained in:
@@ -23,7 +23,7 @@ Requirements for milestone v1.2 Polish & Task Management. Each maps to roadmap p
|
||||
|
||||
### Cleanup
|
||||
|
||||
- [ ] **CLN-01**: Dead code from v1.0 daily plan (daily_plan_providers.dart, daily_plan_task_row.dart, progress_card.dart) is removed without breaking notification service (DailyPlanDao must be preserved)
|
||||
- [x] **CLN-01**: Dead code from v1.0 daily plan (daily_plan_providers.dart, daily_plan_task_row.dart, progress_card.dart) is removed without breaking notification service (DailyPlanDao must be preserved)
|
||||
|
||||
## Future Requirements
|
||||
|
||||
|
||||
@@ -35,7 +35,7 @@ See `milestones/v1.1-ROADMAP.md` for full phase details.
|
||||
|
||||
- [x] **Phase 8: Task Delete** - Add smart delete action to tasks — hard delete if never completed, soft delete (deactivate) if completed at least once (completed 2026-03-18)
|
||||
- [x] **Phase 9: Task Creation UX** - Rework the frequency picker from flat preset chips to an intuitive "Every N units" interface with quick-select shortcuts (completed 2026-03-18)
|
||||
- [ ] **Phase 10: Dead Code Cleanup** - Remove orphaned v1.0 daily plan files and verify no regressions
|
||||
- [x] **Phase 10: Dead Code Cleanup** - Remove orphaned v1.0 daily plan files and verify no regressions (completed 2026-03-19)
|
||||
|
||||
## Phase Details
|
||||
|
||||
@@ -74,7 +74,7 @@ Plans:
|
||||
**Requirements**: CLN-01
|
||||
**Plans:** 1 plan
|
||||
Plans:
|
||||
- [ ] 10-01-PLAN.md — Delete 3 orphaned presentation files, remove DailyPlanState, verify zero regressions
|
||||
- [x] 10-01-PLAN.md — Delete 3 orphaned presentation files, remove DailyPlanState, verify zero regressions (completed 2026-03-19)
|
||||
**Success Criteria** (what must be TRUE):
|
||||
1. daily_plan_providers.dart, daily_plan_task_row.dart, and progress_card.dart are deleted
|
||||
2. DailyPlanDao is preserved (still used by notification service)
|
||||
@@ -94,4 +94,4 @@ Plans:
|
||||
| 7. Task Sorting | v1.1 | 2/2 | Complete | 2026-03-16 |
|
||||
| 8. Task Delete | 2/2 | Complete | 2026-03-18 | - |
|
||||
| 9. Task Creation UX | 1/1 | Complete | 2026-03-18 | - |
|
||||
| 10. Dead Code Cleanup | v1.2 | 0/1 | Planned | - |
|
||||
| 10. Dead Code Cleanup | v1.2 | 1/1 | Complete | 2026-03-19 |
|
||||
|
||||
@@ -2,16 +2,16 @@
|
||||
gsd_state_version: 1.0
|
||||
milestone: v1.0
|
||||
milestone_name: milestone
|
||||
status: "Ready for /gsd:plan-phase 8"
|
||||
stopped_at: Completed 09-task-creation-ux 09-01-PLAN.md
|
||||
last_updated: "2026-03-18T21:51:04.991Z"
|
||||
last_activity: 2026-03-18 — Created v1.2 milestone
|
||||
status: "Completed 10-dead-code-cleanup 10-01-PLAN.md"
|
||||
stopped_at: Completed 10-dead-code-cleanup 10-01-PLAN.md
|
||||
last_updated: "2026-03-19T00:05:00Z"
|
||||
last_activity: 2026-03-19 — Deleted orphaned v1.0 daily plan files and removed DailyPlanState
|
||||
progress:
|
||||
total_phases: 3
|
||||
completed_phases: 2
|
||||
total_plans: 3
|
||||
completed_plans: 3
|
||||
percent: 0
|
||||
total_plans: 4
|
||||
completed_plans: 4
|
||||
percent: 100
|
||||
---
|
||||
|
||||
# Project State
|
||||
@@ -26,12 +26,12 @@ See: .planning/PROJECT.md (updated 2026-03-18)
|
||||
## Current Position
|
||||
|
||||
Milestone: v1.2 Polish & Task Management
|
||||
Phase: 8 — Task Delete (not yet planned)
|
||||
Status: Ready for /gsd:plan-phase 8
|
||||
Last activity: 2026-03-18 — Created v1.2 milestone
|
||||
Phase: 10 — Dead Code Cleanup (complete)
|
||||
Status: Completed 10-dead-code-cleanup 10-01-PLAN.md
|
||||
Last activity: 2026-03-19 — Deleted orphaned v1.0 daily plan files and removed DailyPlanState
|
||||
|
||||
```
|
||||
Progress: [░░░░░░░░░░] 0% (0/3 phases)
|
||||
Progress: [██████████] 100% (1/1 plans in phase 10)
|
||||
```
|
||||
|
||||
## Performance Metrics
|
||||
@@ -45,6 +45,7 @@ Progress: [░░░░░░░░░░] 0% (0/3 phases)
|
||||
| Phase 08-task-delete P01 | 9 | 2 tasks | 11 files |
|
||||
| Phase 08-task-delete P02 | 2 | 2 tasks | 3 files |
|
||||
| Phase 09-task-creation-ux P01 | 2 | 1 tasks | 4 files |
|
||||
| Phase 10-dead-code-cleanup P01 | 5 | 2 tasks | 4 files |
|
||||
|
||||
## Accumulated Context
|
||||
|
||||
@@ -57,6 +58,8 @@ Decisions archived to PROJECT.md Key Decisions table.
|
||||
- [Phase 08-task-delete]: smartDeleteTask kept separate from deleteTask to preserve existing hard-delete path for cascade/other uses
|
||||
- [Phase 08-task-delete]: Delete button placed after history section with divider, visible only in edit mode
|
||||
- [Phase 09-task-creation-ux]: Picker is single source of truth: _resolveFrequency() reads from picker always; _ShortcutFrequency enum handles bidirectional sync via toPickerValues()/fromPickerValues()
|
||||
- [Phase 10-dead-code-cleanup]: DailyPlanDao kept in database.dart — still used by settings service; only the three presentation layer files were deleted
|
||||
- [Phase 10-dead-code-cleanup]: TaskWithRoom retained in daily_plan_models.dart — actively used by calendar_dao.dart, calendar_providers.dart, and related calendar files
|
||||
|
||||
### Pending Todos
|
||||
|
||||
@@ -64,11 +67,11 @@ None.
|
||||
|
||||
### Blockers/Concerns
|
||||
|
||||
- Dead code from v1.0: daily_plan_providers.dart, daily_plan_task_row.dart, progress_card.dart (DailyPlanDao still used by notification service) — scheduled for Phase 10
|
||||
None.
|
||||
|
||||
## Session Continuity
|
||||
|
||||
Last session: 2026-03-18T21:46:51.066Z
|
||||
Stopped at: Completed 09-task-creation-ux 09-01-PLAN.md
|
||||
Last session: 2026-03-19T00:05:00Z
|
||||
Stopped at: Completed 10-dead-code-cleanup 10-01-PLAN.md
|
||||
Resume file: None
|
||||
Next action: /gsd:plan-phase 8
|
||||
Next action: Phase 10 complete
|
||||
|
||||
98
.planning/phases/10-dead-code-cleanup/10-01-SUMMARY.md
Normal file
98
.planning/phases/10-dead-code-cleanup/10-01-SUMMARY.md
Normal file
@@ -0,0 +1,98 @@
|
||||
---
|
||||
phase: 10-dead-code-cleanup
|
||||
plan: 01
|
||||
subsystem: ui
|
||||
tags: [flutter, dead-code, cleanup, daily-plan, calendar]
|
||||
|
||||
# Dependency graph
|
||||
requires:
|
||||
- phase: 05-calendar-strip
|
||||
provides: "Calendar strip that superseded daily_plan_providers.dart, daily_plan_task_row.dart, progress_card.dart"
|
||||
provides:
|
||||
- "Three orphaned v1.0 daily plan presentation files removed from codebase"
|
||||
- "DailyPlanState class removed; TaskWithRoom class retained in daily_plan_models.dart"
|
||||
affects: []
|
||||
|
||||
# Tech tracking
|
||||
tech-stack:
|
||||
added: []
|
||||
patterns: []
|
||||
|
||||
key-files:
|
||||
created: []
|
||||
modified:
|
||||
- lib/features/home/domain/daily_plan_models.dart
|
||||
|
||||
key-decisions:
|
||||
- "DailyPlanDao kept in database.dart registration — still used by notification/settings service; only the presentation layer files were deleted"
|
||||
- "TaskWithRoom retained in daily_plan_models.dart — actively imported by calendar_dao.dart, calendar_providers.dart, and related calendar files"
|
||||
|
||||
patterns-established: []
|
||||
|
||||
requirements-completed: [CLN-01]
|
||||
|
||||
# Metrics
|
||||
duration: 5min
|
||||
completed: 2026-03-19
|
||||
---
|
||||
|
||||
# Phase 10 Plan 01: Dead Code Cleanup Summary
|
||||
|
||||
**Deleted three orphaned v1.0 daily plan presentation files and stripped DailyPlanState from domain models, leaving TaskWithRoom intact for the calendar system — zero test/analysis regressions across all 144 tests.**
|
||||
|
||||
## Performance
|
||||
|
||||
- **Duration:** ~5 min
|
||||
- **Started:** 2026-03-19T00:00:54Z
|
||||
- **Completed:** 2026-03-19T00:05:00Z
|
||||
- **Tasks:** 2
|
||||
- **Files modified:** 4 (3 deleted, 1 trimmed)
|
||||
|
||||
## Accomplishments
|
||||
|
||||
- Deleted `daily_plan_providers.dart`, `daily_plan_task_row.dart`, and `progress_card.dart` — all orphaned since Phase 5 replaced the daily plan UI with the calendar strip
|
||||
- Removed `DailyPlanState` class from `daily_plan_models.dart` (it was only referenced by the now-deleted providers file)
|
||||
- Preserved `TaskWithRoom` in `daily_plan_models.dart` — confirmed it remains importable by calendar system files
|
||||
- `dart analyze` reports zero issues; all 144 tests pass with no regressions
|
||||
|
||||
## Task Commits
|
||||
|
||||
Each task was committed atomically:
|
||||
|
||||
1. **Task 1: Delete orphaned files and remove DailyPlanState** - `510529a` (chore)
|
||||
2. **Task 2: Verify zero regressions** - verification only, no file changes
|
||||
|
||||
**Plan metadata:** (docs commit — see final commit)
|
||||
|
||||
## Files Created/Modified
|
||||
|
||||
- `lib/features/home/domain/daily_plan_models.dart` - Removed DailyPlanState class (lines 16-31); TaskWithRoom preserved
|
||||
- `lib/features/home/presentation/daily_plan_providers.dart` - DELETED (orphaned v1.0 file)
|
||||
- `lib/features/home/presentation/daily_plan_task_row.dart` - DELETED (orphaned v1.0 file)
|
||||
- `lib/features/home/presentation/progress_card.dart` - DELETED (orphaned v1.0 file)
|
||||
|
||||
## Decisions Made
|
||||
|
||||
- DailyPlanDao was NOT removed from `database.dart` — it is still registered in the `@DriftDatabase` annotation and used by `settings_screen.dart`. Only the presentation layer files were deleted.
|
||||
- TaskWithRoom was kept because it is imported by: `calendar_dao.dart`, `calendar_providers.dart`, `calendar_models.dart`, `calendar_day_list.dart`, `calendar_task_row.dart`, and `daily_plan_dao.dart`.
|
||||
|
||||
## Deviations from Plan
|
||||
|
||||
None - plan executed exactly as written.
|
||||
|
||||
## Issues Encountered
|
||||
|
||||
None.
|
||||
|
||||
## User Setup Required
|
||||
|
||||
None - no external service configuration required.
|
||||
|
||||
## Next Phase Readiness
|
||||
|
||||
- Phase 10 dead code cleanup complete
|
||||
- No blockers — dead code that was tracked as a blocker in STATE.md is now resolved
|
||||
|
||||
---
|
||||
*Phase: 10-dead-code-cleanup*
|
||||
*Completed: 2026-03-19*
|
||||
Reference in New Issue
Block a user