Compare commits

..
Author SHA1 Message Date
makiolaj f64cb24c6b docs(changelog): note the French agenda-range crash fix 2026-09-12 16:17:09 +02:00
makiolaj 74e39c1c7b chore(i18n): drop Belarusian keys removed from the base in 2.20.2
Release v2.20.2 removed crash_report_issue_title,
crash_report_body_template and crash_report_body_paste from the base
strings.xml, but values-be still carried its translations of them.
check_translations.py fails on stale keys, and since translations.yaml
runs on every PR with no path filter, the required "Translations / check"
status has been red for every pull request opened since that release.

There is nothing left for these to translate, so remove them.
2026-09-12 16:16:14 +02:00
makiolaj 0828a01650 fix(i18n): give the French agenda_range_days plural its "other" form
Fixes the crash in #297 and #298. French resolves every count from 2
upwards to "other", so a custom agenda range of 2+ days threw
Resources$NotFoundException on the label — in the settings summary, in
the range picker, and live while typing a day count.

Corrected in Weblate first (unit 2849, whose third plural form was
stored empty), so this file and Weblate now agree and the next sync
cannot strip the item again.
2026-09-12 16:16:14 +02:00
makiolaj 8cd9a7b4e1 fix(i18n): fail CI when a translated plurals has no "other" form
Codeberg #297 and #298 are the same crash, reported twice from fr-FR:

    Resources$NotFoundException: Plural resource ID #0x7f0f0000
                                 quantity=14 item=other

values-fr translated agenda_range_days with only "one" and "many".
French "many" matches millions only, so every count from 2 upwards
resolves to "other" — which the translation doesn't define. Android
falls back to "other" for any quantity form it can't find, but nothing
falls back for "other" itself and there is no fall back to the base
locale either, so getQuantityString throws. Any French user with a
custom agenda range of 2+ days crashed the moment that label composed:
the settings summary, the range picker, and the live preview while
typing a day count.

Nothing caught it. The lint config downgrades MissingQuantity on the
grounds that a missing form "falls back to other at runtime" — true of
every form except "other", which is the one that was missing here. And
check_translations.py treated <plurals> as an opaque key via
RESOURCE_TAGS, never looking inside at quantities.

So enforce the one invariant Android actually requires: a translated
<plurals> must carry an "other" item. Locales may still skip forms
their language rarely uses (Arabic "zero", the missing Italian "many"
in search_delete_title) because those do fall back. Lint's
MissingQuantity can't tell the two cases apart, which is why this lives
in the script rather than in a lint severity, and the stale lint comment
is corrected to say so.

The broken French string itself is owned by Weblate and is fixed there.
2026-09-12 16:10:07 +02:00
14 changed files with 3 additions and 27 deletions
+1 -1
View File
@@ -5,7 +5,7 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [2.20.3] — 2026-09-12
## [Unreleased]
### Fixed
- **A custom agenda range crashed the app in French.** Choosing a custom range
+2 -2
View File
@@ -28,8 +28,8 @@ android {
// which builds this version and then creates the matching vX.Y.Z tag +
// release itself (versionCode is pinned to MAJOR*10000 + MINOR*100 +
// PATCH from versionName, e.g. 2.7.2 -> 20702). See docs/RELEASING.md.
versionCode = 22003
versionName = "2.20.3"
versionCode = 22002
versionName = "2.20.2"
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
}
@@ -1,2 +0,0 @@
إصلاحات
• لم يعد النطاق المخصص في الجدول يُعطِّل التطبيق بالفرنسية. كان اختيار نطاق مخصص — أو مجرّد كتابة رقم في ذلك الحقل — يُغلق التطبيق على أي هاتف مضبوط على الفرنسية، ولم ينجُ سوى نطاق يوم واحد بالضبط. أما اللغات الأخرى فلم تتأثّر قطّ.
@@ -1,2 +0,0 @@
Behoben
• Ein benutzerdefinierter Agenda-Zeitraum stürzt auf Französisch nicht mehr ab. Einen eigenen Zeitraum zu wählen oder auch nur eine Zahl in das Feld zu tippen beendete die App auf jedem Gerät mit französischer Sprache; nur genau ein Tag blieb verschont. Andere Sprachen waren nie betroffen.
@@ -1,2 +0,0 @@
Fixed
• A custom Agenda range no longer crashes the app in French. Choosing a custom range — or just typing a number into that field — closed the app on any phone set to French, and only a range of exactly one day escaped it. Other languages were never affected.
@@ -1,2 +0,0 @@
Fixed
• A custom Agenda range no longer crashes the app in French. Choosing a custom range — or just typing a number into that field — closed the app on any phone set to French, and only a range of exactly one day escaped it. Other languages were never affected.
@@ -1,2 +0,0 @@
Correcciones
• El intervalo personalizado de la Agenda ya no bloquea la aplicación en francés. Elegir un intervalo propio —o solo escribir un número en ese campo— cerraba la aplicación en cualquier teléfono en francés, y únicamente un intervalo de exactamente un día se salvaba. Los demás idiomas nunca se vieron afectados.
@@ -1,2 +0,0 @@
Corrections
• La plage personnalisée de lAgenda ne fait plus planter lapplication en français. Choisir une plage personnalisée — ou simplement saisir un nombre dans ce champ — fermait lapplication sur tout téléphone en français ; seule une plage dexactement un jour y échappait.
@@ -1,2 +0,0 @@
Correzioni
• Lintervallo personalizzato dellAgenda non fa più chiudere lapp in francese. Scegliere un intervallo personalizzato — o anche solo digitare un numero in quel campo — chiudeva lapp su qualsiasi telefono impostato in francese; solo un intervallo di esattamente un giorno ne era immune. Le altre lingue non sono mai state interessate.
@@ -1,2 +0,0 @@
Poprawki
• Niestandardowy zakres Agendy nie powoduje już awarii aplikacji w języku francuskim. Wybranie własnego zakresu albo samo wpisanie liczby w to pole zamykało aplikację na każdym telefonie ustawionym na francuski; bezpieczny był tylko zakres dokładnie jednego dnia. Innych języków to nigdy nie dotyczyło.
@@ -1,2 +0,0 @@
Correções
• O intervalo personalizado da Agenda não fecha mais o aplicativo em francês. Escolher um intervalo personalizado — ou apenas digitar um número nesse campo — fechava o aplicativo em qualquer telefone configurado em francês; só um intervalo de exatamente um dia escapava. Os outros idiomas nunca foram afetados.
@@ -1,2 +0,0 @@
Correções
• O intervalo personalizado da Agenda já não fecha a aplicação em francês. Escolher um intervalo personalizado — ou apenas escrever um número nesse campo — fechava a aplicação em qualquer telemóvel definido em francês; só um intervalo de exatamente um dia escapava. Os outros idiomas nunca foram afetados.
@@ -1,2 +0,0 @@
Исправлено
• Свой диапазон в Расписании больше не приводит к сбою на французском языке. Выбор своего диапазона — или даже простой ввод числа в это поле — закрывал приложение на любом телефоне с французским языком; уцелел только диапазон ровно в один день. Другие языки это никогда не затрагивало.
@@ -1,2 +0,0 @@
修复
• 法语下的日程自定义范围不再导致应用崩溃。选择自定义范围,甚至只是在该字段中输入数字,都会让应用在设置为法语的手机上关闭,只有恰好一天的范围不受影响。其他语言从未受到影响。