fix(calendar): don't register calendar observer before permission granted #19

makiolaj · 2026-06-21T09:53:01Z

makiolaj commented

2026-06-21 09:53:01 +00:00

Fixes the startup crash where the app died instantly on launch whenever calendar access wasn't granted (fresh install / revoked permission).

The repo registers a calendar ContentObserver eagerly in its init block, and an activity-scoped SettingsViewModel (drives the theme) injects it — so the @Singleton is built at launch, above RootScreen's permission gate. Newer Android throws SecurityException when registering an observer on a provider you lack permission for, so the app crashed before the permission screen could appear.

Fix: guard registration behind a calendar-permission check and re-attach the observer lazily on the first calendars()/instances() read (runs once the gate opens). Observer collections are now synchronized.

Verified on-device (debug): permission-denied launch shows the permission screen; granting it proceeds to the calendar with live updates. Unit tests pass.

Cuts release v2.7.1 (CHANGELOG + version bump included).

Fixes the startup crash where the app died instantly on launch whenever calendar access wasn't granted (fresh install / revoked permission). The repo registers a calendar ContentObserver eagerly in its init block, and an activity-scoped SettingsViewModel (drives the theme) injects it — so the @Singleton is built at launch, above RootScreen's permission gate. Newer Android throws SecurityException when registering an observer on a provider you lack permission for, so the app crashed before the permission screen could appear. Fix: guard registration behind a calendar-permission check and re-attach the observer lazily on the first calendars()/instances() read (runs once the gate opens). Observer collections are now synchronized. Verified on-device (debug): permission-denied launch shows the permission screen; granting it proceeds to the calendar with live updates. Unit tests pass. Cuts release v2.7.1 (CHANGELOG + version bump included).

makiolaj added 1 commit 2026-06-21 09:53:01 +00:00

fix(calendar): don't register calendar observer before permission granted

CI / ci (push) Successful in 4m15s

Details

997ee44792

The repository registers a ContentObserver on the calendar provider eagerly
in its init block, and an activity-scoped SettingsViewModel (which drives the
theme) injects that repository — so the @Singleton is constructed at launch,
above RootScreen's permission gate. On newer Android, registering an observer
on a provider you lack permission for throws SecurityException instead of
silently no-op'ing, so the app crashed instantly on every launch whenever
calendar access wasn't granted (fresh install or revoked permission), before
the permission screen could ever appear.

Guard the registration behind a calendar-permission check and re-attach the
observer lazily on the first calendars()/instances() read, which runs once the
gate opens and screens subscribe. Access to the observer collections is now
synchronized since registration can happen on the main thread (repo init) or
the IO dispatcher (query re-attach).

Verified on-device: permission-denied launch shows the permission screen
instead of crashing; granting it proceeds to the calendar with live updates.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

makiolaj merged commit 297a2350e3 into main

2026-06-21 09:59:33 +00:00

makiolaj deleted branch fix/calendar-observer-permission-crash

2026-06-21 09:59:33 +00:00

makiolaj referenced this issue from a commit

2026-06-21 09:59:34 +00:00

Merge pull request 'fix(calendar): don't register calendar observer before permission granted' (#19) from fix/calendar-observer-permission-crash into main

makiolaj referenced this issue from a commit

2026-07-01 13:58:16 +00:00

feat(theme): user-selectable custom fonts (#19)

makiolaj referenced this pull request

2026-07-02 08:28:17 +00:00