makiolaj/floret-kit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(components): expose SelectedCheck as a family primitive #2

Merged
makiolaj merged 1 commits from feat/selected-check-primitive into main 2026-07-20 13:27:23 +00:00
Conversation 0 Commits 1 Files Changed 1 +11 -1
makiolaj commented 2026-07-20 13:18:51 +00:00
Owner
Copy Link

Makes SelectedCheck public so picker consumers stop hand-rolling it.

It was private to OptionPicker, so every consumer re-derived the same Icon. Calendula alone carried five copies, and they had drifted on icon style — the kit drew Icons.Rounded.Check, all five app copies drew Icons.Default.Check (Filled).

Now public with KDoc, keeping the kit's existing Rounded glyph. No behaviour change inside the kit: OptionPicker calls the same function it always did.

Consumed by the companion Calendula PR, which deletes its five copies against this.

🤖 Generated with Claude Code

Makes `SelectedCheck` public so picker consumers stop hand-rolling it. It was private to `OptionPicker`, so every consumer re-derived the same Icon. Calendula alone carried **five copies**, and they had drifted on icon style — the kit drew `Icons.Rounded.Check`, all five app copies drew `Icons.Default.Check` (Filled). Now public with KDoc, keeping the kit's existing Rounded glyph. No behaviour change inside the kit: `OptionPicker` calls the same function it always did. Consumed by the companion Calendula PR, which deletes its five copies against this. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
makiolaj added 1 commit 2026-07-20 13:18:51 +00:00
feat(components): expose SelectedCheck as a family primitive b4954713ff 
The trailing check that marks a chosen row in a full-screen picker was
private to OptionPicker, so every consumer hand-rolled its own copy.
Calendula alone carried five, and they had drifted: the kit drew
Icons.Rounded.Check, all five app copies drew Icons.Default.Check.

Make it public with KDoc so pickers share one selection affordance
instead of re-deriving it. Rounded wins, as the kit's existing choice.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
makiolaj merged commit 75b90d1b3b into main 2026-07-20 13:27:23 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
makiolaj
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: makiolaj/floret-kit#2
Delete Branch "feat/selected-check-primitive"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?